remove not needed spaces (#5495)

* remove not usefull spaces

* increase timeout

* increase timeout

* fix

e2e/content-services/upload/cancel-upload.e2e.ts

@@ -56,7 +56,7 @@ describe('Upload component', async () => {
     });
 
     it('[C272792] Should be possible to cancel upload of a big file using row cancel icon', async () => {
-        await browser.executeScript('setTimeout(() => {document.querySelector("div[data-automation-id=\'cancel-upload-progress\']").click();}, 1500)');
+        await browser.executeScript('setTimeout(() => {document.querySelector("div[data-automation-id=\'cancel-upload-progress\']").click();}, 2500)');
 
         await contentServicesPage.uploadFile(largeFile.location);
 
@@ -68,7 +68,7 @@ describe('Upload component', async () => {
 
     it('[C287790] Should be possible to cancel upload of a big file through the cancel uploads button', async () => {
         await browser.executeScript(' setTimeout(() => {document.querySelector("#adf-upload-dialog-cancel-all").click();' +
-            'document.querySelector("#adf-upload-dialog-cancel").click();  }, 1500)');
+            'document.querySelector("#adf-upload-dialog-cancel").click();  }, 2500)');
         await contentServicesPage.uploadFile(largeFile.location);
         await expect(await uploadDialog.getTitleText()).toEqual('Upload canceled');
         await uploadDialog.clickOnCloseButton();
@@ -79,7 +79,7 @@ describe('Upload component', async () => {
     it('[C272793] Should be able to cancel multiple files upload', async () => {
         await uploadToggles.enableMultipleFileUpload();
         await browser.executeScript(' setTimeout(() => {document.querySelector("#adf-upload-dialog-cancel-all").click();' +
-            'document.querySelector("#adf-upload-dialog-cancel").click();  }, 1500)');
+            'document.querySelector("#adf-upload-dialog-cancel").click();  }, 4000)');
         await contentServicesPage.uploadMultipleFile([pngFileModel.location, largeFile.location]);
 
         await expect(await uploadDialog.getTitleText()).toEqual('Upload canceled');
@@ -92,7 +92,7 @@ describe('Upload component', async () => {
 
     it('[C315257] Should be able to cancel file in upload queue', async () => {
         await uploadToggles.enableMultipleFileUpload();
-        await browser.executeScript('setTimeout(() => {document.querySelector("button[data-automation-id=\'cancel-upload-queue\']").click();}, 1500)');
+        await browser.executeScript('setTimeout(() => {document.querySelector("button[data-automation-id=\'cancel-upload-queue\']").click();}, 2500)');
         await contentServicesPage.uploadMultipleFile([largeFile.location, pngFileModel.location]);
         await uploadDialog.fileIsCancelled(pngFileModel.name);
         await uploadDialog.clickOnCloseButton();

e2e/content-services/upload/excluded-file.e2e.ts

@@ -65,18 +65,15 @@ describe('Upload component - Excluded Files', () => {
         await loginPage.loginToContentServicesUsingUserModel(acsUser);
 
         await contentServicesPage.goToDocumentList();
-
-    });
+   });
 
     afterAll(async () => {
         await navigationBarPage.clickLogoutButton();
-
-    });
+   });
 
     afterEach(async () => {
         await contentServicesPage.goToDocumentList();
-
-    });
+   });
 
     it('[C279914] Should not allow upload default excluded files using D&D', async () => {
         await contentServicesPage.checkDragAndDropDIsDisplayed();

e2e/content-services/upload/upload-dialog.e2e.ts

@@ -71,8 +71,7 @@ describe('Upload component', () => {
         await contentServicesPage.goToDocumentList();
         const pdfUploadedFile = await uploadActions.uploadFile(firstPdfFileModel.location, firstPdfFileModel.name, '-my-');
         Object.assign(firstPdfFileModel, pdfUploadedFile.entry);
-
-    });
+   });
 
     beforeEach(async () => {
         await contentServicesPage.goToDocumentList();

e2e/content-services/upload/upload-dialog.ts

@@ -1,191 +0,0 @@
-/*!
- * @license
- * Copyright 2019 Alfresco Software, Ltd.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-import { BrowserActions, LoginPage, UploadActions } from '@alfresco/adf-testing';
-import { ContentServicesPage } from '../../pages/adf/content-services.page';
-import { UploadDialogPage } from '../../pages/adf/dialog/upload-dialog.page';
-import { UploadTogglesPage } from '../../pages/adf/dialog/upload-toggles.page';
-import { AcsUserModel } from '../../models/ACS/acs-user.model';
-import { FileModel } from '../../models/ACS/file.model';
-import { browser } from 'protractor';
-import { AlfrescoApiCompatibility as AlfrescoApi } from '@alfresco/js-api';
-import { VersionManagePage } from '../../pages/adf/version-manager.page';
-import { NavigationBarPage } from '../../pages/adf/navigation-bar.page';
-
-describe('Upload component', () => {
-
-    const contentServicesPage = new ContentServicesPage();
-    const uploadDialog = new UploadDialogPage();
-    const uploadToggles = new UploadTogglesPage();
-    const loginPage = new LoginPage();
-    const acsUser = new AcsUserModel();
-    const versionManagePage = new VersionManagePage();
-    const navigationBarPage = new NavigationBarPage();
-
-    this.alfrescoJsApi = new AlfrescoApi({
-        provider: 'ECM',
-        hostEcm: browser.params.testConfig.adf_acs.host
-    });
-    const uploadActions = new UploadActions(this.alfrescoJsApi);
-
-    const firstPdfFileModel = new FileModel({
-        'name': browser.params.resources.Files.ADF_DOCUMENTS.PDF_B.file_name,
-        'location': browser.params.resources.Files.ADF_DOCUMENTS.PDF_B.file_location
-    });
-    const docxFileModel = new FileModel({
-        'name': browser.params.resources.Files.ADF_DOCUMENTS.DOCX.file_name,
-        'location': browser.params.resources.Files.ADF_DOCUMENTS.DOCX.file_location
-    });
-    const pdfFileModel = new FileModel({
-        'name': browser.params.resources.Files.ADF_DOCUMENTS.PDF.file_name,
-        'location': browser.params.resources.Files.ADF_DOCUMENTS.PDF.file_location
-    });
-    const pngFileModelTwo = new FileModel({
-        'name': browser.params.resources.Files.ADF_DOCUMENTS.PNG_B.file_name,
-        'location': browser.params.resources.Files.ADF_DOCUMENTS.PNG_B.file_location
-    });
-    const pngFileModel = new FileModel({
-        'name': browser.params.resources.Files.ADF_DOCUMENTS.PNG.file_name,
-        'location': browser.params.resources.Files.ADF_DOCUMENTS.PNG.file_location
-    });
-    const filesLocation = [pdfFileModel.location, docxFileModel.location, pngFileModel.location, firstPdfFileModel.location];
-    const filesName = [pdfFileModel.name, docxFileModel.name, pngFileModel.name, firstPdfFileModel.name];
-
-    beforeAll(async () => {
-        await this.alfrescoJsApi.login(browser.params.testConfig.adf.adminEmail, browser.params.testConfig.adf.adminPassword);
-        await this.alfrescoJsApi.core.peopleApi.addPerson(acsUser);
-        await this.alfrescoJsApi.login(acsUser.id, acsUser.password);
-        await loginPage.loginToContentServicesUsingUserModel(acsUser);
-        await contentServicesPage.goToDocumentList();
-        const pdfUploadedFile = await uploadActions.uploadFile(firstPdfFileModel.location, firstPdfFileModel.name, '-my-');
-        Object.assign(firstPdfFileModel, pdfUploadedFile.entry);
-    });
-
-    afterAll(async () => {
-        await navigationBarPage.clickLogoutButton();
-    });
-
-    beforeEach(async () => {
-        await contentServicesPage.goToDocumentList();
-    });
-
-    afterEach(async () => {
-        const nbResults = await contentServicesPage.numberOfResultsDisplayed();
-        if (nbResults > 1) {
-            const nodesPromise = await contentServicesPage.getElementsDisplayedId();
-
-            nodesPromise.forEach(async (currentNodePromise) => {
-                const nodeId = await currentNodePromise;
-                await uploadActions.deleteFileOrFolder(nodeId);
-            });
-        }
-    });
-
-    it('[C260143] Should be possible to maximize/minimize the upload dialog', async () => {
-        await contentServicesPage.uploadFile(docxFileModel.location);
-
-        await contentServicesPage.checkContentIsDisplayed(docxFileModel.name);
-
-        await uploadDialog.fileIsUploaded(docxFileModel.name);
-        await uploadDialog.checkCloseButtonIsDisplayed();
-        await expect(uploadDialog.numberOfCurrentFilesUploaded()).toEqual('1');
-        await expect(uploadDialog.numberOfInitialFilesUploaded()).toEqual('1');
-        await uploadDialog.minimizeUploadDialog();
-        await uploadDialog.dialogIsMinimized();
-        await expect(uploadDialog.numberOfCurrentFilesUploaded()).toEqual('1');
-        await expect(uploadDialog.numberOfInitialFilesUploaded()).toEqual('1');
-        await uploadDialog.maximizeUploadDialog();
-        await uploadDialog.dialogIsDisplayed();
-        await uploadDialog.fileIsUploaded(docxFileModel.name);
-        await expect(uploadDialog.numberOfCurrentFilesUploaded()).toEqual('1');
-        await expect(uploadDialog.numberOfInitialFilesUploaded()).toEqual('1');
-        await uploadDialog.checkCloseButtonIsDisplayed();
-        await uploadDialog.clickOnCloseButton();
-        await uploadDialog.dialogIsNotDisplayed();
-    });
-
-    it('[C291902] Should be shown upload counter display in dialog box', async () => {
-        await contentServicesPage
-            .uploadFile(docxFileModel.location);
-        await contentServicesPage.checkContentIsDisplayed(docxFileModel.name);
-
-        await uploadDialog.fileIsUploaded(docxFileModel.name);
-        await uploadDialog.checkCloseButtonIsDisplayed();
-        await expect(uploadDialog.getTitleText()).toEqual('Uploaded 1 / 1');
-        await uploadDialog.checkCloseButtonIsDisplayed();
-        await uploadDialog.clickOnCloseButton();
-        await uploadDialog.dialogIsNotDisplayed();
-    });
-
-    it('[C260168] Should be possible to cancel upload using dialog icon', async () => {
-        await contentServicesPage.uploadFile(pdfFileModel.location);
-        await contentServicesPage.checkContentIsDisplayed(pdfFileModel.name);
-        await uploadDialog.removeUploadedFile(pdfFileModel.name);
-        await uploadDialog.fileIsCancelled(pdfFileModel.name);
-        await expect(uploadDialog.getTitleText()).toEqual('Upload canceled');
-        await uploadDialog.clickOnCloseButton();
-        await uploadDialog.dialogIsNotDisplayed();
-        await contentServicesPage.checkContentIsNotDisplayed(pdfFileModel.name);
-    });
-
-    it('[C260176] Should remove files from upload dialog box when closed', async () => {
-        await contentServicesPage.uploadFile(pngFileModelTwo.location);
-        await contentServicesPage.checkContentIsDisplayed(pngFileModelTwo.name);
-
-        await uploadDialog.fileIsUploaded(pngFileModelTwo.name);
-        await contentServicesPage.uploadFile(pngFileModel.location);
-        await contentServicesPage.checkContentIsDisplayed(pngFileModel.name);
-        await uploadDialog.fileIsUploaded(pngFileModel.name);
-        await uploadDialog.fileIsUploaded(pngFileModelTwo.name);
-        await uploadDialog.clickOnCloseButton();
-        await uploadDialog.dialogIsNotDisplayed();
-        await contentServicesPage.uploadFile(pdfFileModel.location);
-        await contentServicesPage.checkContentIsDisplayed(pdfFileModel.name);
-        await uploadDialog.fileIsUploaded(pdfFileModel.name);
-        await uploadDialog.fileIsNotDisplayedInDialog(pngFileModel.name);
-        await uploadDialog.fileIsNotDisplayedInDialog(pngFileModelTwo.name);
-        await uploadDialog.clickOnCloseButton();
-        await uploadDialog.dialogIsNotDisplayed();
-    });
-
-    it('[C260170] Should be possible to upload multiple files', async () => {
-        await contentServicesPage.checkAcsContainer();
-        await uploadToggles.enableMultipleFileUpload();
-        await contentServicesPage.uploadMultipleFile(filesLocation);
-        await contentServicesPage.checkContentsAreDisplayed(filesName);
-        await uploadDialog.filesAreUploaded(filesName);
-        await expect(uploadDialog.getTitleText()).toEqual('Uploaded 4 / 4');
-        await uploadDialog.clickOnCloseButton();
-        await uploadDialog.dialogIsNotDisplayed();
-        await uploadToggles.disableMultipleFileUpload();
-    });
-
-    it('[C311305] Should NOT be able to remove uploaded version', async () => {
-        await contentServicesPage.uploadFile(docxFileModel.location);
-        await uploadDialog.fileIsUploaded(docxFileModel.name);
-        await contentServicesPage.checkContentIsDisplayed(docxFileModel.name);
-
-        await contentServicesPage.versionManagerContent(docxFileModel.name);
-        await BrowserActions.click(versionManagePage.showNewVersionButton);
-        await versionManagePage.uploadNewVersionFile(
-            pngFileModel.location
-        );
-        await versionManagePage.closeVersionDialog();
-        await uploadDialog.removeUploadedFile(pngFileModel.name);
-        await contentServicesPage.checkContentIsDisplayed(pngFileModel.name);
-    });
-});

e2e/content-services/upload/uploader-component.e2e.ts

@@ -130,28 +130,6 @@ describe('Upload component', () => {
             await uploadDialog.dialogIsNotDisplayed();
         });
 
-        it('[C260143] Should be possible to maximize/minimize the upload dialog', async () => {
-            await contentServicesPage.uploadFile(docxFileModel.location);
-            await contentServicesPage.checkContentIsDisplayed(docxFileModel.name);
-
-            await uploadDialog.fileIsUploaded(docxFileModel.name);
-            await uploadDialog.checkCloseButtonIsDisplayed();
-            await expect(await uploadDialog.numberOfCurrentFilesUploaded()).toEqual('1');
-            await expect(await uploadDialog.numberOfInitialFilesUploaded()).toEqual('1');
-            await uploadDialog.minimizeUploadDialog();
-            await uploadDialog.dialogIsMinimized();
-            await expect(await uploadDialog.numberOfCurrentFilesUploaded()).toEqual('1');
-            await expect(await uploadDialog.numberOfInitialFilesUploaded()).toEqual('1');
-            await uploadDialog.maximizeUploadDialog();
-            await uploadDialog.dialogIsDisplayed();
-            await uploadDialog.fileIsUploaded(docxFileModel.name);
-            await expect(await uploadDialog.numberOfCurrentFilesUploaded()).toEqual('1');
-            await expect(await uploadDialog.numberOfInitialFilesUploaded()).toEqual('1');
-            await uploadDialog.checkCloseButtonIsDisplayed();
-            await uploadDialog.clickOnCloseButton();
-            await uploadDialog.dialogIsNotDisplayed();
-        });
-
         it('[C272794] Should display tooltip for uploading files', async () => {
             await uploadToggles.enableMultipleFileUpload();
             await uploadToggles.checkMultipleFileUploadToggleIsEnabled();
@@ -317,5 +295,4 @@ describe('Upload component', () => {
         await uploadDialog.displayTooltip();
         await expect(await uploadDialog.getTooltip()).toEqual('Upload location no longer exists [404]');
     });
-
 });

e2e/content-services/upload/user-permission.e2e.ts

@@ -88,8 +88,7 @@ describe('Upload - User permission', () => {
             id: acsUser.id,
             role: CONSTANTS.CS_USER_ROLES.MANAGER
         });
-
-    });
+   });
 
     describe('Consumer permissions', () => {
 
@@ -129,8 +128,7 @@ describe('Upload - User permission', () => {
 
             await notificationHistoryPage.checkNotifyContains('You don\'t have the create permission to upload the content');
         });
-
-    });
+   });
 
     describe('full permissions', () => {
 
@@ -146,8 +144,7 @@ describe('Upload - User permission', () => {
 
             await uploadDialog.fileIsUploaded(emptyFile.name);
         });
-
-    });
+   });
 
     describe('multiple users', () => {
 
@@ -184,5 +181,4 @@ describe('Upload - User permission', () => {
             await contentServicesPage.checkContentIsDisplayed(pdfFile.name);
         });
     });
-
 });