inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ADF-4861] Fix memory leak in Date widgets and Form Cloud Model (#5041)

Browse Source 
* [ADF-4836] Fix memory leak in Date widgets and Form Cloud Model

* Remove unit tests based on old logic
This commit is contained in:
davidcanonieto
2019-10-10 11:01:06 +01:00
committed by Eugenio Romano
parent f731988ca6
commit 2def8d0557
7 changed files with 2 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/core/form/components/widgets/core/form-field.model.ts
View File

@@ -83,8 +83,8 @@ export class FormFieldModel extends FormWidgetModel {
return this._value;
}
set value(v: any) {
this._value = v;
set value(value: any) {
this._value = value;
this.updateForm();
}

17
lib/core/form/components/widgets/date-time/date-time.widget.spec.ts
View File

@@ -87,23 +87,6 @@ describe('DateTimeWidgetComponent', () => {
expect(widget.maxDate.isSame(expected)).toBeTruthy();
});
it('should eval visibility on date changed', () => {
spyOn(widget, 'onFieldChanged').and.callThrough();
const field = new FormFieldModel(new FormModel(), {
id: 'date-field-id',
name: 'date-name',
value: '09-12-9999 10:00 AM',
type: 'datetime',
readOnly: 'false'
});
widget.field = field;
widget.onDateChanged({ value: moment('1982-03-13T10:00:000Z') });
expect(widget.onFieldChanged).toHaveBeenCalledWith(field);
});
describe('template check', () => {
it('should show visible date widget', async(() => {

1
lib/core/form/components/widgets/date-time/date-time.widget.ts
View File

@@ -94,7 +94,6 @@ export class DateTimeWidgetComponent extends WidgetComponent implements OnInit,
} else {
this.field.value = null;
}
this.onFieldChanged(this.field);
}
}

17
lib/core/form/components/widgets/date/date.widget.spec.ts
View File

@@ -81,23 +81,6 @@ describe('DateWidgetComponent', () => {
expect(widget.maxDate.isSame(expected)).toBeTruthy();
});
it('should eval visibility on date changed', () => {
spyOn(widget, 'onFieldChanged').and.callThrough();
const field = new FormFieldModel(new FormModel(), {
id: 'date-field-id',
name: 'date-name',
value: '9-9-9999',
type: 'date',
readOnly: 'false'
});
widget.field = field;
widget.onDateChanged({ value: moment('12/12/2012') });
expect(widget.onFieldChanged).toHaveBeenCalledWith(field);
});
describe('template check', () => {
afterEach(() => {

1
lib/core/form/components/widgets/date/date.widget.ts
View File

@@ -89,6 +89,5 @@ export class DateWidgetComponent extends WidgetComponent implements OnInit, OnDe
} else {
this.field.value = null;
}
this.onFieldChanged(this.field);
}
}

17
lib/process-services-cloud/src/lib/form/components/date-cloud/date-cloud.widget.spec.ts
View File

@@ -80,23 +80,6 @@ describe('DateWidgetComponent', () => {
expect(widget.maxDate.isSame(expected)).toBeTruthy();
});
it('should eval visibility on date changed', () => {
spyOn(widget, 'onFieldChanged').and.callThrough();
const field = new FormFieldModel(new FormModel(), {
id: 'date-field-id',
name: 'date-name',
value: '9999-9-9',
type: 'date',
readOnly: 'false'
});
widget.field = field;
widget.onDateChanged({ value: moment('12/12/2012') });
expect(widget.onFieldChanged).toHaveBeenCalledWith(field);
});
describe('template check', () => {
afterEach(() => {

1
lib/process-services-cloud/src/lib/form/components/date-cloud/date-cloud.widget.ts
View File

@@ -86,6 +86,5 @@ export class DateCloudWidgetComponent extends WidgetComponent implements OnInit,
} else {
this.field.value = null;
}
this.onFieldChanged(this.field);
}
}