From 2ed632f9fcfe414f75239ae12287d4c6281b6ef4 Mon Sep 17 00:00:00 2001
From: arditdomi <32884230+arditdomi@users.noreply.github.com>
Date: Fri, 12 Mar 2021 09:03:42 +0000
Subject: [PATCH] [ADF-5355] - Fix attach button visibility when using external
 source (#6784)

---
 .../attach-file-widget-dialog.component.html  |  2 +-
 ...ttach-file-widget-dialog.component.spec.ts | 38 +++++++++++++++++++
 .../attach-file-widget-dialog.component.ts    |  4 ++
 3 files changed, 43 insertions(+), 1 deletion(-)

diff --git a/lib/process-services/src/lib/content-widget/attach-file-widget-dialog.component.html b/lib/process-services/src/lib/content-widget/attach-file-widget-dialog.component.html
index 2a3981b53e..c83361546b 100644
--- a/lib/process-services/src/lib/content-widget/attach-file-widget-dialog.component.html
+++ b/lib/process-services/src/lib/content-widget/attach-file-widget-dialog.component.html
@@ -33,7 +33,7 @@
 
     <button *ngIf="isLoggedIn()"
         mat-button
-        [disabled]="!chosenNode"
+        [disabled]="!hasNodeSelected()"
         class="adf-choose-action"
         (click)="onClick()"
         data-automation-id="attach-file-dialog-actions-choose">{{ buttonActionName | translate }}
diff --git a/lib/process-services/src/lib/content-widget/attach-file-widget-dialog.component.spec.ts b/lib/process-services/src/lib/content-widget/attach-file-widget-dialog.component.spec.ts
index 879fa3bc03..5e303236cd 100644
--- a/lib/process-services/src/lib/content-widget/attach-file-widget-dialog.component.spec.ts
+++ b/lib/process-services/src/lib/content-widget/attach-file-widget-dialog.component.spec.ts
@@ -209,4 +209,42 @@ describe('AttachFileWidgetDialogComponent', () => {
             expect(matDialogRef.close).toHaveBeenCalled();
         });
     });
+
+    describe('Attach button', () => {
+
+        beforeEach(async(() => {
+           isLogged = true;
+        }));
+
+        it('should be disabled by default', () => {
+            fixture.detectChanges();
+            const actionButton = fixture.debugElement.query(By.css('[data-automation-id="attach-file-dialog-actions-choose"]'));
+
+            expect(actionButton.nativeElement.disabled).toBeTruthy();
+        });
+
+        it('should be enabled when a node is chosen', () => {
+            widget.onSelect([new Node({ id: 'fake' })]);
+            fixture.detectChanges();
+            const actionButton = fixture.debugElement.query(By.css('[data-automation-id="attach-file-dialog-actions-choose"]'));
+
+            expect(actionButton.nativeElement.disabled).toBeFalsy();
+        });
+
+        it('should be disabled when no node chosen', () => {
+            widget.onSelect([new Node({ id: 'fake' })]);
+            fixture.detectChanges();
+
+            const actionButtonWithNodeSelected = fixture.debugElement.query(By.css('[data-automation-id="attach-file-dialog-actions-choose"]'));
+
+            expect(actionButtonWithNodeSelected.nativeElement.disabled).toBe(false);
+
+            widget.onSelect([]);
+            fixture.detectChanges();
+
+            const actionButtonWithoutNodeSelected = fixture.debugElement.query(By.css('[data-automation-id="attach-file-dialog-actions-choose"]'));
+
+            expect(actionButtonWithoutNodeSelected.nativeElement.disabled).toBe(true);
+        });
+    });
 });
diff --git a/lib/process-services/src/lib/content-widget/attach-file-widget-dialog.component.ts b/lib/process-services/src/lib/content-widget/attach-file-widget-dialog.component.ts
index c58b1bc9aa..9cef5a4e2c 100644
--- a/lib/process-services/src/lib/content-widget/attach-file-widget-dialog.component.ts
+++ b/lib/process-services/src/lib/content-widget/attach-file-widget-dialog.component.ts
@@ -105,4 +105,8 @@ export class AttachFileWidgetDialogComponent {
     getTitleTranslation(action: string, name?: string): string {
         return this.translation.instant(`ATTACH-FILE.ACTIONS.${action}_ITEM`, { name: this.translation.instant(name) });
     }
+
+    hasNodeSelected(): boolean {
+        return this.chosenNode?.length > 0;
+    }
 }