inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ACS-5314] Data table row should be clickable anywhere (#8671)

Browse Source 
* [ACS-5314] bug fix

* [ACS-5314] empty commit

* rebase

* [ACS-5314] rebase

* [ACS-5314] fixed multiselect on checkbox

* [ACS-5314] fixed checkbox selector for e2e
This commit is contained in:
Mykyta Maliarchuk
2023-07-04 11:10:31 +02:00
committed by GitHub
parent a933070fc3
commit 2f3f5ae02b
3 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/core/src/lib/datatable/components/datatable/datatable.component.html
View File

@@ -192,7 +192,7 @@
</mat-menu> </mat-menu>
</div> </div>
<div *ngIf="multiselect" class="adf-datatable-cell adf-datatable-checkbox"> <label *ngIf="multiselect" class="adf-datatable-cell adf-datatable-checkbox">
<mat-checkbox <mat-checkbox
[checked]="row.isSelected" [checked]="row.isSelected"
[attr.aria-checked]="row.isSelected" [attr.aria-checked]="row.isSelected"
@@ -201,7 +201,7 @@
class="adf-checkbox-sr-only"> class="adf-checkbox-sr-only">
{{ 'ADF-DATATABLE.ACCESSIBILITY.SELECT_FILE' | translate }} {{ 'ADF-DATATABLE.ACCESSIBILITY.SELECT_FILE' | translate }}
</mat-checkbox> </mat-checkbox>
</div> </label>
<div *ngFor="let col of (data.getColumns() | filterOutEvery:'isHidden':true);" <div *ngFor="let col of (data.getColumns() | filterOutEvery:'isHidden':true);"
role="gridcell" role="gridcell"
class="adf-datatable-cell adf-datatable-cell--{{col.type || 'text'}} {{col.cssClass}}" class="adf-datatable-cell adf-datatable-cell--{{col.type || 'text'}} {{col.cssClass}}"

12
lib/core/src/lib/datatable/components/datatable/datatable.component.scss
View File

@@ -296,8 +296,6 @@ $data-table-cell-min-width-file-size: $data-table-cell-min-width !default;
.adf-datatable-row { .adf-datatable-row {
display: flex; display: flex;
align-items: center; align-items: center;
padding-left: 15px;
padding-right: 15px;
.adf-datatable-checkbox { .adf-datatable-checkbox {
max-width: $data-table-thumbnail-width; max-width: $data-table-thumbnail-width;
@@ -385,6 +383,16 @@ $data-table-cell-min-width-file-size: $data-table-cell-min-width !default;
display: flex; display: flex;
min-height: inherit; min-height: inherit;
&:first-child {
padding-left: 15px;
box-sizing: content-box;
}
&:last-child {
padding-right: 15px;
box-sizing: content-box;
}
.adf-datatable-cell-container { .adf-datatable-cell-container {
overflow: hidden; overflow: hidden;
min-height: inherit; min-height: inherit;

2
lib/testing/src/lib/protractor/core/pages/data-table-component.page.ts
View File

@@ -494,7 +494,7 @@ export class DataTableComponentPage {
} }
async clickRowByContentCheckbox(name: string): Promise<void> { async clickRowByContentCheckbox(name: string): Promise<void> {
const resultElement = this.rootElement.$$(`div[data-automation-id='${name}']`).first().element(by.xpath(`ancestor::adf-datatable-row/div/mat-checkbox`)); const resultElement = this.rootElement.$$(`div[data-automation-id='${name}']`).first().element(by.xpath(`ancestor::adf-datatable-row/label/mat-checkbox`));
await browser.actions().mouseMove(resultElement); await browser.actions().mouseMove(resultElement);
await BrowserActions.click(resultElement); await BrowserActions.click(resultElement);
} }