From 3263659ac256032281dde5b4ee1c4852b1d0f4f8 Mon Sep 17 00:00:00 2001 From: Eugenio Romano Date: Mon, 11 Feb 2019 10:44:37 +0000 Subject: [PATCH] rename old hasPermission as allowableOperation and introduce the real hasPermissions (#4294) --- .../file-view/file-view.component.ts | 2 +- .../app/components/files/files.component.html | 10 +-- .../app/components/files/files.component.ts | 14 ++-- .../content-services/document-list.service.md | 2 +- .../permissions-style.model.md | 6 +- docs/core/content.service.md | 4 +- docs/core/node-permission.directive.md | 6 +- .../content-metadata-card.component.html | 2 +- .../content-metadata-card.component.spec.ts | 6 +- .../content-metadata-card.component.ts | 6 +- .../content-node-dialog.service.ts | 16 ++-- ...tent-node-selector-panel.component.spec.ts | 20 ++--- .../content-node-share.dialog.ts | 2 +- .../directives/node-lock.directive.ts | 6 +- .../components/document-list.component.ts | 2 +- .../data/share-data-row.model.ts | 4 +- .../models/permissions-style.model.ts | 6 +- .../services/document-actions.service.ts | 2 +- .../services/folder-actions.service.ts | 2 +- .../add-permission.component.ts | 6 +- .../components/inherited-button.directive.ts | 4 +- .../node-permission-dialog.service.ts | 4 +- .../components/upload-button.component.ts | 18 ++--- .../components/upload-drag-area.component.ts | 8 +- .../upload-version-button.component.ts | 4 +- .../version-manager/version-list.component.ts | 4 +- .../version-manager.component.ts | 2 +- .../version-upload.component.ts | 2 +- ...eck-allowable-operation.directive.spec.ts} | 34 ++++----- ...=> check-allowable-operation.directive.ts} | 24 +++--- lib/core/directives/directive.module.ts | 6 +- .../directives/node-delete.directive.spec.ts | 4 +- lib/core/directives/node-delete.directive.ts | 2 +- lib/core/directives/public-api.ts | 2 +- lib/core/models/allowable-operations.enum.ts | 30 ++++++++ lib/core/models/permissions.enum.ts | 18 ++--- lib/core/models/public-api.ts | 1 + lib/core/services/content.service.spec.ts | 76 +++++++++++++------ lib/core/services/content.service.ts | 67 ++++++++++------ 39 files changed, 256 insertions(+), 178 deletions(-) rename lib/core/directives/{node-permission.directive.spec.ts => check-allowable-operation.directive.spec.ts} (74%) rename lib/core/directives/{node-permission.directive.ts => check-allowable-operation.directive.ts} (82%) create mode 100644 lib/core/models/allowable-operations.enum.ts diff --git a/demo-shell/src/app/components/file-view/file-view.component.ts b/demo-shell/src/app/components/file-view/file-view.component.ts index a63e539d97..78cf6329e9 100644 --- a/demo-shell/src/app/components/file-view/file-view.component.ts +++ b/demo-shell/src/app/components/file-view/file-view.component.ts @@ -68,7 +68,7 @@ export class FileViewComponent implements OnInit { this.nodeApiService.getNode(id).subscribe( (node) => { if (node && node.isFile) { - this.isCommentEnabled = !this.contentServices.hasPermission(node, PermissionsEnum.UPDATE); + this.isCommentEnabled = !this.contentServices.hasPermissions(node, PermissionsEnum.NOT_CONSUMER); this.nodeId = id; return; } diff --git a/demo-shell/src/app/components/files/files.component.html b/demo-shell/src/app/components/files/files.component.html index 55207ffac8..4b47c3e023 100644 --- a/demo-shell/src/app/components/files/files.component.html +++ b/demo-shell/src/app/components/files/files.component.html @@ -37,7 +37,7 @@ [acceptedFilesType]="getFileFiltering()" [rootFolderId]="currentFolderId" [versioning]="versioning" - [adf-node-permission]="'create'" + [adf-check-allowable-operation]="'create'" [adf-nodes]="disableDragArea ? getCurrentDocumentListNode() : []" (beginUpload)="onBeginUpload($event)">
@@ -105,7 +105,7 @@ get_app @@ -65,7 +65,7 @@ node in the selection: ```html @@ -89,7 +89,7 @@ for example). You can also use it in much the same way as you would with an HTML ... diff --git a/lib/content-services/content-metadata/components/content-metadata-card/content-metadata-card.component.html b/lib/content-services/content-metadata/components/content-metadata-card/content-metadata-card.component.html index 526ab924c3..07068fd23f 100644 --- a/lib/content-services/content-metadata/components/content-metadata-card/content-metadata-card.component.html +++ b/lib/content-services/content-metadata/components/content-metadata-card/content-metadata-card.component.html @@ -12,7 +12,7 @@