tslint arrow-parens rule (#4003)

This commit is contained in:
Eugenio Romano
2018-11-23 01:06:56 +00:00
committed by GitHub
parent 51bb6a420f
commit 34a30c0f14
194 changed files with 725 additions and 723 deletions

View File

@@ -200,7 +200,7 @@ describe('ContentAction', () => {
it('should use custom "execute" emitter', (done) => {
let emitter = new EventEmitter();
emitter.subscribe(e => {
emitter.subscribe((e) => {
expect(e.value).toBe('<obj>');
done();
});

View File

@@ -129,7 +129,7 @@ export class ContentActionComponent implements OnInit, OnChanges, OnDestroy {
}
ngOnDestroy() {
this.subscriptions.forEach(subscription => subscription.unsubscribe());
this.subscriptions.forEach((subscription) => subscription.unsubscribe());
this.subscriptions = [];
if (this.documentActionModel) {
@@ -188,13 +188,13 @@ export class ContentActionComponent implements OnInit, OnChanges, OnDestroy {
if (target === ContentActionTarget.Document) {
if (this.documentActions) {
this.subscriptions.push(
this.documentActions.permissionEvent.subscribe(permission => {
this.documentActions.permissionEvent.subscribe((permission) => {
this.permissionEvent.emit(permission);
}),
this.documentActions.error.subscribe(errors => {
this.documentActions.error.subscribe((errors) => {
this.error.emit(errors);
}),
this.documentActions.success.subscribe(message => {
this.documentActions.success.subscribe((message) => {
this.success.emit(message);
})
);
@@ -207,13 +207,13 @@ export class ContentActionComponent implements OnInit, OnChanges, OnDestroy {
if (target === ContentActionTarget.Folder) {
if (this.folderActions) {
this.subscriptions.push(
this.folderActions.permissionEvent.subscribe(permission => {
this.folderActions.permissionEvent.subscribe((permission) => {
this.permissionEvent.emit(permission);
}),
this.folderActions.error.subscribe(errors => {
this.folderActions.error.subscribe((errors) => {
this.error.emit(errors);
}),
this.folderActions.success.subscribe(message => {
this.folderActions.success.subscribe((message) => {
this.success.emit(message);
})
);

View File

@@ -560,7 +560,7 @@ describe('DocumentList', () => {
it('should emit nodeClick event', (done) => {
let node = new FileNode();
let disposableClick = documentList.nodeClick.subscribe(e => {
let disposableClick = documentList.nodeClick.subscribe((e) => {
expect(e.value).toBe(node);
disposableClick.unsubscribe();
done();
@@ -650,7 +650,7 @@ describe('DocumentList', () => {
it('should emit file preview event on single click', (done) => {
let file = new FileNode();
let disposablePreview = documentList.preview.subscribe(e => {
let disposablePreview = documentList.preview.subscribe((e) => {
expect(e.value).toBe(file);
disposablePreview.unsubscribe();
done();
@@ -661,7 +661,7 @@ describe('DocumentList', () => {
it('should emit file preview event on double click', (done) => {
let file = new FileNode();
let disposablePreview = documentList.preview.subscribe(e => {
let disposablePreview = documentList.preview.subscribe((e) => {
expect(e.value).toBe(file);
disposablePreview.unsubscribe();
done();
@@ -738,7 +738,7 @@ describe('DocumentList', () => {
let called = false;
documentList.navigationMode = DocumentListComponent.SINGLE_CLICK_NAVIGATION;
documentList.preview.subscribe(val => called = true);
documentList.preview.subscribe((val) => called = true);
documentList.onNodeClick(file);
expect(called).toBeFalsy();
@@ -966,7 +966,7 @@ describe('DocumentList', () => {
const error = { message: '{ "error": { "statusCode": 501 } }' };
spyOn(documentListService, 'getFolderNode').and.returnValue(throwError(error));
let disposableError = documentList.error.subscribe(val => {
let disposableError = documentList.error.subscribe((val) => {
expect(val).toBe(error);
disposableError.unsubscribe();
done();
@@ -980,7 +980,7 @@ describe('DocumentList', () => {
spyOn(documentListService, 'getFolderNode').and.returnValue(of(fakeNodeWithCreatePermission));
spyOn(documentList, 'loadFolderNodesByFolderNodeId').and.returnValue(Promise.reject(error));
let disposableError = documentList.error.subscribe(val => {
let disposableError = documentList.error.subscribe((val) => {
expect(val).toBe(error);
disposableError.unsubscribe();
done();
@@ -1003,7 +1003,7 @@ describe('DocumentList', () => {
const error = { message: '{ "error": { "statusCode": 403 } }' };
spyOn(documentListService, 'getFolderNode').and.returnValue(throwError(error));
let disposableError = documentList.error.subscribe(val => {
let disposableError = documentList.error.subscribe((val) => {
expect(val).toBe(error);
expect(documentList.noPermission).toBe(true);
disposableError.unsubscribe();
@@ -1060,7 +1060,7 @@ describe('DocumentList', () => {
documentList.currentFolderId = 'node-id';
expect(documentList.canNavigateFolder(node)).toBeTruthy();
sources.forEach(source => {
sources.forEach((source) => {
documentList.currentFolderId = source;
expect(documentList.canNavigateFolder(node)).toBeFalsy();
});
@@ -1076,7 +1076,7 @@ describe('DocumentList', () => {
it('should emit error when fetch trashcan fails', (done) => {
spyOn(apiService.nodesApi, 'getDeletedNodes').and.returnValue(Promise.reject('error'));
let disposableError = documentList.error.subscribe(val => {
let disposableError = documentList.error.subscribe((val) => {
expect(val).toBe('error');
disposableError.unsubscribe();
done();
@@ -1097,7 +1097,7 @@ describe('DocumentList', () => {
spyOn(apiService.getInstance().core.sharedlinksApi, 'findSharedLinks')
.and.returnValue(Promise.reject('error'));
let disposableError = documentList.error.subscribe(val => {
let disposableError = documentList.error.subscribe((val) => {
expect(val).toBe('error');
disposableError.unsubscribe();
done();
@@ -1116,7 +1116,7 @@ describe('DocumentList', () => {
it('should emit error when fetch sites fails', (done) => {
spyGetSites.and.returnValue(Promise.reject('error'));
let disposableError = documentList.error.subscribe(val => {
let disposableError = documentList.error.subscribe((val) => {
expect(val).toBe('error');
disposableError.unsubscribe();
done();
@@ -1129,7 +1129,7 @@ describe('DocumentList', () => {
fixture.detectChanges();
let disposableReady = documentList.ready.subscribe((page) => {
const entriesWithoutName = page.list.entries.filter(item => !item.entry.name);
const entriesWithoutName = page.list.entries.filter((item) => !item.entry.name);
expect(entriesWithoutName.length).toBe(0);
disposableReady.unsubscribe();
done();
@@ -1142,7 +1142,7 @@ describe('DocumentList', () => {
fixture.detectChanges();
let disposableReady = documentList.ready.subscribe((page) => {
const wrongName = page.list.entries.filter(item => (item.entry.name !== item.entry.title));
const wrongName = page.list.entries.filter((item) => (item.entry.name !== item.entry.title));
expect(wrongName.length).toBe(0);
disposableReady.unsubscribe();
done();
@@ -1163,7 +1163,7 @@ describe('DocumentList', () => {
spyOn(apiService.getInstance().core.peopleApi, 'getSiteMembership')
.and.returnValue(Promise.reject('error'));
let disposableError = documentList.error.subscribe(val => {
let disposableError = documentList.error.subscribe((val) => {
expect(val).toBe('error');
disposableError.unsubscribe();
done();
@@ -1181,7 +1181,7 @@ describe('DocumentList', () => {
expect(peopleApi.getSiteMembership).toHaveBeenCalled();
let disposableReady = documentList.ready.subscribe((page) => {
const entriesWithoutName = page.list.entries.filter(item => !item.entry.name);
const entriesWithoutName = page.list.entries.filter((item) => !item.entry.name);
expect(entriesWithoutName.length).toBe(0);
disposableReady.unsubscribe();
done();
@@ -1197,7 +1197,7 @@ describe('DocumentList', () => {
expect(peopleApi.getSiteMembership).toHaveBeenCalled();
let disposableReady = documentList.ready.subscribe((page) => {
const wrongName = page.list.entries.filter(item => (item.entry.name !== item.entry.title));
const wrongName = page.list.entries.filter((item) => (item.entry.name !== item.entry.title));
expect(wrongName.length).toBe(0);
disposableReady.unsubscribe();
done();
@@ -1215,7 +1215,7 @@ describe('DocumentList', () => {
it('should emit error when fetch favorites fails', (done) => {
spyFavorite.and.returnValue(Promise.reject('error'));
let disposableError = documentList.error.subscribe(val => {
let disposableError = documentList.error.subscribe((val) => {
expect(val).toBe('error');
disposableError.unsubscribe();
done();
@@ -1237,7 +1237,7 @@ describe('DocumentList', () => {
it('should emit error when fetch recent fails on getPerson call', (done) => {
spyOn(apiService.peopleApi, 'getPerson').and.returnValue(Promise.reject('error'));
let disposableError = documentList.error.subscribe(val => {
let disposableError = documentList.error.subscribe((val) => {
expect(val).toBe('error');
disposableError.unsubscribe();
done();
@@ -1249,7 +1249,7 @@ describe('DocumentList', () => {
xit('should emit error when fetch recent fails on search call', (done) => {
spyOn(customResourcesService, 'loadFolderByNodeId').and.returnValue(throwError('error'));
let disposableError = documentList.error.subscribe(val => {
let disposableError = documentList.error.subscribe((val) => {
expect(val).toBe('error');
disposableError.unsubscribe();
done();

View File

@@ -286,7 +286,7 @@ export class DocumentListComponent implements OnInit, OnChanges, OnDestroy, Afte
}
private getLayoutPreset(name: string = 'default'): DataColumn[] {
return (this.layoutPresets[name] || this.layoutPresets['default']).map(col => new ObjectDataColumn(col));
return (this.layoutPresets[name] || this.layoutPresets['default']).map((col) => new ObjectDataColumn(col));
}
get pagination(): BehaviorSubject<PaginationModel> {
@@ -352,7 +352,7 @@ export class DocumentListComponent implements OnInit, OnChanges, OnDestroy, Afte
}
this.subscriptions.push(
this.contextActionHandler.subscribe(val => this.contextActionCallback(val))
this.contextActionHandler.subscribe((val) => this.contextActionCallback(val))
);
this.enforceSingleClickNavigationForMobile();
@@ -373,7 +373,7 @@ export class DocumentListComponent implements OnInit, OnChanges, OnDestroy, Afte
let schema: DataColumn[] = [];
if (this.hasCustomLayout) {
schema = this.columnList.columns.map(c => <DataColumn> c);
schema = this.columnList.columns.map((c) => <DataColumn> c);
}
if (!this.data) {
@@ -422,7 +422,7 @@ export class DocumentListComponent implements OnInit, OnChanges, OnDestroy, Afte
} else if (changes.rowFilter && changes.rowFilter.currentValue !== changes.rowFilter.previousValue) {
this.data.setFilter(changes.rowFilter.currentValue);
if (this.currentFolderId) {
this.loadFolderNodesByFolderNodeId(this.currentFolderId, this.pagination.getValue()).catch(err => this.error.emit(err));
this.loadFolderNodesByFolderNodeId(this.currentFolderId, this.pagination.getValue()).catch((err) => this.error.emit(err));
}
} else if (changes.imageResolver) {
this.data.setImageResolver(changes.imageResolver.currentValue);
@@ -461,21 +461,21 @@ export class DocumentListComponent implements OnInit, OnChanges, OnDestroy, Afte
if (target) {
const actions = this.rowMenuCache[node.entry.id];
if (actions) {
actions.forEach(action => {
actions.forEach((action) => {
this.refreshAction(action, node);
});
return actions;
}
let actionsByTarget = this.actions
.filter(entry => {
.filter((entry) => {
const isVisible = (typeof entry.visible === 'function')
? entry.visible(node)
: entry.visible;
return isVisible && entry.target.toLowerCase() === target;
})
.map(action => new ContentActionModel(action));
.map((action) => new ContentActionModel(action));
actionsByTarget.forEach((action) => {
this.refreshAction(action, node);
@@ -604,7 +604,7 @@ export class DocumentListComponent implements OnInit, OnChanges, OnDestroy, Afte
if (this.folderNode) {
return this.loadFolderNodesByFolderNodeId(this.folderNode.id, this.pagination.getValue())
.catch(err => this.handleError(err));
.catch((err) => this.handleError(err));
} else {
this.loadFolderByNodeId(this.currentFolderId);
}
@@ -616,7 +616,7 @@ export class DocumentListComponent implements OnInit, OnChanges, OnDestroy, Afte
this.customResourcesService.loadFolderByNodeId(nodeId, this.pagination.getValue(), this.includeFields)
.subscribe((page: NodePaging) => {
this.onPageLoaded(page);
}, err => {
}, (err) => {
this.error.emit(err);
});
} else {
@@ -625,8 +625,8 @@ export class DocumentListComponent implements OnInit, OnChanges, OnDestroy, Afte
.subscribe((node: MinimalNodeEntryEntity) => {
this.folderNode = node;
return this.loadFolderNodesByFolderNodeId(node.id, this.pagination.getValue())
.catch(err => this.handleError(err));
}, err => {
.catch((err) => this.handleError(err));
}, (err) => {
this.handleError(err);
});
}
@@ -642,12 +642,12 @@ export class DocumentListComponent implements OnInit, OnChanges, OnDestroy, Afte
rootFolderId: id
}, this.includeFields)
.subscribe(
nodePaging => {
(nodePaging) => {
this.data.loadPage(<NodePaging> nodePaging, this.pagination.getValue().merge);
this.setLoadingState(false);
this.onDataReady(nodePaging);
resolve(true);
}, err => {
}, (err) => {
this.handleError(err);
});
});
@@ -740,7 +740,7 @@ export class DocumentListComponent implements OnInit, OnChanges, OnDestroy, Afte
}
onNodeSelect(event: { row: ShareDataRow, selection: Array<ShareDataRow> }) {
this.selection = event.selection.map(entry => entry.node);
this.selection = event.selection.map((entry) => entry.node);
const domEvent = new CustomEvent('node-select', {
detail: {
node: event.row.node,
@@ -752,7 +752,7 @@ export class DocumentListComponent implements OnInit, OnChanges, OnDestroy, Afte
}
onNodeUnselect(event: { row: ShareDataRow, selection: Array<ShareDataRow> }) {
this.selection = event.selection.map(entry => entry.node);
this.selection = event.selection.map((entry) => entry.node);
const domEvent = new CustomEvent('node-unselect', {
detail: {
node: event.row.node,
@@ -844,7 +844,7 @@ export class DocumentListComponent implements OnInit, OnChanges, OnDestroy, Afte
}
ngOnDestroy() {
this.subscriptions.forEach(s => s.unsubscribe());
this.subscriptions.forEach((s) => s.unsubscribe());
this.subscriptions = [];
}

View File

@@ -241,7 +241,7 @@ export class ShareDataTableAdapter implements DataTableAdapter {
if (page && page.list) {
let data = page.list.entries;
if (data && data.length > 0) {
rows = data.map(item => new ShareDataRow(item, this.documentListService, this.permissionsStyle, this.thumbnailService));
rows = data.map((item) => new ShareDataRow(item, this.documentListService, this.permissionsStyle, this.thumbnailService));
if (this.filter) {
rows = rows.filter(this.filter);
@@ -254,7 +254,7 @@ export class ShareDataTableAdapter implements DataTableAdapter {
if (sorting) {
this.sortRows(rows, sorting);
} else {
let sortable = this.columns.filter(c => c.sortable);
let sortable = this.columns.filter((c) => c.sortable);
if (sortable.length > 0) {
this.sort(sortable[0].key, 'asc');
} else {

View File

@@ -50,7 +50,7 @@ export class CustomResourcesService {
* @returns List of nodes for the recently used files
*/
getRecentFiles(personId: string, pagination: PaginationModel): Observable<NodePaging> {
return new Observable(observer => {
return new Observable((observer) => {
this.apiService.peopleApi.getPerson(personId)
.then((person: PersonEntry) => {
const username = person.entry.id;
@@ -89,7 +89,7 @@ export class CustomResourcesService {
observer.error(err);
observer.complete();
});
}).pipe(catchError(err => this.handleError(err)));
}).pipe(catchError((err) => this.handleError(err)));
}
/**
@@ -108,7 +108,7 @@ export class CustomResourcesService {
include: includeFieldsRequest
};
return new Observable(observer => {
return new Observable((observer) => {
this.apiService.favoritesApi.getFavorites('-me-', options)
.then((result: NodePaging) => {
let page: NodePaging = {
@@ -135,7 +135,7 @@ export class CustomResourcesService {
observer.error(err);
observer.complete();
});
}).pipe(catchError(err => this.handleError(err)));
}).pipe(catchError((err) => this.handleError(err)));
}
/**
@@ -150,7 +150,7 @@ export class CustomResourcesService {
skipCount: pagination.skipCount
};
return new Observable(observer => {
return new Observable((observer) => {
this.apiService.peopleApi.getSiteMembership('-me-', options)
.then((result: SitePaging) => {
let page: NodePaging = {
@@ -174,7 +174,7 @@ export class CustomResourcesService {
observer.error(err);
observer.complete();
});
}).pipe(catchError(err => this.handleError(err)));
}).pipe(catchError((err) => this.handleError(err)));
}
/**
@@ -189,7 +189,7 @@ export class CustomResourcesService {
skipCount: pagination.skipCount
};
return new Observable(observer => {
return new Observable((observer) => {
this.apiService.sitesApi.getSites(options)
.then((page: NodePaging) => {
page.list.entries.map(
@@ -205,7 +205,7 @@ export class CustomResourcesService {
observer.error(err);
observer.complete();
});
}).pipe(catchError(err => this.handleError(err)));
}).pipe(catchError((err) => this.handleError(err)));
}
/**
@@ -224,7 +224,7 @@ export class CustomResourcesService {
};
return from(this.apiService.nodesApi.getDeletedNodes(options))
.pipe(catchError(err => this.handleError(err)));
.pipe(catchError((err) => this.handleError(err)));
}
@@ -244,7 +244,7 @@ export class CustomResourcesService {
};
return from(this.apiService.sharedLinksApi.findSharedLinks(options))
.pipe(catchError(err => this.handleError(err)));
.pipe(catchError((err) => this.handleError(err)));
}
/**
@@ -314,7 +314,7 @@ export class CustomResourcesService {
if (this.isCustomSource(nodeId)) {
return this.loadFolderByNodeId(nodeId, pagination, [])
.pipe(map(result => result.list.entries.map((node: any) => {
.pipe(map((result) => result.list.entries.map((node: any) => {
if (nodeId === '-sharedlinks-') {
return node.entry.nodeId;
@@ -331,7 +331,7 @@ export class CustomResourcesService {
} else if (nodeId) {
// cases when nodeId is '-my-', '-root-' or '-shared-'
return from(this.apiService.nodesApi.getNode(nodeId)
.then(node => [node.entry.id]));
.then((node) => [node.entry.id]));
}
return of([]);

View File

@@ -107,7 +107,7 @@ describe('DocumentListService', () => {
it('should create a folder in the path', () => {
service.createFolder('fake-name', 'fake-path').subscribe(
res => {
(res) => {
expect(res).toBeDefined();
expect(res.entry).toBeDefined();
expect(res.entry.isFolder).toBeTruthy();
@@ -125,10 +125,10 @@ describe('DocumentListService', () => {
it('should emit an error when the folder already exist', () => {
service.createFolder('fake-name', 'fake-path').subscribe(
res => {
(res) => {
},
err => {
(err) => {
expect(err).toBeDefined();
expect(err.status).toEqual(409);
expect(err.response).toBeDefined();
@@ -144,7 +144,7 @@ describe('DocumentListService', () => {
it('should return the folder info', () => {
service.getFolder('/fake-root/fake-name').subscribe(
res => {
(res) => {
expect(res).toBeDefined();
expect(res.list).toBeDefined();
expect(res.list.entries).toBeDefined();
@@ -210,7 +210,7 @@ describe('DocumentListService', () => {
it('should delete the folder', () => {
service.deleteNode('fake-id').subscribe(
res => {
(res) => {
expect(res).toBeNull();
}
);

View File

@@ -88,7 +88,7 @@ export class DocumentListService {
*/
copyNode(nodeId: string, targetParentId: string) {
return from(this.apiService.getInstance().nodes.copyNode(nodeId, { targetParentId })).pipe(
catchError(err => this.handleError(err))
catchError((err) => this.handleError(err))
);
}
@@ -101,7 +101,7 @@ export class DocumentListService {
*/
moveNode(nodeId: string, targetParentId: string) {
return from(this.apiService.getInstance().nodes.moveNode(nodeId, { targetParentId })).pipe(
catchError(err => this.handleError(err))
catchError((err) => this.handleError(err))
);
}
@@ -114,7 +114,7 @@ export class DocumentListService {
createFolder(name: string, parentId: string): Observable<MinimalNodeEntity> {
return from(this.apiService.getInstance().nodes.createFolder(name, '/', parentId))
.pipe(
catchError(err => this.handleError(err))
catchError((err) => this.handleError(err))
);
}
@@ -128,7 +128,7 @@ export class DocumentListService {
getFolder(folder: string, opts?: any, includeFields: string[] = []): Observable<NodePaging> {
return from(this.getNodesPromise(folder, opts, includeFields))
.pipe(
catchError(err => this.handleError(err))
catchError((err) => this.handleError(err))
);
}

View File

@@ -107,7 +107,7 @@ describe('FolderActionsService', () => {
it('should delete the folder node if there is the delete permission', () => {
spyOn(documentListService, 'deleteNode').and.callFake(() => {
return new Observable<any>(observer => {
return new Observable<any>((observer) => {
observer.next();
observer.complete();
});
@@ -125,7 +125,7 @@ describe('FolderActionsService', () => {
it('should not delete the folder node if there is no delete permission', (done) => {
spyOn(documentListService, 'deleteNode').and.callFake(() => {
return new Observable<any>(observer => {
return new Observable<any>((observer) => {
observer.next();
observer.complete();
});
@@ -146,7 +146,7 @@ describe('FolderActionsService', () => {
it('should call the error on the returned Observable if there is no delete permission', (done) => {
spyOn(documentListService, 'deleteNode').and.callFake(() => {
return new Observable<any>(observer => {
return new Observable<any>((observer) => {
observer.next();
observer.complete();
});
@@ -168,7 +168,7 @@ describe('FolderActionsService', () => {
it('should delete the folder node if there is the delete and others permission ', () => {
spyOn(documentListService, 'deleteNode').and.callFake(() => {
return new Observable<any>(observer => {
return new Observable<any>((observer) => {
observer.next();
observer.complete();
});
@@ -185,7 +185,7 @@ describe('FolderActionsService', () => {
it('should support deletion only folder node', () => {
spyOn(documentListService, 'deleteNode').and.callFake(() => {
return new Observable<any>(observer => {
return new Observable<any>((observer) => {
observer.next();
observer.complete();
});
@@ -205,7 +205,7 @@ describe('FolderActionsService', () => {
it('should require node id to delete', () => {
spyOn(documentListService, 'deleteNode').and.callFake(() => {
return new Observable<any>(observer => {
return new Observable<any>((observer) => {
observer.next();
observer.complete();
});
@@ -220,7 +220,7 @@ describe('FolderActionsService', () => {
it('should reload target upon node deletion', (done) => {
spyOn(documentListService, 'deleteNode').and.callFake(() => {
return new Observable<any>(observer => {
return new Observable<any>((observer) => {
observer.next();
observer.complete();
});
@@ -244,7 +244,7 @@ describe('FolderActionsService', () => {
it('should emit success event upon node deletion', (done) => {
spyOn(documentListService, 'deleteNode').and.callFake(() => {
return new Observable<any>(observer => {
return new Observable<any>((observer) => {
observer.next();
observer.complete();
});