tslint arrow-parens rule (#4003)

This commit is contained in:
Eugenio Romano
2018-11-23 01:06:56 +00:00
committed by GitHub
parent 51bb6a420f
commit 34a30c0f14
194 changed files with 725 additions and 723 deletions

View File

@@ -50,7 +50,7 @@ export class CustomResourcesService {
* @returns List of nodes for the recently used files
*/
getRecentFiles(personId: string, pagination: PaginationModel): Observable<NodePaging> {
return new Observable(observer => {
return new Observable((observer) => {
this.apiService.peopleApi.getPerson(personId)
.then((person: PersonEntry) => {
const username = person.entry.id;
@@ -89,7 +89,7 @@ export class CustomResourcesService {
observer.error(err);
observer.complete();
});
}).pipe(catchError(err => this.handleError(err)));
}).pipe(catchError((err) => this.handleError(err)));
}
/**
@@ -108,7 +108,7 @@ export class CustomResourcesService {
include: includeFieldsRequest
};
return new Observable(observer => {
return new Observable((observer) => {
this.apiService.favoritesApi.getFavorites('-me-', options)
.then((result: NodePaging) => {
let page: NodePaging = {
@@ -135,7 +135,7 @@ export class CustomResourcesService {
observer.error(err);
observer.complete();
});
}).pipe(catchError(err => this.handleError(err)));
}).pipe(catchError((err) => this.handleError(err)));
}
/**
@@ -150,7 +150,7 @@ export class CustomResourcesService {
skipCount: pagination.skipCount
};
return new Observable(observer => {
return new Observable((observer) => {
this.apiService.peopleApi.getSiteMembership('-me-', options)
.then((result: SitePaging) => {
let page: NodePaging = {
@@ -174,7 +174,7 @@ export class CustomResourcesService {
observer.error(err);
observer.complete();
});
}).pipe(catchError(err => this.handleError(err)));
}).pipe(catchError((err) => this.handleError(err)));
}
/**
@@ -189,7 +189,7 @@ export class CustomResourcesService {
skipCount: pagination.skipCount
};
return new Observable(observer => {
return new Observable((observer) => {
this.apiService.sitesApi.getSites(options)
.then((page: NodePaging) => {
page.list.entries.map(
@@ -205,7 +205,7 @@ export class CustomResourcesService {
observer.error(err);
observer.complete();
});
}).pipe(catchError(err => this.handleError(err)));
}).pipe(catchError((err) => this.handleError(err)));
}
/**
@@ -224,7 +224,7 @@ export class CustomResourcesService {
};
return from(this.apiService.nodesApi.getDeletedNodes(options))
.pipe(catchError(err => this.handleError(err)));
.pipe(catchError((err) => this.handleError(err)));
}
@@ -244,7 +244,7 @@ export class CustomResourcesService {
};
return from(this.apiService.sharedLinksApi.findSharedLinks(options))
.pipe(catchError(err => this.handleError(err)));
.pipe(catchError((err) => this.handleError(err)));
}
/**
@@ -314,7 +314,7 @@ export class CustomResourcesService {
if (this.isCustomSource(nodeId)) {
return this.loadFolderByNodeId(nodeId, pagination, [])
.pipe(map(result => result.list.entries.map((node: any) => {
.pipe(map((result) => result.list.entries.map((node: any) => {
if (nodeId === '-sharedlinks-') {
return node.entry.nodeId;
@@ -331,7 +331,7 @@ export class CustomResourcesService {
} else if (nodeId) {
// cases when nodeId is '-my-', '-root-' or '-shared-'
return from(this.apiService.nodesApi.getNode(nodeId)
.then(node => [node.entry.id]));
.then((node) => [node.entry.id]));
}
return of([]);

View File

@@ -107,7 +107,7 @@ describe('DocumentListService', () => {
it('should create a folder in the path', () => {
service.createFolder('fake-name', 'fake-path').subscribe(
res => {
(res) => {
expect(res).toBeDefined();
expect(res.entry).toBeDefined();
expect(res.entry.isFolder).toBeTruthy();
@@ -125,10 +125,10 @@ describe('DocumentListService', () => {
it('should emit an error when the folder already exist', () => {
service.createFolder('fake-name', 'fake-path').subscribe(
res => {
(res) => {
},
err => {
(err) => {
expect(err).toBeDefined();
expect(err.status).toEqual(409);
expect(err.response).toBeDefined();
@@ -144,7 +144,7 @@ describe('DocumentListService', () => {
it('should return the folder info', () => {
service.getFolder('/fake-root/fake-name').subscribe(
res => {
(res) => {
expect(res).toBeDefined();
expect(res.list).toBeDefined();
expect(res.list.entries).toBeDefined();
@@ -210,7 +210,7 @@ describe('DocumentListService', () => {
it('should delete the folder', () => {
service.deleteNode('fake-id').subscribe(
res => {
(res) => {
expect(res).toBeNull();
}
);

View File

@@ -88,7 +88,7 @@ export class DocumentListService {
*/
copyNode(nodeId: string, targetParentId: string) {
return from(this.apiService.getInstance().nodes.copyNode(nodeId, { targetParentId })).pipe(
catchError(err => this.handleError(err))
catchError((err) => this.handleError(err))
);
}
@@ -101,7 +101,7 @@ export class DocumentListService {
*/
moveNode(nodeId: string, targetParentId: string) {
return from(this.apiService.getInstance().nodes.moveNode(nodeId, { targetParentId })).pipe(
catchError(err => this.handleError(err))
catchError((err) => this.handleError(err))
);
}
@@ -114,7 +114,7 @@ export class DocumentListService {
createFolder(name: string, parentId: string): Observable<MinimalNodeEntity> {
return from(this.apiService.getInstance().nodes.createFolder(name, '/', parentId))
.pipe(
catchError(err => this.handleError(err))
catchError((err) => this.handleError(err))
);
}
@@ -128,7 +128,7 @@ export class DocumentListService {
getFolder(folder: string, opts?: any, includeFields: string[] = []): Observable<NodePaging> {
return from(this.getNodesPromise(folder, opts, includeFields))
.pipe(
catchError(err => this.handleError(err))
catchError((err) => this.handleError(err))
);
}

View File

@@ -107,7 +107,7 @@ describe('FolderActionsService', () => {
it('should delete the folder node if there is the delete permission', () => {
spyOn(documentListService, 'deleteNode').and.callFake(() => {
return new Observable<any>(observer => {
return new Observable<any>((observer) => {
observer.next();
observer.complete();
});
@@ -125,7 +125,7 @@ describe('FolderActionsService', () => {
it('should not delete the folder node if there is no delete permission', (done) => {
spyOn(documentListService, 'deleteNode').and.callFake(() => {
return new Observable<any>(observer => {
return new Observable<any>((observer) => {
observer.next();
observer.complete();
});
@@ -146,7 +146,7 @@ describe('FolderActionsService', () => {
it('should call the error on the returned Observable if there is no delete permission', (done) => {
spyOn(documentListService, 'deleteNode').and.callFake(() => {
return new Observable<any>(observer => {
return new Observable<any>((observer) => {
observer.next();
observer.complete();
});
@@ -168,7 +168,7 @@ describe('FolderActionsService', () => {
it('should delete the folder node if there is the delete and others permission ', () => {
spyOn(documentListService, 'deleteNode').and.callFake(() => {
return new Observable<any>(observer => {
return new Observable<any>((observer) => {
observer.next();
observer.complete();
});
@@ -185,7 +185,7 @@ describe('FolderActionsService', () => {
it('should support deletion only folder node', () => {
spyOn(documentListService, 'deleteNode').and.callFake(() => {
return new Observable<any>(observer => {
return new Observable<any>((observer) => {
observer.next();
observer.complete();
});
@@ -205,7 +205,7 @@ describe('FolderActionsService', () => {
it('should require node id to delete', () => {
spyOn(documentListService, 'deleteNode').and.callFake(() => {
return new Observable<any>(observer => {
return new Observable<any>((observer) => {
observer.next();
observer.complete();
});
@@ -220,7 +220,7 @@ describe('FolderActionsService', () => {
it('should reload target upon node deletion', (done) => {
spyOn(documentListService, 'deleteNode').and.callFake(() => {
return new Observable<any>(observer => {
return new Observable<any>((observer) => {
observer.next();
observer.complete();
});
@@ -244,7 +244,7 @@ describe('FolderActionsService', () => {
it('should emit success event upon node deletion', (done) => {
spyOn(documentListService, 'deleteNode').and.callFake(() => {
return new Observable<any>(observer => {
return new Observable<any>((observer) => {
observer.next();
observer.complete();
});