tslint arrow-parens rule (#4003)

This commit is contained in:
Eugenio Romano
2018-11-23 01:06:56 +00:00
committed by GitHub
parent 51bb6a420f
commit 34a30c0f14
194 changed files with 725 additions and 723 deletions

View File

@@ -123,7 +123,7 @@ export class ChecklistComponent implements OnChanges {
public delete(taskId: string) {
this.activitiTaskList.deleteTask(taskId).subscribe(
() => {
this.checklist = this.checklist.filter(check => check.id !== taskId);
this.checklist = this.checklist.filter((check) => check.id !== taskId);
this.checklistTaskDeleted.emit(taskId);
},
(error) => {

View File

@@ -268,7 +268,7 @@ describe('StartTaskComponent', () => {
let attachFormToATask = spyOn(service, 'attachFormToATask').and.returnValue(of());
spyOn(service, 'createNewTask').and.callFake(
function() {
return new Observable(observer => {
return new Observable((observer) => {
observer.next({ id: 'task-id'});
observer.complete();
});

View File

@@ -195,7 +195,7 @@ export class TaskDetailsComponent implements OnInit, OnChanges {
this.formRenderingService.setComponentTypeResolver('select-folder', () => AttachFolderWidgetComponent, true);
this.formRenderingService.setComponentTypeResolver('upload', () => AttachFileWidgetComponent, true);
this.peopleSearch = new Observable<UserProcessModel[]>(observer => this.peopleSearchObserver = observer)
this.peopleSearch = new Observable<UserProcessModel[]>((observer) => this.peopleSearchObserver = observer)
.pipe(share());
this.authService.getBpmLoggedUser().subscribe((user: UserRepresentation) => {
this.currentLoggedUser = user;
@@ -469,7 +469,7 @@ export class TaskDetailsComponent implements OnInit, OnChanges {
.subscribe((users) => {
users = users.filter((user) => user.id !== this.taskDetails.assignee.id);
this.peopleSearchObserver.next(users);
}, error => this.logService.error('Could not load users'));
}, (error) => this.logService.error('Could not load users'));
}
onCloseSearch() {

View File

@@ -130,7 +130,7 @@ export class TaskFiltersComponent implements OnInit, OnChanges {
*/
getFiltersByAppName(appName: string) {
this.appsProcessService.getDeployedApplicationsByName(appName).subscribe(
application => {
(application) => {
this.getFiltersByAppId(application.id);
},
(err) => {

View File

@@ -322,7 +322,7 @@ describe('TaskListComponent', () => {
});
let rowEvent = new DataRowEvent(row, null);
component.rowClick.subscribe(taskId => {
component.rowClick.subscribe((taskId) => {
expect(taskId).toEqual('999');
expect(component.getCurrentId()).toEqual('999');
done();

View File

@@ -347,7 +347,7 @@ export class TaskListComponent extends DataTableSchema implements OnChanges, Aft
* @param instances
*/
private optimizeTaskDetails(instances: any[]): any[] {
instances = instances.map(task => {
instances = instances.map((task) => {
if (!task.name) {
task.name = 'No name';
}

View File

@@ -35,7 +35,7 @@ export class ProcessUploadService extends UploadService {
let processInstanceId = file.options.parentId;
let promise = this.apiService.getInstance().activiti.contentApi.createRelatedContentOnProcessInstance(processInstanceId, file.file, opts);
promise.catch(err => this.handleError(err));
promise.catch((err) => this.handleError(err));
return promise;
}

View File

@@ -48,7 +48,7 @@ export class TaskFilterService {
let completedTasksFilter = this.getCompletedTasksFilterInstance(appId);
let completeObservable = this.addFilter(completedTasksFilter);
return new Observable(observer => {
return new Observable((observer) => {
forkJoin(
involvedObservable,
myTaskObservable,
@@ -97,7 +97,7 @@ export class TaskFilterService {
});
return filters;
}),
catchError(err => this.handleError(err))
catchError((err) => this.handleError(err))
);
}
@@ -109,8 +109,8 @@ export class TaskFilterService {
*/
getTaskFilterById(filterId: number, appId?: number): Observable<FilterRepresentationModel> {
return from(this.callApiTaskFilters(appId)).pipe(
map(response => response.data.find(filter => filter.id === filterId)),
catchError(err => this.handleError(err))
map((response) => response.data.find((filter) => filter.id === filterId)),
catchError((err) => this.handleError(err))
);
}
@@ -122,8 +122,8 @@ export class TaskFilterService {
*/
getTaskFilterByName(taskName: string, appId?: number): Observable<FilterRepresentationModel> {
return from(this.callApiTaskFilters(appId)).pipe(
map(response => response.data.find(filter => filter.name === taskName)),
catchError(err => this.handleError(err))
map((response) => response.data.find((filter) => filter.name === taskName)),
catchError((err) => this.handleError(err))
);
}
@@ -138,7 +138,7 @@ export class TaskFilterService {
map((response: FilterRepresentationModel) => {
return response;
}),
catchError(err => this.handleError(err))
catchError((err) => this.handleError(err))
);
}

View File

@@ -35,7 +35,7 @@ export class TaskUploadService extends UploadService {
let taskId = file.options.parentId;
let promise = this.apiService.getInstance().activiti.contentApi.createRelatedContentOnTask(taskId, file.file, opts);
promise.catch(err => this.handleError(err));
promise.catch((err) => this.handleError(err));
return promise;
}

View File

@@ -61,7 +61,7 @@ describe('Activiti TaskList Service', () => {
describe('Content tests', () => {
it('should return the task list filtered', (done) => {
service.getTasks(<TaskQueryRequestRepresentationModel> fakeFilter).subscribe(res => {
service.getTasks(<TaskQueryRequestRepresentationModel> fakeFilter).subscribe((res) => {
expect(res).toBeDefined();
expect(res.size).toEqual(1);
expect(res.start).toEqual(0);
@@ -85,7 +85,7 @@ describe('Activiti TaskList Service', () => {
spyOn(service, 'getTasks').and.returnValue(of(fakeTaskList));
spyOn(service, 'getTotalTasks').and.returnValue(of(fakeTaskList));
service.findAllTaskByState(<TaskQueryRequestRepresentationModel> fakeFilter, 'open').subscribe(res => {
service.findAllTaskByState(<TaskQueryRequestRepresentationModel> fakeFilter, 'open').subscribe((res) => {
expect(res).toBeDefined();
expect(res.size).toEqual(1);
@@ -104,7 +104,7 @@ describe('Activiti TaskList Service', () => {
spyOn(service, 'getTasks').and.returnValue(of(fakeTaskList));
spyOn(service, 'getTotalTasks').and.returnValue(of(fakeTaskList));
service.findAllTaskByState(<TaskQueryRequestRepresentationModel> fakeFilter).subscribe(res => {
service.findAllTaskByState(<TaskQueryRequestRepresentationModel> fakeFilter).subscribe((res) => {
expect(res).toBeDefined();
expect(res.size).toEqual(1);
expect(res.start).toEqual(0);
@@ -119,7 +119,7 @@ describe('Activiti TaskList Service', () => {
});
it('should return the task list filtered by state', (done) => {
service.findTasksByState(<TaskQueryRequestRepresentationModel> fakeFilter, 'open').subscribe(res => {
service.findTasksByState(<TaskQueryRequestRepresentationModel> fakeFilter, 'open').subscribe((res) => {
expect(res).toBeDefined();
expect(res.size).toEqual(1);
expect(res.start).toEqual(0);
@@ -140,7 +140,7 @@ describe('Activiti TaskList Service', () => {
});
it('should return the task list filtered', (done) => {
service.findTasksByState(<TaskQueryRequestRepresentationModel> fakeFilter).subscribe(res => {
service.findTasksByState(<TaskQueryRequestRepresentationModel> fakeFilter).subscribe((res) => {
expect(res.size).toEqual(1);
expect(res.start).toEqual(0);
expect(res.data).toBeDefined();
@@ -163,7 +163,7 @@ describe('Activiti TaskList Service', () => {
spyOn(service, 'getTasks').and.returnValue(of(fakeTaskList));
spyOn(service, 'getTotalTasks').and.returnValue(of(fakeTaskList));
service.findAllTasksWithoutState(<TaskQueryRequestRepresentationModel> fakeFilter).subscribe(res => {
service.findAllTasksWithoutState(<TaskQueryRequestRepresentationModel> fakeFilter).subscribe((res) => {
expect(res).toBeDefined();
expect(res.data).toBeDefined();
expect(res.data.length).toEqual(2);
@@ -183,7 +183,7 @@ describe('Activiti TaskList Service', () => {
it('Should return both open and completed task', (done) => {
spyOn(service, 'findTasksByState').and.returnValue(of(fakeOpenTaskList));
spyOn(service, 'findAllTaskByState').and.returnValue(of(fakeCompletedTaskList));
service.findAllTasksWithoutState(<TaskQueryRequestRepresentationModel> fakeFilter).subscribe(res => {
service.findAllTasksWithoutState(<TaskQueryRequestRepresentationModel> fakeFilter).subscribe((res) => {
expect(res).toBeDefined();
expect(res.data).toBeDefined();
expect(res.data.length).toEqual(4);
@@ -200,7 +200,7 @@ describe('Activiti TaskList Service', () => {
spyOn(service, 'getTasks').and.returnValue(of(fakeTaskList));
spyOn(service, 'getTotalTasks').and.returnValue(of(fakeTaskList));
service.findAllTasksWithoutState(<TaskQueryRequestRepresentationModel> fakeFilter).subscribe(res => {
service.findAllTasksWithoutState(<TaskQueryRequestRepresentationModel> fakeFilter).subscribe((res) => {
expect(res).toBeDefined();
expect(res.data).toBeDefined();
expect(res.data.length).toEqual(2);

View File

@@ -73,9 +73,9 @@ export class TaskListService {
return from(this.callApiTasksFiltered(requestNodeForFilter))
.pipe(
map((res: any) => {
return res.data.find(element => element.id === taskId) ? filterModel : null;
return res.data.find((element) => element.id === taskId) ? filterModel : null;
}),
catchError(err => this.handleError(err))
catchError((err) => this.handleError(err))
);
}
@@ -87,7 +87,7 @@ export class TaskListService {
getTasks(requestNode: TaskQueryRequestRepresentationModel): Observable<TaskListModel> {
return from<TaskListModel>(this.callApiTasksFiltered(requestNode))
.pipe(
catchError(err => this.handleError(err))
catchError((err) => this.handleError(err))
);
}
@@ -153,7 +153,7 @@ export class TaskListService {
map((details: any) => {
return new TaskDetailsModel(details);
}),
catchError(err => this.handleError(err))
catchError((err) => this.handleError(err))
);
}
@@ -172,7 +172,7 @@ export class TaskListService {
});
return checklists;
}),
catchError(err => this.handleError(err))
catchError((err) => this.handleError(err))
);
}
@@ -196,7 +196,7 @@ export class TaskListService {
});
return forms;
}),
catchError(err => this.handleError(err))
catchError((err) => this.handleError(err))
);
}
@@ -209,7 +209,7 @@ export class TaskListService {
attachFormToATask(taskId: string, formId: number): Observable<any> {
return from(this.apiService.taskApi.attachForm(taskId, { 'formId': formId }))
.pipe(
catchError(err => this.handleError(err))
catchError((err) => this.handleError(err))
);
}
@@ -224,7 +224,7 @@ export class TaskListService {
map((response: TaskDetailsModel) => {
return new TaskDetailsModel(response);
}),
catchError(err => this.handleError(err))
catchError((err) => this.handleError(err))
);
}
@@ -236,7 +236,7 @@ export class TaskListService {
deleteTask(taskId: string): Observable<TaskDetailsModel> {
return from<TaskDetailsModel>(this.callApiDeleteTask(taskId))
.pipe(
catchError(err => this.handleError(err))
catchError((err) => this.handleError(err))
);
}
@@ -248,7 +248,7 @@ export class TaskListService {
deleteForm(taskId: string): Observable<TaskDetailsModel> {
return from<TaskDetailsModel>(this.callApiDeleteForm(taskId))
.pipe(
catchError(err => this.handleError(err))
catchError((err) => this.handleError(err))
);
}
@@ -260,7 +260,7 @@ export class TaskListService {
completeTask(taskId: string) {
return from(this.apiService.taskApi.completeTask(taskId))
.pipe(
catchError(err => this.handleError(err))
catchError((err) => this.handleError(err))
);
}
@@ -276,7 +276,7 @@ export class TaskListService {
map((res: any) => {
return res;
}),
catchError(err => this.handleError(err))
catchError((err) => this.handleError(err))
);
}
@@ -291,7 +291,7 @@ export class TaskListService {
map((response: TaskDetailsModel) => {
return new TaskDetailsModel(response);
}),
catchError(err => this.handleError(err))
catchError((err) => this.handleError(err))
);
}
@@ -308,7 +308,7 @@ export class TaskListService {
map((response: TaskDetailsModel) => {
return new TaskDetailsModel(response);
}),
catchError(err => this.handleError(err))
catchError((err) => this.handleError(err))
);
}
@@ -325,7 +325,7 @@ export class TaskListService {
map((response: TaskDetailsModel) => {
return new TaskDetailsModel(response);
}),
catchError(err => this.handleError(err))
catchError((err) => this.handleError(err))
);
}
@@ -337,7 +337,7 @@ export class TaskListService {
claimTask(taskId: string): Observable<TaskDetailsModel> {
return from<TaskDetailsModel>(this.apiService.taskApi.claimTask(taskId))
.pipe(
catchError(err => this.handleError(err))
catchError((err) => this.handleError(err))
);
}
@@ -349,7 +349,7 @@ export class TaskListService {
unclaimTask(taskId: string): Observable<TaskDetailsModel> {
return from<TaskDetailsModel>(this.apiService.taskApi.unclaimTask(taskId))
.pipe(
catchError(err => this.handleError(err))
catchError((err) => this.handleError(err))
);
}
@@ -362,8 +362,8 @@ export class TaskListService {
updateTask(taskId: any, updated): Observable<TaskDetailsModel> {
return from(this.apiService.taskApi.updateTask(taskId, updated))
.pipe(
map(result => <TaskDetailsModel> result),
catchError(err => this.handleError(err))
map((result) => <TaskDetailsModel> result),
catchError((err) => this.handleError(err))
);
}
@@ -375,8 +375,8 @@ export class TaskListService {
fetchTaskAuditPdfById(taskId: string): Observable<Blob> {
return from(this.apiService.taskApi.getTaskAuditPdf(taskId))
.pipe(
map(data => <Blob> data),
catchError(err => this.handleError(err))
map((data) => <Blob> data),
catchError((err) => this.handleError(err))
);
}
@@ -388,7 +388,7 @@ export class TaskListService {
fetchTaskAuditJsonById(taskId: string): Observable<any> {
return from(this.apiService.taskApi.getTaskAuditJson(taskId))
.pipe(
catchError(err => this.handleError(err))
catchError((err) => this.handleError(err))
);
}