[ADF-4099]Implement tests for The metadata group is always showed even though the properties are not there (#4421)

* Create a custom empty aspect.

* Implement empty aspect

* Add ' The aspect with empty properties is displayed' test.

* Fix lint errors

* Enabling screenshots

* no message

* Fix upload tests

* no message

* Trying to fix upload tests

* no message

* remove save

* lint

* Fix lint

e2e/content-services/upload/uploader-component.e2e.ts

@@ -134,6 +134,8 @@ describe('Upload component', () => {
 
         it('[C260173] Should be able to upload folder when enabled', () => {
             uploadToggles.enableFolderUpload();
+            uploadToggles.checkFolderUploadToggleIsEnabled();
+
             contentServicesPage.uploadFolder(folderOne.location);
             uploadDialog.checkUploadCompleted().then(() => {
                 contentServicesPage.checkContentIsDisplayed(folderOne.name);
@@ -193,6 +195,8 @@ describe('Upload component', () => {
 
         it('[C272794] Should display tooltip for uploading files', () => {
             uploadToggles.enableMultipleFileUpload();
+            uploadToggles.checkMultipleFileUploadToggleIsEnabled();
+
             browser.driver.sleep(1000);
             expect(contentServicesPage.getMultipleFileButtonTooltip()).toEqual('Custom tooltip');
             uploadToggles.disableMultipleFileUpload();
@@ -218,6 +222,7 @@ describe('Upload component', () => {
 
         it('[C260172] Should be possible to enable versioning', () => {
             uploadToggles.enableVersioning();
+            uploadToggles.checkVersioningToggleIsEnabled();
 
             contentServicesPage
                 .uploadFile(pdfFileModel.location)
@@ -247,6 +252,7 @@ describe('Upload component', () => {
             contentServicesPage.goToDocumentList();
             contentServicesPage.checkAcsContainer();
             uploadToggles.enableMaxSize();
+            uploadToggles.checkMaxSizeToggleIsEnabled();
             uploadToggles.addMaxSize('400');
             contentServicesPage.uploadFile(fileWithSpecificSize.location);
             uploadDialog.fileIsUploaded(fileWithSpecificSize.name).clickOnCloseButton().dialogIsNotDisplayed();
@@ -268,6 +274,7 @@ describe('Upload component', () => {
         it('[C272796] Should be possible to set max size to 0', () => {
             contentServicesPage.goToDocumentList();
             uploadToggles.enableMaxSize();
+            uploadToggles.checkMaxSizeToggleIsEnabled();
             uploadToggles.addMaxSize('0');
             contentServicesPage.uploadFile(fileWithSpecificSize.location);
             // expect(contentServicesPage.getErrorMessage()).toEqual('File ' + fileWithSpecificSize.name + ' is larger than the allowed file size');
@@ -281,6 +288,7 @@ describe('Upload component', () => {
 
         it('[C272797] Should be possible to set max size to 1', () => {
             uploadToggles.enableMaxSize();
+            uploadToggles.checkMaxSizeToggleIsEnabled();
             browser.driver.sleep(1000);
             uploadToggles.addMaxSize('1');
             uploadToggles.disableMaxSize();

e2e/content-services/upload/user-permission.e2e.ts

@@ -121,12 +121,12 @@ describe('Upload - User permission', () => {
         it('[C212861] Should not be allowed to Drag and drop a file/folder in a folder with consumer permissions', () => {
             contentServicesPage.checkDragAndDropDIsDisplayed();
 
-            contentServicesPage.dragAndDropFile(emptyFile.location);
             contentServicesPage.dragAndDropFolder(folder.location);
-
-            contentServicesPage.checkContentIsDisplayed(emptyFile.name);
             contentServicesPage.checkContentIsDisplayed(folder.name);
 
+            contentServicesPage.dragAndDropFile(emptyFile.location);
+            contentServicesPage.checkContentIsDisplayed(emptyFile.name);
+
             navigationBarPage.openContentServicesFolder(this.consumerSite.entry.guid);
 
             browser.sleep(3000);
@@ -175,6 +175,7 @@ describe('Upload - User permission', () => {
 
         it('[C279916] Should not be allowed to upload a folder in folder with consumer permissions', () => {
             uploadToggles.enableFolderUpload();
+            uploadToggles.checkFolderUploadToggleIsEnabled();
 
             contentServicesPage.uploadFolder(folder.location)
                 .checkContentIsDisplayed(folder.name);
@@ -190,6 +191,7 @@ describe('Upload - User permission', () => {
             browser.sleep(3000);
 
             uploadToggles.enableFolderUpload();
+            uploadToggles.checkFolderUploadToggleIsEnabled();
 
             contentServicesPage.uploadFolder(folder.location);
 
@@ -211,7 +213,10 @@ describe('Upload - User permission', () => {
             contentServicesPage.checkDragAndDropDIsDisplayed();
 
             contentServicesPage.dragAndDropFile(emptyFile.location);
-            contentServicesPage.dragAndDropFolder(folder.location);
+            contentServicesPage.checkContentIsDisplayed(emptyFile.location);
+
+            contentServicesPage.dragAndDropFolder(folder.name);
+            contentServicesPage.checkContentIsDisplayed(folder.name);
 
             let fileInTheUploadedFolder = 'share_profile_pic.png';
 
@@ -227,6 +232,7 @@ describe('Upload - User permission', () => {
 
         it('[C279918] Should be allowed to upload a folder in a folder with manager permissions', () => {
             uploadToggles.enableFolderUpload();
+            uploadToggles.checkFolderUploadToggleIsEnabled();
 
             contentServicesPage.uploadFolder(folder.location);
             uploadDialog.checkUploadCompleted().then(() => {

e2e/core/card-view/aspect-oriented-config.e2e.ts

@@ -42,6 +42,8 @@ describe('Aspect oriented config', () => {
     const navigationBarPage = new NavigationBarPage();
     const configEditorPage = new ConfigEditorPage();
     let contentServicesPage = new ContentServicesPage();
+    let modelOneName = 'modelOne', emptyAspectName = 'emptyAspect';
+    let defaultModel = 'cm', defaultEmptyPropertiesAspect = 'taggable', aspectName = 'Taggable';
 
     let acsUser = new AcsUserModel();
 
@@ -61,14 +63,32 @@ describe('Aspect oriented config', () => {
 
         await this.alfrescoJsApi.login(TestConfig.adf.adminEmail, TestConfig.adf.adminPassword);
 
+        try {
+            await this.alfrescoJsApi.core.customModelApi.createCustomModel('ACTIVE', modelOneName, modelOneName, modelOneName, modelOneName);
+        } catch (e) {
+        }
+
+        try {
+            await this.alfrescoJsApi.core.customModelApi.createCustomAspect(modelOneName, emptyAspectName, null, emptyAspectName, emptyAspectName);
+        } catch (e) {
+        }
+
         await this.alfrescoJsApi.core.peopleApi.addPerson(acsUser);
 
         await this.alfrescoJsApi.login(acsUser.id, acsUser.password);
 
-        await uploadActions.uploadFile(this.alfrescoJsApi, pngFileModel.location, pngFileModel.name, '-my-');
+        let uploadedFile = await uploadActions.uploadFile(this.alfrescoJsApi, pngFileModel.location, pngFileModel.name, '-my-');
 
         loginPage.loginToContentServicesUsingUserModel(acsUser);
 
+        let aspects = await this.alfrescoJsApi.core.nodesApi.getNode(uploadedFile.entry.id);
+
+        aspects.entry.aspectNames.push(modelOneName.concat(':', emptyAspectName));
+
+        aspects.entry.aspectNames.push(defaultModel.concat(':', defaultEmptyPropertiesAspect));
+
+        await this.alfrescoJsApi.core.nodesApi.updateNode(uploadedFile.entry.id, {'aspectNames': aspects.entry.aspectNames});
+
         done();
     });
 
@@ -275,4 +295,54 @@ describe('Aspect oriented config', () => {
         metadataViewPage.checkMetadataGroupIsPresent('EXIF');
         metadataViewPage.checkMetadataGroupIsPresent('Versionable');
     });
+
+    it('[C299186] The aspect without properties is not displayed', () => {
+
+        configEditorPage.enterBigConfigurationText('{' +
+            '    "presets": { "' + modelOneName +
+            '       ": { "' + modelOneName + ':' + emptyAspectName +
+            '            ":"*"' +
+            '        }' +
+            '    }' +
+            '}');
+
+        configEditorPage.clickSaveButton();
+
+        navigationBarPage.clickContentServicesButton();
+
+        viewerPage.viewFile(pngFileModel.name);
+        viewerPage.clickInfoButton();
+        viewerPage.checkInfoSideBarIsDisplayed();
+        metadataViewPage.clickOnPropertiesTab();
+
+        metadataViewPage.informationButtonIsDisplayed();
+        metadataViewPage.clickOnInformationButton();
+
+        metadataViewPage.checkMetadataGroupIsNotPresent(emptyAspectName);
+    });
+
+    it('[C279968] The aspect with empty properties is displayed', () => {
+
+        configEditorPage.enterBigConfigurationText('{' +
+            '    "presets": { "' + defaultModel +
+            '       ": { "' + defaultModel + ':' + defaultEmptyPropertiesAspect +
+            '            ":"*"' +
+            '        }' +
+            '    }' +
+            '}');
+
+        configEditorPage.clickSaveButton();
+
+        navigationBarPage.clickContentServicesButton();
+
+        viewerPage.viewFile(pngFileModel.name);
+        viewerPage.clickInfoButton();
+        viewerPage.checkInfoSideBarIsDisplayed();
+        metadataViewPage.clickOnPropertiesTab();
+
+        metadataViewPage.informationButtonIsDisplayed();
+        metadataViewPage.clickOnInformationButton();
+
+        metadataViewPage.checkMetadataGroupIsPresent(aspectName);
+    });
 });

e2e/core/user-info-component-cloud.e2e.ts

@@ -42,7 +42,7 @@ describe('User Info - SSO', () => {
         loginSSOPage.loginSSOIdentityService(identityUser.username, identityUser.password);
     });
 
-    afterAll (async () => {
+    afterAll(async () => {
         await identityService.deleteIdentityUser(identityUser.id);
     });
 

e2e/pages/adf/dialog/uploadToggles.ts

@@ -47,6 +47,30 @@ export class UploadToggles {
         return this;
     }
 
+    checkFolderUploadToggleIsEnabled() {
+        let enabledToggle = element(by.css('mat-slide-toggle[id="adf-folder-upload-switch"][class*="mat-checked"]'));
+        Util.waitUntilElementIsVisible(enabledToggle);
+        return this;
+    }
+
+    checkMultipleFileUploadToggleIsEnabled() {
+        let enabledToggle = element(by.css('mat-slide-toggle[id="adf-multiple-upload-switch"][class*="mat-checked"]'));
+        Util.waitUntilElementIsVisible(enabledToggle);
+        return this;
+    }
+
+    checkMaxSizeToggleIsEnabled() {
+        let enabledToggle = element(by.css('mat-slide-toggle[id="adf-max-size-filter-upload-switch"][class*="mat-checked"]'));
+        Util.waitUntilElementIsVisible(enabledToggle);
+        return this;
+    }
+
+    checkVersioningToggleIsEnabled() {
+        let enabledToggle = element(by.css('mat-slide-toggle[id="adf-version-upload-switch"][class*="mat-checked"]'));
+        Util.waitUntilElementIsVisible(enabledToggle);
+        return this;
+    }
+
     disableFolderUpload() {
         this.formControllersPage.disableToggle(this.uploadFolderToggle);
         return this;