[DW-1486] form versioning and cloud service enhancements (#5248)

* support form versions retrieval

* rework cloud services, reduce code duplication

* revert app config changes

* fix api spelling error

* support task form versioning

* turn TaskDetailsCloudModel into interface

* remove commented code

* fix test

* update tests

* remove useless provider declarations

lib/content-services/src/lib/content-metadata/services/config/content-metadata-config.factory.spec.ts

@@ -35,14 +35,11 @@ describe('ContentMetadataConfigFactory', () => {
             HttpClientModule
         ],
         providers: [
-            ContentMetadataConfigFactory,
-            AppConfigService,
             {
                 provide: LogService, useValue: {
-                error: () => {
+                    error: () => {}
                 }
             }
-            }
         ]
     });
 
@@ -53,7 +50,7 @@ describe('ContentMetadataConfigFactory', () => {
 
     describe('get', () => {
 
-        let logService;
+        let logService: LogService;
 
         beforeEach(async(() => {
             logService = TestBed.get(LogService);

lib/content-services/src/lib/content-metadata/services/property-groups-translator.service.spec.ts

@@ -43,10 +43,9 @@ describe('PropertyGroupTranslatorService', () => {
         providers: [
             {
                 provide: LogService, useValue: {
-                error: () => {
+                    error: () => {}
                 }
             }
-            }
         ]
     });
 

lib/content-services/src/lib/content-node-share/content-node-share.dialog.spec.ts

@@ -53,8 +53,6 @@ describe('ShareDialogComponent', () => {
             ContentNodeShareModule
         ],
         providers: [
-            NodesApiService,
-            SharedLinksApiService,
             { provide: AppConfigService, useClass: AppConfigServiceMock },
             { provide: NotificationService, useValue: notificationServiceMock },
             { provide: MatDialogRef, useValue: { close: () => {}} },

lib/content-services/src/lib/content-node-share/content-node-share.directive.spec.ts

@@ -22,7 +22,7 @@ import { ComponentFixture } from '@angular/core/testing';
 import { Component } from '@angular/core';
 import { DOCUMENT } from '@angular/common';
 import { ContentTestingModule } from '../testing/content.testing.module';
-import { setupTestBed, CoreModule, SharedLinksApiService } from '@alfresco/adf-core';
+import { setupTestBed, CoreModule } from '@alfresco/adf-core';
 import { ContentNodeShareModule } from './content-node-share.module';
 
 @Component({
@@ -60,9 +60,6 @@ describe('NodeSharedDirective', () => {
         ],
         declarations: [
             NodeShareTestComponent
-        ],
-        providers: [
-            SharedLinksApiService
         ]
     });
 

lib/content-services/src/lib/directives/node-lock.directive.spec.ts

@@ -21,9 +21,7 @@ import { Component, DebugElement } from '@angular/core';
 
 import { NodeLockDirective } from './node-lock.directive';
 import { Node } from '@alfresco/js-api';
-import { NodeActionsService } from '../document-list/services/node-actions.service';
 import { ContentNodeDialogService } from '../content-node-selector/content-node-dialog.service';
-import { DocumentListService } from '../document-list/services/document-list.service';
 import { CoreModule, setupTestBed } from '@alfresco/adf-core';
 
 const fakeNode: Node = <Node> {
@@ -49,11 +47,6 @@ describe('NodeLock Directive', () => {
         imports: [
             CoreModule.forRoot()
         ],
-        providers: [
-            NodeActionsService,
-            ContentNodeDialogService,
-            DocumentListService
-        ],
         declarations: [
             TestComponent,
             NodeLockDirective

lib/content-services/src/lib/permission-manager/services/node-permission-dialog.service.spec.ts

@@ -34,8 +34,7 @@ describe('NodePermissionDialogService', () => {
     let contentService: ContentService;
 
     setupTestBed({
-        imports: [ContentTestingModule],
-        providers: [NodePermissionService]
+        imports: [ContentTestingModule]
     });
 
     beforeEach(() => {