unit test performance (#3194)

* DataTable (-4 sec)

* PaginationComponent (-1 sec)

* DocumentList

* custom testbed setup, test upgrades

* test fixes

* more test fixes

* remove fdescribe

* test fixes

* test fixes

* more test fixes

* test fixes

* upgrade tests

* update tests

* upgrade tests

* upgrade tests

* upgrade tests

* upgrade tests

* update tests

* translate loader fixes

* auth and cookie fixes

* upgrade tests

* upgrade tests

* test fixes

* almost there

* diable broken tests

* process tests (part 1)

* fix lint issues

* another test upgrade

* almost there

* cleanup

* insights testing upgrade

* improve tests

* tests cleanup

* tests cleanup

* cleanup tests

* test cleanup

* favorite nodes tests

* rebase fix syntax

* fix core test

* give up test focus

* flush tabs

* fix search test

* Update document-list.component.spec.ts

* fix document list lock

* increase tick time

* remove duplicate test

lib/content-services/directives/node-download.directive.spec.ts

@@ -19,7 +19,7 @@ import { TestBed, ComponentFixture } from '@angular/core/testing';
 import { By } from '@angular/platform-browser';
 import { MatDialog } from '@angular/material';
 import { Component, DebugElement } from '@angular/core';
-import { AlfrescoApiService } from '@alfresco/adf-core';
+import { AlfrescoApiService, setupTestBed, CoreModule, AlfrescoApiServiceMock } from '@alfresco/adf-core';
 
 import { DialogModule } from '../dialogs/dialog.module';
 import { NodeDownloadDirective } from './node-download.directive';
@@ -40,17 +40,22 @@ describe('NodeDownloadDirective', () => {
     let contentService;
     let dialogSpy;
 
-    beforeEach(() => {
-        TestBed.configureTestingModule({
-            imports: [
-                DialogModule
-            ],
-            declarations: [
-                TestComponent,
-                NodeDownloadDirective
-            ]
-        });
+    setupTestBed({
+        imports: [
+            CoreModule.forRoot(),
+            DialogModule
+        ],
+        providers: [
+            { provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock }
+            // { provide: AppConfigService, useValue: AppConfigServiceMock },
+        ],
+        declarations: [
+            TestComponent,
+            NodeDownloadDirective
+        ]
+    });
 
+    beforeEach(() => {
         fixture = TestBed.createComponent(TestComponent);
         component = fixture.componentInstance;
         element = fixture.debugElement.query(By.directive(NodeDownloadDirective));

lib/content-services/directives/node-lock.directive.spec.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-import { TestBed, ComponentFixture, async, fakeAsync } from '@angular/core/testing';
+import { TestBed, ComponentFixture, fakeAsync } from '@angular/core/testing';
 import { By } from '@angular/platform-browser';
 import { Component, DebugElement } from '@angular/core';
 
@@ -24,6 +24,8 @@ import { MinimalNodeEntryEntity } from 'alfresco-js-api';
 import { NodeActionsService } from '../document-list/services/node-actions.service';
 import { ContentNodeDialogService } from '../content-node-selector/content-node-dialog.service';
 import { DocumentListService } from '../document-list/services/document-list.service';
+import { setupTestBed } from '../../core/testing';
+import { CoreModule } from '@alfresco/adf-core';
 
 const fakeNode: MinimalNodeEntryEntity = <MinimalNodeEntryEntity> {
     id: 'fake',
@@ -44,22 +46,20 @@ describe('NodeLock Directive', () => {
     let element: DebugElement;
     let contentNodeDialogService: ContentNodeDialogService;
 
-    beforeEach(async(() => {
-        TestBed.configureTestingModule({
-            imports: [],
-            providers: [
-                NodeActionsService,
-                ContentNodeDialogService,
-                DocumentListService
-            ],
-            declarations: [
-                TestComponent,
-                NodeLockDirective
-            ]
-        });
-
-        TestBed.compileComponents();
-    }));
+    setupTestBed({
+        imports: [
+            CoreModule.forRoot()
+        ],
+        providers: [
+            NodeActionsService,
+            ContentNodeDialogService,
+            DocumentListService
+        ],
+        declarations: [
+            TestComponent,
+            NodeLockDirective
+        ]
+    });
 
     beforeEach(() => {
         fixture = TestBed.createComponent(TestComponent);