unit test performance (#3194)

* DataTable (-4 sec)

* PaginationComponent (-1 sec)

* DocumentList

* custom testbed setup, test upgrades

* test fixes

* more test fixes

* remove fdescribe

* test fixes

* test fixes

* more test fixes

* test fixes

* upgrade tests

* update tests

* upgrade tests

* upgrade tests

* upgrade tests

* upgrade tests

* update tests

* translate loader fixes

* auth and cookie fixes

* upgrade tests

* upgrade tests

* test fixes

* almost there

* diable broken tests

* process tests (part 1)

* fix lint issues

* another test upgrade

* almost there

* cleanup

* insights testing upgrade

* improve tests

* tests cleanup

* tests cleanup

* cleanup tests

* test cleanup

* favorite nodes tests

* rebase fix syntax

* fix core test

* give up test focus

* flush tabs

* fix search test

* Update document-list.component.spec.ts

* fix document list lock

* increase tick time

* remove duplicate test

lib/content-services/folder-directive/folder-create.directive.spec.ts

@@ -15,17 +15,14 @@
  * limitations under the License.
  */
 
-import { HttpClientModule } from '@angular/common/http';
 import { Component } from '@angular/core';
-import { ComponentFixture, TestBed, async } from '@angular/core/testing';
-import { FormsModule, ReactiveFormsModule } from '@angular/forms';
-import { MatDialog, MatDialogModule } from '@angular/material';
+import { async, ComponentFixture, TestBed } from '@angular/core/testing';
+import { MatDialog } from '@angular/material';
 import { By } from '@angular/platform-browser';
-import { TranslateLoader, TranslateModule } from '@ngx-translate/core';
 import { Observable } from 'rxjs/Observable';
 import { FolderDialogComponent } from '../dialogs/folder.dialog';
 
-import { DirectiveModule, ContentService, TranslateLoaderService } from '@alfresco/adf-core';
+import { ContentService, setupTestBed, CoreModule } from '@alfresco/adf-core';
 import { FolderCreateDirective } from './folder-create.directive';
 import { Subject } from 'rxjs/Subject';
 import { MinimalNodeEntryEntity } from 'alfresco-js-api';
@@ -39,7 +36,7 @@ import { MinimalNodeEntryEntity } from 'alfresco-js-api';
             [nodeType]="'cm:my-litte-pony'">
         </div>`
 })
-class Test1Component {
+class TestTypeComponent {
     parentNode = '';
     public successParameter: MinimalNodeEntryEntity = null;
 
@@ -51,13 +48,13 @@ class Test1Component {
 @Component({
     template: `<div [adf-create-folder]="parentNode"></div>`
 })
-class Test2Component {
+class TestComponent {
     parentNode = '';
     public successParameter: MinimalNodeEntryEntity = null;
 }
 
 describe('FolderCreateDirective', () => {
-    let fixture: ComponentFixture<Test1Component | Test2Component>;
+    let fixture: ComponentFixture<TestTypeComponent | TestComponent>;
     let element;
     let node: any;
     let dialog: MatDialog;
@@ -66,32 +63,27 @@ describe('FolderCreateDirective', () => {
 
     const event = { type: 'click', preventDefault: () => null };
 
-    beforeEach(async(() => {
-        TestBed.configureTestingModule({
-            imports: [
-                HttpClientModule,
-                MatDialogModule,
-                FormsModule,
-                DirectiveModule,
-                ReactiveFormsModule,
-                TranslateModule.forRoot({
-                    loader: {
-                        provide: TranslateLoader,
-                        useClass: TranslateLoaderService
-                    }
-                })
-            ],
-            declarations: [
-                Test1Component,
-                Test2Component,
-                FolderDialogComponent,
-                FolderCreateDirective
-            ],
-            providers: [
-                ContentService
-            ]
-        }).compileComponents();
-    }));
+    setupTestBed({
+        imports: [
+            CoreModule.forRoot()
+        ],
+        declarations: [
+            TestTypeComponent,
+            TestComponent,
+            FolderDialogComponent,
+            FolderCreateDirective
+        ],
+        providers: [
+            ContentService
+        ]
+    });
+
+    beforeEach(() => {
+        fixture = TestBed.createComponent(TestComponent);
+        element = fixture.debugElement.query(By.directive(FolderCreateDirective));
+        dialog = TestBed.get(MatDialog);
+        contentService = TestBed.get(ContentService);
+    });
 
     beforeEach(() => {
         node = { entry: { id: 'nodeId' } };
@@ -108,7 +100,7 @@ describe('FolderCreateDirective', () => {
     describe('With overrides', () => {
 
         beforeEach(() => {
-            fixture = TestBed.createComponent(Test1Component);
+            fixture = TestBed.createComponent(TestTypeComponent);
             element = fixture.debugElement.query(By.directive(FolderCreateDirective));
             dialog = TestBed.get(MatDialog);
             contentService = TestBed.get(ContentService);
@@ -173,7 +165,7 @@ describe('FolderCreateDirective', () => {
     describe('Without overrides', () => {
 
         beforeEach(() => {
-            fixture = TestBed.createComponent(Test2Component);
+            fixture = TestBed.createComponent(TestComponent);
             element = fixture.debugElement.query(By.directive(FolderCreateDirective));
             dialog = TestBed.get(MatDialog);
             contentService = TestBed.get(ContentService);

lib/content-services/folder-directive/folder-edit.directive.spec.ts

@@ -15,17 +15,13 @@
  * limitations under the License.
  */
 
-import { HttpClientModule } from '@angular/common/http';
 import { Component } from '@angular/core';
-import { ComponentFixture, TestBed, async } from '@angular/core/testing';
-import { MatDialog, MatDialogModule } from '@angular/material';
+import { async, ComponentFixture, TestBed } from '@angular/core/testing';
+import { MatDialog } from '@angular/material';
 import { By } from '@angular/platform-browser';
-
-import { FormsModule, ReactiveFormsModule } from '@angular/forms';
-import { TranslateLoader, TranslateModule } from '@ngx-translate/core';
 import { Observable } from 'rxjs/Observable';
 
-import { ContentService, TranslateLoaderService, DirectiveModule } from '@alfresco/adf-core';
+import { ContentService, setupTestBed, CoreModule } from '@alfresco/adf-core';
 import { FolderEditDirective } from './folder-edit.directive';
 import { MinimalNodeEntryEntity } from 'alfresco-js-api';
 import { Subject } from 'rxjs/Subject';
@@ -55,33 +51,17 @@ describe('FolderEditDirective', () => {
         preventDefault: () => null
     };
 
+    setupTestBed({
+        imports: [
+            CoreModule.forRoot()
+        ],
+        declarations: [
+            TestComponent,
+            FolderEditDirective
+        ]
+    });
+
     beforeEach(() => {
-        TestBed.configureTestingModule({
-            imports: [
-                HttpClientModule,
-                MatDialogModule,
-                FormsModule,
-                ReactiveFormsModule,
-                DirectiveModule,
-                TranslateModule.forRoot({
-                    loader: {
-                        provide: TranslateLoader,
-                        useClass: TranslateLoaderService
-                    }
-                })
-            ],
-            declarations: [
-                TestComponent,
-                FolderEditDirective
-            ]
-            ,
-            providers: [
-                ContentService
-            ]
-        });
-
-        TestBed.compileComponents();
-
         fixture = TestBed.createComponent(TestComponent);
         element = fixture.debugElement.query(By.directive(FolderEditDirective));
         dialog = TestBed.get(MatDialog);