unit test performance (#3194)

* DataTable (-4 sec)

* PaginationComponent (-1 sec)

* DocumentList

* custom testbed setup, test upgrades

* test fixes

* more test fixes

* remove fdescribe

* test fixes

* test fixes

* more test fixes

* test fixes

* upgrade tests

* update tests

* upgrade tests

* upgrade tests

* upgrade tests

* upgrade tests

* update tests

* translate loader fixes

* auth and cookie fixes

* upgrade tests

* upgrade tests

* test fixes

* almost there

* diable broken tests

* process tests (part 1)

* fix lint issues

* another test upgrade

* almost there

* cleanup

* insights testing upgrade

* improve tests

* tests cleanup

* tests cleanup

* cleanup tests

* test cleanup

* favorite nodes tests

* rebase fix syntax

* fix core test

* give up test focus

* flush tabs

* fix search test

* Update document-list.component.spec.ts

* fix document list lock

* increase tick time

* remove duplicate test

lib/content-services/permission-manager/components/inherited-button.directive.spec.ts

@@ -18,7 +18,7 @@
 import { SimpleInheritedPermissionTestComponent } from '../../mock/inherited-permission.component.mock';
 import { async, ComponentFixture, TestBed } from '@angular/core/testing';
 import { PermissionManagerModule } from '../../index';
-import { NodesApiService } from '@alfresco/adf-core';
+import { NodesApiService, setupTestBed, CoreModule } from '@alfresco/adf-core';
 import { Observable } from 'rxjs/Observable';
 
 const fakeNodeWithInherit: any = { id: 'fake-id', permissions : {isInheritanceEnabled : true}};
@@ -31,26 +31,22 @@ describe('InheritPermissionDirective', () => {
     let component: SimpleInheritedPermissionTestComponent;
     let nodeService: NodesApiService;
 
-    beforeEach(async(() => {
-        TestBed.configureTestingModule({
-            imports: [
-                PermissionManagerModule
-            ],
-            declarations: [
-                SimpleInheritedPermissionTestComponent
-            ]
-        }).compileComponents().then(() => {
-            fixture = TestBed.createComponent(SimpleInheritedPermissionTestComponent);
-            component = fixture.componentInstance;
-            element = fixture.nativeElement;
-            nodeService = TestBed.get(NodesApiService);
-        });
-    }));
+    setupTestBed({
+        imports: [
+            CoreModule.forRoot(),
+            PermissionManagerModule
+        ],
+        declarations: [
+            SimpleInheritedPermissionTestComponent
+        ]
+    });
 
-    afterEach(async(() => {
-        fixture.destroy();
-        TestBed.resetTestingModule();
-    }));
+    beforeEach(() => {
+        fixture = TestBed.createComponent(SimpleInheritedPermissionTestComponent);
+        component = fixture.componentInstance;
+        element = fixture.nativeElement;
+        nodeService = TestBed.get(NodesApiService);
+    });
 
     it('should be able to render the simple component', async(() => {
         fixture.detectChanges();

lib/content-services/permission-manager/components/permission-list/permission-list.component.spec.ts

@@ -18,7 +18,7 @@
 import { async, ComponentFixture, TestBed } from '@angular/core/testing';
 import { PermissionListComponent } from './permission-list.component';
 import { By } from '@angular/platform-browser';
-import { NodesApiService, SearchService } from '@alfresco/adf-core';
+import { NodesApiService, SearchService, setupTestBed } from '@alfresco/adf-core';
 import { Observable } from 'rxjs/Observable';
 import { NodePermissionService } from '../../services/node-permission.service';
 import { fakeNodeWithPermissions,
@@ -28,6 +28,7 @@ import { fakeNodeWithPermissions,
          fakeSiteRoles,
          fakeNodeWithoutPermissions,
          fakeEmptyResponse } from '../../../mock/permission-list.component.mock';
+import { ContentTestingModule } from '../../../testing/content.testing.module';
 
 describe('PermissionDisplayComponent', () => {
 
@@ -38,28 +39,26 @@ describe('PermissionDisplayComponent', () => {
     let nodePermissionService: NodePermissionService;
     let searchApiService: SearchService;
 
-    beforeEach(async(() => {
-        TestBed.configureTestingModule({
-            declarations: [
-                PermissionListComponent
-            ],
-            providers: [NodePermissionService]
-        }).compileComponents().then(() => {
-            fixture = TestBed.createComponent(PermissionListComponent);
-            component = fixture.componentInstance;
-            element = fixture.nativeElement;
-            nodeService = TestBed.get(NodesApiService);
-            nodePermissionService = TestBed.get(NodePermissionService);
-            searchApiService = TestBed.get(SearchService);
-        });
-    }));
+    setupTestBed({
+        imports: [ContentTestingModule]
+    });
 
-    afterEach(async(() => {
+    beforeEach(() => {
+        fixture = TestBed.createComponent(PermissionListComponent);
+        component = fixture.componentInstance;
+        element = fixture.nativeElement;
+        nodeService = TestBed.get(NodesApiService);
+        nodePermissionService = TestBed.get(NodePermissionService);
+        searchApiService = TestBed.get(SearchService);
+    });
+
+    afterEach(() => {
         fixture.destroy();
-        TestBed.resetTestingModule();
-    }));
+    });
 
     it('should be able to render the component', () => {
+        spyOn(nodeService, 'getNode').and.returnValue(Observable.of(fakeNodeWithOnlyLocally));
+        spyOn(nodePermissionService, 'getNodeRoles').and.returnValue(Observable.of([]));
         fixture.detectChanges();
         expect(element.querySelector('#adf-permission-display-container')).not.toBeNull();
     });