unit test performance (#3194)

* DataTable (-4 sec) * PaginationComponent (-1 sec) * DocumentList * custom testbed setup, test upgrades * test fixes * more test fixes * remove fdescribe * test fixes * test fixes * more test fixes * test fixes * upgrade tests * update tests * upgrade tests * upgrade tests * upgrade tests * upgrade tests * update tests * translate loader fixes * auth and cookie fixes * upgrade tests * upgrade tests * test fixes * almost there * diable broken tests * process tests (part 1) * fix lint issues * another test upgrade * almost there * cleanup * insights testing upgrade * improve tests * tests cleanup * tests cleanup * cleanup tests * test cleanup * favorite nodes tests * rebase fix syntax * fix core test * give up test focus * flush tabs * fix search test * Update document-list.component.spec.ts * fix document list lock * increase tick time * remove duplicate test
2025-07-24 17:32:15 +00:00 · 2018-04-23 09:55:22 +01:00
parent 9fbfcfa96e
commit 382ea3c1b3
204 changed files with 3093 additions and 4389 deletions
--- a/lib/content-services/upload/components/file-uploading-dialog.component.spec.ts
+++ b/lib/content-services/upload/components/file-uploading-dialog.component.spec.ts
@@ -16,10 +16,11 @@
 */

 import { EventEmitter } from '@angular/core';
-import { async, ComponentFixture, TestBed } from '@angular/core/testing';
-import { FileModel, FileUploadCompleteEvent, FileUploadErrorEvent, UploadService } from '@alfresco/adf-core';
+import { ComponentFixture, TestBed } from '@angular/core/testing';
+import { FileModel, FileUploadCompleteEvent, FileUploadErrorEvent, UploadService, setupTestBed, CoreModule, AlfrescoApiService, AlfrescoApiServiceMock } from '@alfresco/adf-core';
 import { UploadModule } from '../upload.module';
 import { FileUploadingDialogComponent } from './file-uploading-dialog.component';
+import { NoopAnimationsModule } from '@angular/platform-browser/animations';

 describe('FileUploadingDialogComponent', () => {
    let fixture: ComponentFixture<FileUploadingDialogComponent>;
@@ -28,18 +29,24 @@ describe('FileUploadingDialogComponent', () => {
    let emitter: EventEmitter<any>;
    let filelist: FileModel[];

-    beforeEach(async(() => {
-        TestBed.configureTestingModule({
-            imports: [
-                UploadModule
-            ]
-        }).compileComponents();
-    }));
+    setupTestBed({
+        imports: [
+            NoopAnimationsModule,
+            CoreModule.forRoot(),
+            UploadModule
+        ],
+        providers: [
+            { provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock }
+        ]
+    });

    beforeEach(() => {
        fixture = TestBed.createComponent(FileUploadingDialogComponent);
        component = fixture.componentInstance;
+
        uploadService = TestBed.get(UploadService);
+        uploadService.clearQueue();
+
        emitter = new EventEmitter();
        filelist = [
            new FileModel(<File> { name: 'fake-name', size: 10 }),
@@ -49,11 +56,6 @@ describe('FileUploadingDialogComponent', () => {
        fixture.detectChanges();
    });

-    afterEach(() => {
-        fixture.destroy();
-        TestBed.resetTestingModule();
-    });
-
    describe('upload service subscribers', () => {
        it('should not render dialog when uploading list is empty', () => {
            uploadService.addToQueue();
@@ -150,7 +152,7 @@ describe('FileUploadingDialogComponent', () => {
    });

    describe('toggleMinimized()', () => {
-        it('should minimze the dialog', () => {
+        it('should minimize the dialog', () => {
            component.isDialogMinimized = true;
            component.toggleMinimized();

--- a/lib/content-services/upload/components/file-uploading-list.component.spec.ts
+++ b/lib/content-services/upload/components/file-uploading-list.component.spec.ts
@@ -16,10 +16,13 @@
 */

 import { ComponentFixture, TestBed } from '@angular/core/testing';
-import { TranslationService, FileUploadStatus, NodesApiService, UploadService } from '@alfresco/adf-core';
+import { TranslationService, FileUploadStatus, NodesApiService, UploadService,
+    setupTestBed, CoreModule, AlfrescoApiService, AlfrescoApiServiceMock
+} from '@alfresco/adf-core';
 import { Observable } from 'rxjs/Observable';
 import { UploadModule } from '../upload.module';
 import { FileUploadingListComponent } from './file-uploading-list.component';
+import { NoopAnimationsModule } from '@angular/platform-browser/animations';

 describe('FileUploadingListComponent', () => {
    let fixture: ComponentFixture<FileUploadingListComponent>;
@@ -33,17 +36,23 @@ describe('FileUploadingListComponent', () => {
        file = { data: { entry: { id: 'x' } } };
    });

-    beforeEach(() => {
-        TestBed.configureTestingModule({
-            imports: [
-                UploadModule
-            ]
-        }).compileComponents();
+    setupTestBed({
+        imports: [
+            NoopAnimationsModule,
+            CoreModule.forRoot(),
+            UploadModule
+        ],
+        providers: [
+            { provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock }
+        ]
    });

    beforeEach(() => {
        nodesApiService = TestBed.get(NodesApiService);
+
        uploadService = TestBed.get(UploadService);
+        uploadService.clearQueue();
+
        translateService = TestBed.get(TranslationService);
        fixture = TestBed.createComponent(FileUploadingListComponent);
        component = fixture.componentInstance;
--- a/lib/content-services/upload/components/upload-button.component.spec.ts
+++ b/lib/content-services/upload/components/upload-button.component.spec.ts
@@ -16,11 +16,12 @@
 */

 import { SimpleChange } from '@angular/core';
-import { async, ComponentFixture, TestBed } from '@angular/core/testing';
-import { ContentService, UploadService, TranslationService } from '@alfresco/adf-core';
+import { ComponentFixture, TestBed } from '@angular/core/testing';
+import { ContentService, UploadService, TranslationService, setupTestBed, CoreModule } from '@alfresco/adf-core';
 import { Observable } from 'rxjs/Observable';
 import { UploadButtonComponent } from './upload-button.component';
 import { TranslationMock } from '@alfresco/adf-core';
+import { NoopAnimationsModule } from '@angular/platform-browser/animations';

 describe('UploadButtonComponent', () => {

@@ -49,18 +50,20 @@ describe('UploadButtonComponent', () => {
    let uploadService: UploadService;
    let contentService: ContentService;

-    beforeEach(async(() => {
-        TestBed.configureTestingModule({
-            declarations: [
-                UploadButtonComponent
-            ],
-            providers: [
-                UploadService,
-                ContentService,
-                { provide: TranslationService, useClass: TranslationMock }
-            ]
-        }).compileComponents();
-    }));
+    setupTestBed({
+        imports: [
+            NoopAnimationsModule,
+            CoreModule.forRoot()
+        ],
+        declarations: [
+            UploadButtonComponent
+        ],
+        providers: [
+            UploadService,
+            ContentService,
+            { provide: TranslationService, useClass: TranslationMock }
+        ]
+    });

    beforeEach(() => {
        fixture = TestBed.createComponent(UploadButtonComponent);
--- a/lib/content-services/upload/components/upload-drag-area.component.spec.ts
+++ b/lib/content-services/upload/components/upload-drag-area.component.spec.ts
@@ -16,7 +16,7 @@
 */

 import { async, ComponentFixture, TestBed } from '@angular/core/testing';
-import { FileModel, UploadService } from '@alfresco/adf-core';
+import { FileModel, UploadService, setupTestBed, CoreModule } from '@alfresco/adf-core';

 import { FileDraggableDirective } from '../directives/file-draggable.directive';
 import { UploadDragAreaComponent } from './upload-drag-area.component';
@@ -61,17 +61,18 @@ describe('UploadDragAreaComponent', () => {
    let fixture: ComponentFixture<UploadDragAreaComponent>;
    let uploadService: UploadService;

-    beforeEach(async(() => {
-        TestBed.configureTestingModule({
-            declarations: [
-                FileDraggableDirective,
-                UploadDragAreaComponent
-            ],
-            providers: [
-                UploadService
-            ]
-        }).compileComponents();
-    }));
+    setupTestBed({
+        imports: [
+            CoreModule.forRoot()
+        ],
+        declarations: [
+            FileDraggableDirective,
+            UploadDragAreaComponent
+        ],
+        providers: [
+            UploadService
+        ]
+    });

    beforeEach(() => {
        fixture = TestBed.createComponent(UploadDragAreaComponent);
@@ -83,7 +84,6 @@ describe('UploadDragAreaComponent', () => {

    afterEach(() => {
        fixture.destroy();
-        TestBed.resetTestingModule();
    });

    describe('When disabled', () => {
@@ -185,7 +185,7 @@ describe('UploadDragAreaComponent', () => {

        it('should upload the list of files dropped', async(() => {
            component.success = null;
-            uploadService.uploadFilesInTheQueue = jasmine.createSpy('uploadFilesInTheQueue');
+            spyOn(uploadService, 'uploadFilesInTheQueue');
            fixture.detectChanges();
            const file = <File> { name: 'fake-name-1', size: 10, webkitRelativePath: 'fake-folder1/fake-name-1.json' };
            let filesList = [file];