unit test performance (#3194)

* DataTable (-4 sec)

* PaginationComponent (-1 sec)

* DocumentList

* custom testbed setup, test upgrades

* test fixes

* more test fixes

* remove fdescribe

* test fixes

* test fixes

* more test fixes

* test fixes

* upgrade tests

* update tests

* upgrade tests

* upgrade tests

* upgrade tests

* upgrade tests

* update tests

* translate loader fixes

* auth and cookie fixes

* upgrade tests

* upgrade tests

* test fixes

* almost there

* diable broken tests

* process tests (part 1)

* fix lint issues

* another test upgrade

* almost there

* cleanup

* insights testing upgrade

* improve tests

* tests cleanup

* tests cleanup

* cleanup tests

* test cleanup

* favorite nodes tests

* rebase fix syntax

* fix core test

* give up test focus

* flush tabs

* fix search test

* Update document-list.component.spec.ts

* fix document list lock

* increase tick time

* remove duplicate test

lib/core/card-view/components/card-view-boolitem/card-view-boolitem.component.spec.ts

@@ -15,47 +15,23 @@
  * limitations under the License.
  */
 
-import { HttpClientModule } from '@angular/common/http';
 import { async, ComponentFixture, TestBed } from '@angular/core/testing';
-import { FormsModule } from '@angular/forms';
-import { MaterialModule } from '../../../material.module';
-import { MatCheckboxChange, MatCheckbox } from '@angular/material';
 import { By } from '@angular/platform-browser';
-import { NoopAnimationsModule } from '@angular/platform-browser/animations';
-import { TranslateLoader, TranslateModule } from '@ngx-translate/core';
+import { MatCheckbox, MatCheckboxChange } from '@angular/material';
+import { setupTestBed } from '../../../testing/setupTestBed';
 import { CardViewUpdateService } from '../../services/card-view-update.service';
-import { TranslateLoaderService } from '../../../services/translate-loader.service';
-
 import { CardViewBoolItemComponent } from './card-view-boolitem.component';
 import { CardViewBoolItemModel } from '../../models/card-view-boolitem.model';
+import { CoreTestingModule } from '../../../testing/core.testing.module';
 
 describe('CardViewBoolItemComponent', () => {
 
     let fixture: ComponentFixture<CardViewBoolItemComponent>;
     let component: CardViewBoolItemComponent;
 
-    beforeEach(async(() => {
-        TestBed.configureTestingModule({
-            imports: [
-                HttpClientModule,
-                FormsModule,
-                NoopAnimationsModule,
-                MaterialModule,
-                TranslateModule.forRoot({
-                    loader: {
-                        provide: TranslateLoader,
-                        useClass: TranslateLoaderService
-                    }
-                })
-            ],
-            declarations: [
-                CardViewBoolItemComponent
-            ],
-            providers: [
-                CardViewUpdateService
-            ]
-        }).compileComponents();
-    }));
+    setupTestBed({
+        imports: [CoreTestingModule]
+    });
 
     beforeEach(() => {
         fixture = TestBed.createComponent(CardViewBoolItemComponent);
@@ -71,7 +47,6 @@ describe('CardViewBoolItemComponent', () => {
 
     afterEach(() => {
         fixture.destroy();
-        TestBed.resetTestingModule();
     });
 
     describe('Rendering', () => {
@@ -115,7 +90,7 @@ describe('CardViewBoolItemComponent', () => {
             expect(value).not.toBeNull();
         });
 
-        it('should render ticked checkbox if property\'s value is true', () => {
+        it('should render ticked checkbox if property value is true', () => {
             component.property.value = true;
             fixture.detectChanges();
 
@@ -124,7 +99,7 @@ describe('CardViewBoolItemComponent', () => {
             expect(value.nativeElement.checked).toBe(true);
         });
 
-        it('should render ticked checkbox if property\'s value is not set but default is true and editable', () => {
+        it('should render ticked checkbox if property value is not set but default is true and editable', () => {
             component.editable = true;
             component.property.editable = true;
             component.property.value = undefined;
@@ -136,7 +111,7 @@ describe('CardViewBoolItemComponent', () => {
             expect(value.nativeElement.checked).toBe(true);
         });
 
-        it('should render unticked checkbox if property\'s value is false', () => {
+        it('should render unticked checkbox if property value is false', () => {
             component.property.value = false;
             fixture.detectChanges();
 
@@ -145,7 +120,7 @@ describe('CardViewBoolItemComponent', () => {
             expect(value.nativeElement.checked).toBe(false);
         });
 
-        it('should render unticked checkbox if property\'s value is not set but default is false and editable', () => {
+        it('should render unticked checkbox if property value is not set but default is false and editable', () => {
             component.editable = true;
             component.property.editable = true;
             component.property.value = undefined;
@@ -209,7 +184,7 @@ describe('CardViewBoolItemComponent', () => {
             expect(cardViewUpdateService.update).toHaveBeenCalledWith(component.property, true);
         });
 
-        it('should update the propery\'s value after a changed', async(() => {
+        it('should update the property value after a changed', async(() => {
             component.property.value = true;
 
             component.changed(<MatCheckboxChange> {checked: false});

lib/core/card-view/components/card-view-dateitem/card-view-dateitem.component.spec.ts

@@ -15,48 +15,23 @@
  * limitations under the License.
  */
 
-import { HttpClientModule } from '@angular/common/http';
 import { async, ComponentFixture, TestBed } from '@angular/core/testing';
-import { MatDatepickerModule, MatInputModule, MatNativeDateModule } from '@angular/material';
-import { MatDatetimepickerModule, MatNativeDatetimeModule } from '@mat-datetimepicker/core';
 import { By } from '@angular/platform-browser';
-import { TranslateLoader, TranslateModule } from '@ngx-translate/core';
+import { setupTestBed } from '../../../testing/setupTestBed';
 import moment from 'moment-es6';
 import { CardViewDateItemModel } from '../../models/card-view-dateitem.model';
 import { CardViewUpdateService } from '../../services/card-view-update.service';
-import { TranslateLoaderService } from '../../../services/translate-loader.service';
-
 import { CardViewDateItemComponent } from './card-view-dateitem.component';
+import { CoreTestingModule } from '../../../testing/core.testing.module';
 
 describe('CardViewDateItemComponent', () => {
 
     let fixture: ComponentFixture<CardViewDateItemComponent>;
     let component: CardViewDateItemComponent;
 
-    beforeEach(async(() => {
-        TestBed.configureTestingModule({
-            imports: [
-                HttpClientModule,
-                MatDatepickerModule,
-                MatInputModule,
-                MatNativeDateModule,
-                MatNativeDatetimeModule,
-                MatDatetimepickerModule,
-                TranslateModule.forRoot({
-                    loader: {
-                        provide: TranslateLoader,
-                        useClass: TranslateLoaderService
-                    }
-                })
-            ],
-            declarations: [
-                CardViewDateItemComponent
-            ],
-            providers: [
-                CardViewUpdateService
-            ]
-        }).compileComponents();
-    }));
+    setupTestBed({
+        imports: [CoreTestingModule]
+    });
 
     beforeEach(() => {
         fixture = TestBed.createComponent(CardViewDateItemComponent);
@@ -73,7 +48,6 @@ describe('CardViewDateItemComponent', () => {
 
     afterEach(() => {
         fixture.destroy();
-        TestBed.resetTestingModule();
     });
 
     it('should render the label and value', () => {

lib/core/card-view/components/card-view-mapitem/card-view-mapitem.component.spec.ts

@@ -15,19 +15,14 @@
  * limitations under the License.
  */
 
-import { HttpClientModule } from '@angular/common/http';
 import { DebugElement } from '@angular/core';
-import { async, ComponentFixture, TestBed } from '@angular/core/testing';
-import { FormsModule } from '@angular/forms';
-import { MaterialModule } from '../../../material.module';
+import { ComponentFixture, TestBed } from '@angular/core/testing';
 import { By } from '@angular/platform-browser';
-import { NoopAnimationsModule } from '@angular/platform-browser/animations';
-import { TranslateLoader, TranslateModule } from '@ngx-translate/core';
 import { CardViewMapItemModel } from '../../models/card-view-mapitem.model';
 import { CardViewUpdateService } from '../../services/card-view-update.service';
-import { TranslateLoaderService } from '../../../services/translate-loader.service';
-
 import { CardViewMapItemComponent } from './card-view-mapitem.component';
+import { setupTestBed } from '../../../testing/setupTestBed';
+import { CoreTestingModule } from '../../../testing/core.testing.module';
 
 describe('CardViewMapItemComponent', () => {
     let service: CardViewUpdateService;
@@ -37,28 +32,9 @@ describe('CardViewMapItemComponent', () => {
     let debug: DebugElement;
     let element: HTMLElement;
 
-    beforeEach(async(() => {
-        TestBed.configureTestingModule({
-            imports: [
-                HttpClientModule,
-                FormsModule,
-                NoopAnimationsModule,
-                MaterialModule,
-                TranslateModule.forRoot({
-                    loader: {
-                        provide: TranslateLoader,
-                        useClass: TranslateLoaderService
-                    }
-                })
-            ],
-            declarations: [
-                CardViewMapItemComponent
-            ],
-            providers: [
-                CardViewUpdateService
-            ]
-        }).compileComponents();
-    }));
+    setupTestBed({
+        imports: [CoreTestingModule]
+    });
 
     beforeEach(() => {
         fixture = TestBed.createComponent(CardViewMapItemComponent);
@@ -70,7 +46,6 @@ describe('CardViewMapItemComponent', () => {
 
     afterEach(() => {
         fixture.destroy();
-        TestBed.resetTestingModule();
     });
 
     it('should render the default if the value is empty and displayEmpty is true', () => {

lib/core/card-view/components/card-view-textitem/card-view-textitem.component.spec.ts

@@ -15,49 +15,22 @@
  * limitations under the License.
  */
 
-import { HttpClientModule } from '@angular/common/http';
 import { async, ComponentFixture, TestBed } from '@angular/core/testing';
-import { FormsModule } from '@angular/forms';
-import { MatDatepickerModule, MatIconModule, MatInputModule, MatNativeDateModule } from '@angular/material';
 import { By } from '@angular/platform-browser';
-import { NoopAnimationsModule } from '@angular/platform-browser/animations';
-import { TranslateLoader, TranslateModule } from '@ngx-translate/core';
 import { CardViewTextItemModel } from '../../models/card-view-textitem.model';
 import { CardViewUpdateService } from '../../services/card-view-update.service';
-import { TranslateLoaderService } from '../../../services/translate-loader.service';
-
 import { CardViewTextItemComponent } from './card-view-textitem.component';
+import { setupTestBed } from '../../../testing/setupTestBed';
+import { CoreTestingModule } from '../../../testing/core.testing.module';
 
 describe('CardViewTextItemComponent', () => {
 
     let fixture: ComponentFixture<CardViewTextItemComponent>;
     let component: CardViewTextItemComponent;
 
-    beforeEach(async(() => {
-        TestBed.configureTestingModule({
-            imports: [
-                HttpClientModule,
-                FormsModule,
-                NoopAnimationsModule,
-                MatDatepickerModule,
-                MatIconModule,
-                MatInputModule,
-                MatNativeDateModule,
-                TranslateModule.forRoot({
-                    loader: {
-                        provide: TranslateLoader,
-                        useClass: TranslateLoaderService
-                    }
-                })
-            ],
-            declarations: [
-                CardViewTextItemComponent
-            ],
-            providers: [
-                CardViewUpdateService
-            ]
-        }).compileComponents();
-    }));
+    setupTestBed({
+        imports: [CoreTestingModule]
+    });
 
     beforeEach(() => {
         fixture = TestBed.createComponent(CardViewTextItemComponent);
@@ -73,7 +46,6 @@ describe('CardViewTextItemComponent', () => {
 
     afterEach(() => {
         fixture.destroy();
-        TestBed.resetTestingModule();
     });
 
     describe('Rendering', () => {

lib/core/card-view/components/card-view/card-view.component.spec.ts

@@ -16,78 +16,31 @@
  */
 
 import { async, ComponentFixture, TestBed } from '@angular/core/testing';
-
-import { HttpClientModule } from '@angular/common/http';
-import { FormsModule } from '@angular/forms';
-import { MatDatepickerModule, MatIconModule, MatInputModule, MatNativeDateModule } from '@angular/material';
-import { MatDatetimepickerModule, MatNativeDatetimeModule } from '@mat-datetimepicker/core';
 import { By } from '@angular/platform-browser';
-import { BrowserDynamicTestingModule } from '@angular/platform-browser-dynamic/testing';
-
-import { TranslateLoader, TranslateModule } from '@ngx-translate/core';
-
+import { setupTestBed } from '../../../testing/setupTestBed';
 import { CardViewDateItemModel } from '../../models/card-view-dateitem.model';
 import { CardViewTextItemModel } from '../../models/card-view-textitem.model';
-import { CardViewUpdateService } from '../../services/card-view-update.service';
-
-import { TranslateLoaderService } from '../../../services/translate-loader.service';
-import { CardViewContentProxyDirective } from '../../directives/card-view-content-proxy.directive';
-import { CardViewDateItemComponent } from '../card-view-dateitem/card-view-dateitem.component';
-import { CardItemTypeService } from '../../services/card-item-types.service';
-import { CardViewItemDispatcherComponent } from '../card-view-item-dispatcher/card-view-item-dispatcher.component';
-import { CardViewTextItemComponent } from '../card-view-textitem/card-view-textitem.component';
 import { CardViewComponent } from './card-view.component';
+import { CoreTestingModule } from '../../../testing/core.testing.module';
 
 describe('CardViewComponent', () => {
 
     let fixture: ComponentFixture<CardViewComponent>;
     let component: CardViewComponent;
 
-    beforeEach(async(() => {
-        TestBed.configureTestingModule({
-            imports: [
-                HttpClientModule,
-                MatDatepickerModule,
-                MatIconModule,
-                MatInputModule,
-                MatNativeDateModule,
-                MatDatetimepickerModule,
-                MatNativeDatetimeModule,
-                FormsModule,
-                TranslateModule.forRoot({
-                    loader: {
-                        provide: TranslateLoader,
-                        useClass: TranslateLoaderService
-                    }
-                })
-            ],
-            declarations: [
-                CardViewComponent,
-                CardViewItemDispatcherComponent,
-                CardViewContentProxyDirective,
-                CardViewTextItemComponent,
-                CardViewDateItemComponent
-            ],
-            providers: [
-                CardItemTypeService,
-                CardViewUpdateService
-            ]
-        });
-
-        // entryComponents are not supported yet on TestBed, that is why this ugly workaround:
-        // https://github.com/angular/angular/issues/10760
-        TestBed.overrideModule(BrowserDynamicTestingModule, {
-            set: { entryComponents: [ CardViewTextItemComponent, CardViewDateItemComponent ] }
-        });
-
-        TestBed.compileComponents();
-    }));
+    setupTestBed({
+        imports: [CoreTestingModule]
+    });
 
     beforeEach(() => {
         fixture = TestBed.createComponent(CardViewComponent);
         component = fixture.componentInstance;
     });
 
+    afterEach(() => {
+        fixture.destroy();
+    });
+
     it('should render the label and value', async(() => {
         component.properties = [new CardViewTextItemModel({label: 'My label', value: 'My value', key: 'some key'})];
         fixture.detectChanges();