unit test performance (#3194)

* DataTable (-4 sec)

* PaginationComponent (-1 sec)

* DocumentList

* custom testbed setup, test upgrades

* test fixes

* more test fixes

* remove fdescribe

* test fixes

* test fixes

* more test fixes

* test fixes

* upgrade tests

* update tests

* upgrade tests

* upgrade tests

* upgrade tests

* upgrade tests

* update tests

* translate loader fixes

* auth and cookie fixes

* upgrade tests

* upgrade tests

* test fixes

* almost there

* diable broken tests

* process tests (part 1)

* fix lint issues

* another test upgrade

* almost there

* cleanup

* insights testing upgrade

* improve tests

* tests cleanup

* tests cleanup

* cleanup tests

* test cleanup

* favorite nodes tests

* rebase fix syntax

* fix core test

* give up test focus

* flush tabs

* fix search test

* Update document-list.component.spec.ts

* fix document list lock

* increase tick time

* remove duplicate test

lib/core/comments/comment-list.component.spec.ts

@@ -16,13 +16,14 @@
  */
 
 import { CUSTOM_ELEMENTS_SCHEMA } from '@angular/core';
-import { DatePipe } from '@angular/common';
 import { async, ComponentFixture, TestBed } from '@angular/core/testing';
 import { CommentModel, UserProcessModel } from '../models';
 import { CommentListComponent } from './comment-list.component';
 import { By } from '@angular/platform-browser';
 import { EcmUserService } from '../userinfo/services/ecm-user.service';
 import { PeopleProcessService } from '../services/people-process.service';
+import { setupTestBed } from '../testing/setupTestBed';
+import { CoreTestingModule } from '../testing/core.testing.module';
 
 const testUser: UserProcessModel = new UserProcessModel({
     id: '1',
@@ -109,31 +110,26 @@ describe('CommentListComponent', () => {
     let ecmUserService: EcmUserService;
     let peopleProcessService: PeopleProcessService;
 
-    beforeEach(async(() => {
-        TestBed.configureTestingModule({
-            declarations: [
-                CommentListComponent
-            ],
-            schemas: [CUSTOM_ELEMENTS_SCHEMA],
-            providers: [
-                DatePipe,
-                PeopleProcessService,
-                EcmUserService
-            ]
-        }).compileComponents().then(() => {
+    setupTestBed({
+        imports: [CoreTestingModule],
+        schemas: [CUSTOM_ELEMENTS_SCHEMA]
+    });
 
-            fixture = TestBed.createComponent(CommentListComponent);
-            ecmUserService = TestBed.get(EcmUserService);
-            peopleProcessService = TestBed.get(PeopleProcessService);
-            commentList = fixture.componentInstance;
-            element = fixture.nativeElement;
-            fixture.detectChanges();
-        });
+    beforeEach(async(() => {
+        ecmUserService = TestBed.get(EcmUserService);
+        spyOn(ecmUserService, 'getUserProfileImage').and.returnValue('content-user-image');
+
+        peopleProcessService = TestBed.get(PeopleProcessService);
+        spyOn(peopleProcessService, 'getUserImage').and.returnValue('process-user-image');
+
+        fixture = TestBed.createComponent(CommentListComponent);
+        commentList = fixture.componentInstance;
+        element = fixture.nativeElement;
+        fixture.detectChanges();
     }));
 
-    beforeEach(() => {
-        spyOn(ecmUserService, 'getUserProfileImage').and.returnValue('content-user-image');
-        spyOn(peopleProcessService, 'getUserImage').and.returnValue('process-user-image');
+    afterEach(() => {
+        fixture.destroy();
     });
 
     it('should emit row click event', async(() => {

lib/core/comments/comments.component.spec.ts

@@ -20,12 +20,10 @@ import { SimpleChange } from '@angular/core';
 import { async, ComponentFixture, TestBed } from '@angular/core/testing';
 import { Observable } from 'rxjs/Observable';
 import { CommentProcessService } from '../services/comment-process.service';
-import { DatePipe } from '@angular/common';
-import { PeopleProcessService } from '../services/people-process.service';
-import { CommentListComponent } from './comment-list.component';
 import { CommentsComponent } from './comments.component';
 import { CommentContentService } from '../services/comment-content.service';
-import { EcmUserService } from '../userinfo/services/ecm-user.service';
+import { setupTestBed } from '../testing/setupTestBed';
+import { CoreTestingModule } from '../testing/core.testing.module';
 
 describe('CommentsComponent', () => {
 
@@ -38,25 +36,10 @@ describe('CommentsComponent', () => {
     let commentProcessService: CommentProcessService;
     let commentContentService: CommentContentService;
 
-    beforeEach(async(() => {
-        TestBed.configureTestingModule({
-            imports: [
-            ],
-            declarations: [
-                CommentsComponent,
-                CommentListComponent
-            ],
-            schemas: [CUSTOM_ELEMENTS_SCHEMA],
-            providers: [
-                DatePipe,
-                PeopleProcessService,
-                CommentProcessService,
-                CommentContentService,
-                EcmUserService
-            ]
-        }).compileComponents();
-
-    }));
+    setupTestBed({
+        imports: [CoreTestingModule],
+        schemas: [CUSTOM_ELEMENTS_SCHEMA]
+    });
 
     beforeEach(() => {
         fixture = TestBed.createComponent(CommentsComponent);
@@ -87,7 +70,10 @@ describe('CommentsComponent', () => {
             message: 'Test Comment',
             createdBy: {id: '999'}
         }));
+    });
 
+    afterEach(() => {
+        fixture.destroy();
     });
 
     it('should load comments when taskId specified', () => {