From 38f29738638ef635e082111a498af9b9489feb95 Mon Sep 17 00:00:00 2001
From: Denys Vuika <denys.vuika@gmail.com>
Date: Fri, 6 Apr 2018 12:47:19 +0100
Subject: [PATCH] tooltip and i18n fixes (#3147)

* tooltip fixes

* i18n for info drawer strings
---
 demo-shell/resources/i18n/en.json                         | 8 ++++++++
 .../src/app/components/file-view/file-view.component.html | 8 ++++----
 .../content-metadata-card.component.html                  | 6 +++++-
 .../card-view-boolitem/card-view-boolitem.component.html  | 1 +
 .../card-view-dateitem/card-view-dateitem.component.html  | 1 +
 .../card-view-textitem/card-view-textitem.component.html  | 7 ++++++-
 lib/core/i18n/en.json                                     | 6 ++++++
 7 files changed, 31 insertions(+), 6 deletions(-)

diff --git a/demo-shell/resources/i18n/en.json b/demo-shell/resources/i18n/en.json
index 986ce84307..b09db9a03d 100644
--- a/demo-shell/resources/i18n/en.json
+++ b/demo-shell/resources/i18n/en.json
@@ -1,4 +1,12 @@
 {
+  "APP": {
+    "INFO_DRAWER": {
+      "TITLE": "Details",
+      "COMMENTS": "Comments",
+      "PROPERTIES": "Properties",
+      "VERSIONS": "Versions"
+    }
+  },
     "title": "Welcome",
     "VERSION": {
       "NO_PERMISSION": "You don't have permission to manage versions of this content",
diff --git a/demo-shell/src/app/components/file-view/file-view.component.html b/demo-shell/src/app/components/file-view/file-view.component.html
index 90875b7965..9b258811ef 100644
--- a/demo-shell/src/app/components/file-view/file-view.component.html
+++ b/demo-shell/src/app/components/file-view/file-view.component.html
@@ -1,16 +1,16 @@
 <ng-container *ngIf="nodeId">
 
     <ng-template let-node="node" #sidebarTemplate>
-        <adf-info-drawer title="Details">
-            <adf-info-drawer-tab label="Comments">
+        <adf-info-drawer [title]="'APP.INFO_DRAWER.TITLE' | translate">
+            <adf-info-drawer-tab [label]="'APP.INFO_DRAWER.COMMENTS' | translate">
                 <adf-comments [nodeId]="nodeId"></adf-comments>
             </adf-info-drawer-tab>
 
-            <adf-info-drawer-tab label="Properties">
+            <adf-info-drawer-tab [label]="'APP.INFO_DRAWER.PROPERTIES' | translate">
                 <adf-content-metadata-card [node]="node"></adf-content-metadata-card>
             </adf-info-drawer-tab>
 
-            <adf-info-drawer-tab label="Versions">
+            <adf-info-drawer-tab [label]="'APP.INFO_DRAWER.VERSIONS' | translate">
                 <mat-card>
                     <mat-card-content>
                         <adf-version-manager [node]="node" (uploadError)="uploadError($event)">
diff --git a/lib/content-services/content-metadata/components/content-metadata-card/content-metadata-card.component.html b/lib/content-services/content-metadata/components/content-metadata-card/content-metadata-card.component.html
index d3d55c6fab..e9b6d8e92d 100644
--- a/lib/content-services/content-metadata/components/content-metadata-card/content-metadata-card.component.html
+++ b/lib/content-services/content-metadata/components/content-metadata-card/content-metadata-card.component.html
@@ -11,7 +11,11 @@
     </mat-card-content>
     <mat-card-footer class="adf-content-metadata-card-footer" fxLayout="row" fxLayoutAlign="space-between stretch">
         <div>
-            <button *ngIf="!readOnly" mat-icon-button (click)="toggleEdit()" data-automation-id="mata-data-card-toggle-edit">
+            <button *ngIf="!readOnly"
+                mat-icon-button
+                (click)="toggleEdit()"
+                [attr.title]="'CORE.METADATA.ACTIONS.EDIT' | translate"
+                data-automation-id="mata-data-card-toggle-edit">
                 <mat-icon>mode_edit</mat-icon>
             </button>
         </div>
diff --git a/lib/core/card-view/components/card-view-boolitem/card-view-boolitem.component.html b/lib/core/card-view/components/card-view-boolitem/card-view-boolitem.component.html
index 202f179844..d3024d959a 100644
--- a/lib/core/card-view/components/card-view-boolitem/card-view-boolitem.component.html
+++ b/lib/core/card-view/components/card-view-boolitem/card-view-boolitem.component.html
@@ -2,6 +2,7 @@
     <div class="adf-property-label">{{ property.label | translate }}</div>
     <div class="adf-property-value">
         <mat-checkbox
+            [attr.title]="'CORE.METADATA.ACTIONS.TOGGLE' | translate"
             [checked]="property.displayValue"
             [disabled]="!isEditable()"
             (change)="changed($event)">
diff --git a/lib/core/card-view/components/card-view-dateitem/card-view-dateitem.component.html b/lib/core/card-view/components/card-view-dateitem/card-view-dateitem.component.html
index d16f4bfb7e..b2c60bad5d 100644
--- a/lib/core/card-view/components/card-view-dateitem/card-view-dateitem.component.html
+++ b/lib/core/card-view/components/card-view-dateitem/card-view-dateitem.component.html
@@ -14,6 +14,7 @@
                 <span *ngIf="showProperty(); else elseEmptyValueBlock">{{ property.displayValue }}</span>
             </span>
             <mat-datetimepicker-toggle
+                [attr.title]="'CORE.METADATA.ACTIONS.EDIT' | translate"
                 [attr.data-automation-id]="'datepickertoggle-' + property.key"
                 [for]="datetimePicker">
             </mat-datetimepicker-toggle>
diff --git a/lib/core/card-view/components/card-view-textitem/card-view-textitem.component.html b/lib/core/card-view/components/card-view-textitem/card-view-textitem.component.html
index 9947abc706..e3ba8891a5 100644
--- a/lib/core/card-view/components/card-view-textitem/card-view-textitem.component.html
+++ b/lib/core/card-view/components/card-view-textitem/card-view-textitem.component.html
@@ -15,7 +15,10 @@
             <span [attr.data-automation-id]="'card-textitem-value-' + property.key">
                 <span *ngIf="showProperty(); else elseEmptyValueBlock">{{ property.displayValue }}</span>
             </span>
-            <mat-icon fxFlex="0 0 auto" [attr.data-automation-id]="'card-textitem-edit-icon-' + property.key" class="adf-textitem-icon">create</mat-icon>
+            <mat-icon fxFlex="0 0 auto"
+                [attr.data-automation-id]="'card-textitem-edit-icon-' + property.key"
+                [attr.title]="'CORE.METADATA.ACTIONS.EDIT' | translate"
+                class="adf-textitem-icon">create</mat-icon>
         </div>
         <div *ngIf="inEdit" class="adf-textitem-editable">
             <div class="adf-textitem-editable-controls">
@@ -39,10 +42,12 @@
                 <mat-icon
                     class="adf-textitem-icon adf-update-icon"
                     (click)="update()"
+                    [attr.title]="'CORE.METADATA.ACTIONS.SAVE' | translate"
                     [attr.data-automation-id]="'card-textitem-update-' + property.key">done</mat-icon>
                 <mat-icon
                     class="adf-textitem-icon adf-reset-icon"
                     (click)="reset()"
+                    [attr.title]="'CORE.METADATA.ACTIONS.CANCEL' | translate"
                     [attr.data-automation-id]="'card-textitem-reset-' + property.key">clear</mat-icon>
             </div>
             <mat-error class="adf-textitem-editable-error" *ngIf="hasErrors()">
diff --git a/lib/core/i18n/en.json b/lib/core/i18n/en.json
index 4faade3b67..9d90cda59d 100644
--- a/lib/core/i18n/en.json
+++ b/lib/core/i18n/en.json
@@ -140,6 +140,12 @@
           "CREATED_DATE": "Created Date",
           "MODIFIER": "Modifier",
           "MODIFIED_DATE": "Modified Date"
+      },
+      "ACTIONS": {
+        "EDIT": "Edit",
+        "SAVE": "Save",
+        "CANCEL": "Cancel",
+        "TOGGLE": "Toggle value"
       }
     }
   },