[ADF-2531] Fixes for production mode (#3121)

* fix dialog module

* fix social component providers

* content metadata module fixes

* remove empty provider sections

integration/base_ver_2_app/src/app/app.module.ts

@@ -79,7 +79,6 @@ const appRoutes: Routes = [
     DocumentlistComponent,
     StartProcessComponent
   ],
-  providers: [],
   bootstrap: [AppComponent]
 })
 export class AppModule { }

lib/content-services/content-metadata/components/content-metadata/content-metadata.component.ts

@@ -18,7 +18,7 @@
 import { Component, Input, OnChanges, OnInit, SimpleChanges, SimpleChange, ViewEncapsulation } from '@angular/core';
 import { MinimalNodeEntryEntity } from 'alfresco-js-api';
 import { Observable } from 'rxjs/Observable';
-import { CardViewItem, CardViewUpdateService, NodesApiService, LogService } from '@alfresco/adf-core';
+import { CardViewItem, NodesApiService, LogService, CardViewUpdateService } from '@alfresco/adf-core';
 import { ContentMetadataService } from '../../services/content-metadata.service';
 import { CardViewGroup } from '../../interfaces/content-metadata.interfaces';
 
@@ -27,8 +27,7 @@ import { CardViewGroup } from '../../interfaces/content-metadata.interfaces';
     templateUrl: './content-metadata.component.html',
     styleUrls: ['./content-metadata.component.scss'],
     host: { 'class': 'adf-content-metadata' },
-    encapsulation: ViewEncapsulation.None,
+    encapsulation: ViewEncapsulation.None
-    providers: [ CardViewUpdateService ]
 })
 export class ContentMetadataComponent implements OnChanges, OnInit {
 

lib/content-services/content-metadata/content-metadata.module.ts

@@ -23,11 +23,6 @@ import { MaterialModule } from '../material.module';
 import { CardViewModule } from '@alfresco/adf-core';
 import { ContentMetadataComponent } from './components/content-metadata/content-metadata.component';
 import { ContentMetadataCardComponent } from './components/content-metadata-card/content-metadata-card.component';
-import { PropertyDescriptorsService } from './services/property-descriptors.service';
-import { ContentMetadataConfigFactory } from './services/config/content-metadata-config.factory';
-import { BasicPropertiesService } from './services/basic-properties.service';
-import { ContentMetadataService } from './services/content-metadata.service';
-import { PropertyGroupTranslatorService } from './services/property-groups-translator.service';
 
 @NgModule({
     imports: [
@@ -44,13 +39,6 @@ import { PropertyGroupTranslatorService } from './services/property-groups-trans
     declarations: [
         ContentMetadataComponent,
         ContentMetadataCardComponent
-    ],
-    providers: [
-        ContentMetadataService,
-        PropertyDescriptorsService,
-        ContentMetadataConfigFactory,
-        BasicPropertiesService,
-        PropertyGroupTranslatorService
     ]
 })
 export class ContentMetadataModule {}

lib/content-services/content-metadata/public-api.ts

@@ -15,5 +15,12 @@
  * limitations under the License.
  */
 
-export * from './components/content-metadata-card/content-metadata-card.component';
+export { ContentMetadataCardComponent } from './components/content-metadata-card/content-metadata-card.component';
-export * from './services/content-metadata.service';
+export { BasicPropertiesService } from './services/basic-properties.service';
+export { ContentMetadataService } from './services/content-metadata.service';
+export { PropertyDescriptorsService } from './services/property-descriptors.service';
+export { PropertyGroupTranslatorService } from './services/property-groups-translator.service';
+export { AspectOrientedConfigService } from './services/config/aspect-oriented-config.service';
+export { ContentMetadataConfigFactory } from './services/config/content-metadata-config.factory';
+export { IndifferentConfigService } from './services/config/indifferent-config.service';
+export { LayoutOrientedConfigService } from './services/config/layout-oriented-config.service';

lib/content-services/content.module.ts

@@ -37,6 +37,12 @@ import { DialogModule } from './dialogs/dialog.module';
 import { FolderDirectiveModule } from './folder-directive/folder-directive.module';
 import { ContentMetadataModule } from './content-metadata/content-metadata.module';
 import { PermissionManagerModule } from './permission-manager/permission-manager.module';
+import { RatingService } from './social/services/rating.service';
+import { ContentMetadataService } from './content-metadata/services/content-metadata.service';
+import { PropertyDescriptorsService } from './content-metadata/services/property-descriptors.service';
+import { ContentMetadataConfigFactory } from './content-metadata/services/config/content-metadata-config.factory';
+import { BasicPropertiesService } from './content-metadata/services/basic-properties.service';
+import { PropertyGroupTranslatorService } from './content-metadata/services/property-groups-translator.service';
 
 @NgModule({
     imports: [
@@ -69,7 +75,13 @@ import { PermissionManagerModule } from './permission-manager/permission-manager
                 name: 'adf-content-services',
                 source: 'assets/adf-content-services'
             }
-        }
+        },
+        RatingService,
+        ContentMetadataService,
+        PropertyDescriptorsService,
+        ContentMetadataConfigFactory,
+        BasicPropertiesService,
+        PropertyGroupTranslatorService
     ],
     exports: [
         CoreModule,

lib/content-services/dialogs/dialog.module.ts

@@ -25,7 +25,6 @@ import { ShareDialogComponent } from './share.dialog';
 
 import { FormsModule, ReactiveFormsModule } from '@angular/forms';
 import { TranslateModule } from '@ngx-translate/core';
-import { NodesApiService, NotificationService, TranslationService } from '@alfresco/adf-core';
 
 @NgModule({
     imports: [
@@ -40,11 +39,6 @@ import { NodesApiService, NotificationService, TranslationService } from '@alfre
         FolderDialogComponent,
         ShareDialogComponent
     ],
-    providers: [
-        NodesApiService,
-        NotificationService,
-        TranslationService
-    ],
     exports: [
         DownloadZipDialogComponent,
         FolderDialogComponent,

lib/content-services/site-dropdown/sites-dropdown.module.ts

@@ -36,7 +36,6 @@ import { DropdownSitesComponent } from './sites-dropdown.component';
     ],
     declarations: [
         DropdownSitesComponent
-    ],
+    ]
-    providers: []
 })
 export class SitesDropdownModule {}

lib/content-services/social/like.component.ts

@@ -22,7 +22,6 @@ import { RatingService } from './services/rating.service';
     selector: 'adf-like',
     styleUrls: ['./like.component.scss'],
     templateUrl: './like.component.html',
-    providers: [RatingService],
     encapsulation: ViewEncapsulation.None
 })
 export class LikeComponent implements OnChanges {

lib/content-services/social/rating.component.ts

@@ -22,7 +22,6 @@ import { RatingService } from './services/rating.service';
     selector: 'adf-rating',
     styleUrls: ['./rating.component.scss'],
     templateUrl: './rating.component.html',
-    providers: [RatingService],
     encapsulation: ViewEncapsulation.None
 })
 export class RatingComponent implements OnChanges {

lib/content-services/social/social.module.ts

@@ -19,7 +19,6 @@ import { CommonModule } from '@angular/common';
 import { NgModule } from '@angular/core';
 import { MaterialModule } from '../material.module';
 
-import { RatingService } from './services/rating.service';
 import { LikeComponent } from './like.component';
 import { RatingComponent } from './rating.component';
 
@@ -35,9 +34,6 @@ import { RatingComponent } from './rating.component';
     declarations: [
         RatingComponent,
         LikeComponent
-    ],
-    providers: [
-        RatingService
     ]
 })
 export class SocialModule {}

lib/process-services/app-list/apps-list.module.ts

@@ -37,7 +37,6 @@ import { SelectAppsDialogComponent } from './select-apps-dialog-component';
         AppsListComponent,
         SelectAppsDialogComponent
     ],
-    providers: [],
     exports: [
         AppsListComponent,
         SelectAppsDialogComponent

lib/process-services/process-list/process-list.module.ts

@@ -23,7 +23,7 @@ import { TranslateModule } from '@ngx-translate/core';
 import { FormModule } from '@alfresco/adf-core';
 import { MaterialModule } from '../material.module';
 
-import { CardViewModule, CardViewUpdateService, DataColumnModule, DataTableModule, DirectiveModule, PipeModule } from '@alfresco/adf-core';
+import { CardViewModule, DataColumnModule, DataTableModule, DirectiveModule, PipeModule } from '@alfresco/adf-core';
 import { TaskListModule } from '../task-list/task-list.module';
 import { PeopleModule } from '../people/people.module';
 import { CommentsModule } from '../comments/comments.module';
@@ -70,8 +70,7 @@ import { ProcessFilterService } from './services/process-filter.service';
     ],
     providers: [
         ProcessService,
-        ProcessFilterService,
+        ProcessFilterService
-        CardViewUpdateService
     ],
     exports: [
         ProcessInstanceListComponent,

lib/process-services/task-list/components/task-details.component.ts

@@ -48,10 +48,7 @@ import { AttachFileWidgetComponent, AttachFolderWidgetComponent } from '../../co
 @Component({
     selector: 'adf-task-details',
     templateUrl: './task-details.component.html',
-    styleUrls: ['./task-details.component.scss'],
+    styleUrls: ['./task-details.component.scss']
-    providers: [
-        CardViewUpdateService
-    ]
 })
 export class TaskDetailsComponent implements OnInit, OnChanges {