From 3a3d202b54c1f5e3e96e052e7afb8f9923cad3e0 Mon Sep 17 00:00:00 2001
From: VitoAlbano <vito.albano@hyland.com>
Date: Fri, 22 Aug 2025 16:59:30 +0100
Subject: [PATCH] AAE-30882 - Improved some unit tests

---
 .../test/governance-services/securityMarksApi.spec.ts      | 1 +
 lib/js-api/test/mockObjects/base.mock.ts                   | 7 +++++++
 .../mockObjects/goverance-services/security-groups.mock.ts | 6 ++++--
 .../mockObjects/goverance-services/security-marks.mock.ts  | 5 ++++-
 4 files changed, 16 insertions(+), 3 deletions(-)

diff --git a/lib/js-api/test/governance-services/securityMarksApi.spec.ts b/lib/js-api/test/governance-services/securityMarksApi.spec.ts
index ba9334be02..d96245ea6b 100644
--- a/lib/js-api/test/governance-services/securityMarksApi.spec.ts
+++ b/lib/js-api/test/governance-services/securityMarksApi.spec.ts
@@ -118,6 +118,7 @@ describe('Security Mark API test', () => {
 
     it('delete Security Mark', async () => {
         securityMarkApiMock.getDeleteSecurityMarkSuccessfulResponse(securityGroupId, securityMarkId);
+        securityGroupMock.deleteSecurityGroup200Response(securityGroupId);
         await securityGroupApi
             .deleteSecurityGroup(securityGroupId)
             .then((data) => {
diff --git a/lib/js-api/test/mockObjects/base.mock.ts b/lib/js-api/test/mockObjects/base.mock.ts
index ad2b9f8b19..bf4204ce08 100644
--- a/lib/js-api/test/mockObjects/base.mock.ts
+++ b/lib/js-api/test/mockObjects/base.mock.ts
@@ -44,6 +44,13 @@ export class BaseMock {
         };
     }
 
+    getBaseHeaders(): Record<string, string> {
+        return {
+            'Access-Control-Allow-Origin': '*',
+            'Access-Control-Allow-Credentials': 'true'
+        };
+    }
+
     protected createNockWithCors(): nock.Scope {
         this.addCorsSupport();
         return nock(this.host, { encodedQueryParams: true }).defaultReplyHeaders(this.getDefaultHeaders());
diff --git a/lib/js-api/test/mockObjects/goverance-services/security-groups.mock.ts b/lib/js-api/test/mockObjects/goverance-services/security-groups.mock.ts
index aa2671914d..58771183a4 100644
--- a/lib/js-api/test/mockObjects/goverance-services/security-groups.mock.ts
+++ b/lib/js-api/test/mockObjects/goverance-services/security-groups.mock.ts
@@ -15,7 +15,9 @@
  * limitations under the License.
  */
 
+import { th } from 'date-fns/locale';
 import { BaseMock } from '../base.mock';
+import nock from 'nock';
 
 export class SecurityGroupApiMock extends BaseMock {
     createSecurityGroup200Response(): void {
@@ -88,7 +90,7 @@ export class SecurityGroupApiMock extends BaseMock {
 
     deleteSecurityGroup200Response(securityGroupId: string): void {
         this.createNockWithCors()
-            .delete('/alfresco/api/-default-/public/alfresco/versions/1/security-groups/' + securityGroupId)
-            .reply(200);
+            .delete('/alfresco/api/-default-/public/gs/versions/1/security-groups/' + securityGroupId)
+            .reply(204);
     }
 }
diff --git a/lib/js-api/test/mockObjects/goverance-services/security-marks.mock.ts b/lib/js-api/test/mockObjects/goverance-services/security-marks.mock.ts
index 3f439f74e8..0328d0839b 100644
--- a/lib/js-api/test/mockObjects/goverance-services/security-marks.mock.ts
+++ b/lib/js-api/test/mockObjects/goverance-services/security-marks.mock.ts
@@ -15,6 +15,7 @@
  * limitations under the License.
  */
 
+import nock from 'nock';
 import { BaseMock } from '../base.mock';
 
 export class SecurityMarkApiMock extends BaseMock {
@@ -108,7 +109,9 @@ export class SecurityMarkApiMock extends BaseMock {
             });
     }
     getDeleteSecurityMarkSuccessfulResponse(securityGroupId: string, securityMarkId: string): void {
-        this.createNockWithCors()
+        this.addCorsSupport();
+        nock(this.host)
+            .defaultReplyHeaders(this.getBaseHeaders())
             .delete('/alfresco/api/-default-/public/gs/versions/1/security-groups/' + securityGroupId + '/security-marks/' + securityMarkId)
             .reply(200);
     }