From 3a699a38d4b42c6eaf08d185709ad671484c8613 Mon Sep 17 00:00:00 2001 From: Vito Date: Wed, 23 May 2018 19:08:40 +0100 Subject: [PATCH] [ADF-2238] removed created by property (#3380) * [ADF-2238] removed created by property * [ADF-2238] added a condition to avoid checklist delete for completed task * Revert "[ADF-2238] added a condition to avoid checklist delete for completed task" This reverts commit fc2227ea0491f14bdb5c4ef1dc8c01967780072c. --- docs/process-services/task-header.component.md | 2 +- lib/core/app-config/schema.json | 2 +- .../task-list/components/task-header.component.spec.ts | 10 ---------- .../task-list/components/task-header.component.ts | 7 ------- 4 files changed, 2 insertions(+), 19 deletions(-) diff --git a/docs/process-services/task-header.component.md b/docs/process-services/task-header.component.md index b12f8ae077..678f067b55 100644 --- a/docs/process-services/task-header.component.md +++ b/docs/process-services/task-header.component.md @@ -41,7 +41,7 @@ The component populates an internal array of By default all properties are displayed: -***assignee***, ***status***, ***priority***, ***dueDate***, ***category***, ***parentName***, ***created-by***, ***created***, ***id***, ***description***, ***formName***. +***assignee***, ***status***, ***priority***, ***dueDate***, ***category***, ***parentName***, ***created***, ***id***, ***description***, ***formName***. However, you can also choose which properties to show using a configuration in `app.config.json`: diff --git a/lib/core/app-config/schema.json b/lib/core/app-config/schema.json index 10b5126dba..1f25414388 100644 --- a/lib/core/app-config/schema.json +++ b/lib/core/app-config/schema.json @@ -365,7 +365,7 @@ "properties": { "type": "array", "items": { - "enum": [ "assignee", "status", "priority", "dueDate", "category", "parentName", "created-by", "created", "id", "description", "formName" ] + "enum": [ "assignee", "status", "priority", "dueDate", "category", "parentName", "created", "id", "description", "formName" ] } } } diff --git a/lib/process-services/task-list/components/task-header.component.spec.ts b/lib/process-services/task-list/components/task-header.component.spec.ts index 76633ee453..13e07f440f 100644 --- a/lib/process-services/task-list/components/task-header.component.spec.ts +++ b/lib/process-services/task-list/components/task-header.component.spec.ts @@ -114,16 +114,6 @@ describe('TaskHeaderComponent', () => { })); - it('should display created-by', async(() => { - component.refreshData(); - fixture.detectChanges(); - - fixture.whenStable().then(() => { - let formNameEl = fixture.debugElement.query(By.css('[data-automation-id="header-created-by"] .adf-property-value')); - expect(formNameEl.nativeElement.innerText).toBe('Wilbur Adams'); - }); - })); - it('should display priority', async(() => { component.taskDetails.priority = 27; component.refreshData(); diff --git a/lib/process-services/task-list/components/task-header.component.ts b/lib/process-services/task-list/components/task-header.component.ts index 2be1bb6fab..5b467c4637 100644 --- a/lib/process-services/task-list/components/task-header.component.ts +++ b/lib/process-services/task-list/components/task-header.component.ts @@ -124,13 +124,6 @@ export class TaskHeaderComponent implements OnChanges, OnInit { clickable: true } ), - new CardViewTextItemModel( - { - label: 'ADF_TASK_LIST.PROPERTIES.CREATED_BY', - value: this.taskDetails.getFullName(), - key: 'created-by' - } - ), new CardViewDateItemModel( { label: 'ADF_TASK_LIST.PROPERTIES.CREATED',