inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix readonly attach file scenarios (#5365)

Browse Source
This commit is contained in:
Eugenio Romano
2020-01-14 00:14:11 +01:00
committed by GitHub
parent fd53531be7
commit 3cf12fca49
4 changed files with 76 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
lib/core/i18n/en.json
View File

@@ -26,6 +26,7 @@
"REMOVE_FILE": "Remove",
"UPLOAD": "UPLOAD",
"REQUIRED": "*Required",
"NO_FILE_ATTACHED" : "No file attached",
"VALIDATOR": {
"INVALID_NUMBER": "Use a different number format",
"INVALID_DATE": "Use a different date format",

7
lib/process-services-cloud/src/lib/form/components/widgets/attach-file/attach-file-cloud-widget.component.html
View File

@@ -28,7 +28,8 @@
(click)="uploadFileFromCS()">
{{field.params?.fileSource?.name}}
<mat-icon>
<img alt="alfresco" class="adf-attach-widget__image-logo" src="../assets/images/alfresco-flower.svg">
<img alt="alfresco" class="adf-attach-widget__image-logo"
src="../assets/images/alfresco-flower.svg">
</mat-icon>
</button>
</div>
@@ -71,6 +72,10 @@
</mat-menu>
</mat-list-item>
</mat-list>
<div *ngIf="!hasFile && field.readOnly" id="{{'adf-attach-empty-list-'+field.id}}">
{{ 'FORM.FIELD.NO_FILE_ATTACHED' | translate }}
</div>
</div>
<error-widget [error]="field.validationSummary"></error-widget>

50
lib/process-services-cloud/src/lib/form/components/widgets/attach-file/attach-file-cloud-widget.component.spec.ts
View File

@@ -234,6 +234,56 @@ describe('AttachFileCloudWidgetComponent', () => {
});
}));
describe('when is readonly', () => {
it('should show empty list message when there are no file', async(() => {
widget.field = new FormFieldModel(new FormModel(), {
type: FormFieldTypes.UPLOAD,
readOnly: true,
value: []
});
widget.field.id = 'empty-test';
widget.field.params = <FormFieldMetadata> onlyLocalParams;
fixture.detectChanges();
fixture.whenStable().then(() => {
expect(element.querySelector('#adf-attach-empty-list-empty-test')).not.toBeNull();
});
}));
it('should not show empty list message when there are files', async(() => {
widget.field = new FormFieldModel(new FormModel(), {
type: FormFieldTypes.UPLOAD,
readOnly: true,
value: [fakePngAnswer]
});
widget.field.id = 'fill-test';
widget.field.params = <FormFieldMetadata> onlyLocalParams;
fixture.detectChanges();
fixture.whenStable().then(() => {
expect(element.querySelector('#adf-attach-empty-list-fill-test')).toBeNull();
});
}));
it('should not show remove button when there are files attached', async(() => {
widget.field = new FormFieldModel(new FormModel(), {
type: FormFieldTypes.UPLOAD,
readOnly: true,
value: [fakePngAnswer]
});
widget.field.id = 'fill-test';
widget.field.params = <FormFieldMetadata> onlyLocalParams;
fixture.detectChanges();
const menuButton: HTMLButtonElement = <HTMLButtonElement> (
fixture.debugElement.query(By.css('#file-1155-option-menu'))
.nativeElement
);
menuButton.click();
fixture.detectChanges();
expect(fixture.debugElement.query(By.css('#file-1155-remove'))).toBeNull();
}));
});
describe('when a file is uploaded', () => {
beforeEach(async(() => {
widget.field = new FormFieldModel(new FormModel(), {

5
lib/process-services-cloud/src/lib/form/components/widgets/attach-file/upload-cloud.widget.html
View File

@@ -34,6 +34,11 @@
(change)="onFileChanged($event)"/>
</button>
</div>
<div *ngIf="!hasFile && field.readOnly">
{{ 'FORM.FIELD.NO_FILE_ATTACHED' | translate }}
</div>
</div>
<error-widget [error]="field.validationSummary"></error-widget>
<error-widget *ngIf="isInvalidFieldRequired()" required="{{ 'FORM.FIELD.REQUIRED' | translate }}"></error-widget>