Refactor process list component (#3979)

e2e/pages/adf/process_services/processDetailsPage.js

@@ -21,6 +21,7 @@ var ProcessDetailsPage = function () {
 
     //Process Details
     var processTitle = element(by.css("mat-card-title[class='mat-card-title']"));
+    var processDetailsMessage = element(by.css('adf-process-instance-details div[class="ng-star-inserted"]'));
     var processStatusField = element(by.css("span[data-automation-id='card-textitem-value-status']"));
     var processEndDateField = element(by.css("span[data-automation-id='card-dateitem-ended']"));
     var processCategoryField = element(by.css("span[data-automation-id='card-textitem-value-category']"));
@@ -68,6 +69,11 @@ var ProcessDetailsPage = function () {
         return processTitle.getText();
     };
 
+    this.checkProcessDetailsMessage = function () {
+        Util.waitUntilElementIsVisible(processDetailsMessage);
+        return processDetailsMessage.getText();
+    };
+
     this.getProcessStatus = function () {
         Util.waitUntilElementIsVisible(processStatusField);
         return processStatusField.getText();

e2e/pages/adf/process_services/processListPage.ts

@@ -22,10 +22,6 @@ import { element, by } from 'protractor';
 export class ProcessListPage {
 
     processListTitle = element(by.css('p[class="adf-empty-content__title"]'));
-    processDetailsMessage = element(by.css('adf-process-instance-details div[class="ng-star-inserted"]'));
-    openProcessDropdownElement = element(by.id('adf-select-process-dropdown'));
-    selectProcessDropdownElement = element.all(by.css('span[class="mat-option-text"]'));
-    startProcessButton = element(by.css('button[data-automation-id="btn-start"]'));
     processInstanceList = element(by.css('adf-process-instance-list'));
 
     checkProcessListTitleIsDisplayed() {
@@ -33,26 +29,6 @@ export class ProcessListPage {
         return this.processListTitle.getText();
     }
 
-    checkProcessDetailsMessage() {
-        Util.waitUntilElementIsVisible(this.processListTitle);
-        return this.processDetailsMessage.getText();
-    }
-
-    openProcessDropdown() {
-        Util.waitUntilElementIsVisible(this.openProcessDropdownElement);
-        return this.openProcessDropdownElement.click();
-    }
-
-    selectProcessDropdown(index) {
-        Util.waitUntilElementIsVisible(this.selectProcessDropdownElement);
-        return this.selectProcessDropdownElement.get(index).click();
-    }
-
-    startProcess() {
-        Util.waitUntilElementIsVisible(this.startProcessButton);
-        return this.startProcessButton.click();
-    }
-
     checkProcessListIsDisplayed() {
         Util.waitUntilElementIsVisible(this.processInstanceList);
     }

e2e/process-services/empty_process_list_component.e2e.ts

@@ -23,6 +23,7 @@ import { ProcessServicesPage } from '../pages/adf/process_services/processServic
 import ProcessFiltersPage = require('../pages/adf/process_services/processFiltersPage');
 import ProcessDetailsPage = require('../pages/adf/process_services/processDetailsPage');
 import { ProcessListPage } from '../pages/adf/process_services/processListPage';
+import StartProcessPage = require('../pages/adf/process_services/startProcessPage');
 
 import AlfrescoApi = require('alfresco-js-api-node');
 import { AppsActions } from '../actions/APS/apps.actions';
@@ -36,6 +37,7 @@ describe('Empty Process List Test', () => {
     let processFiltersPage = new ProcessFiltersPage();
     let processDetailsPage = new ProcessDetailsPage();
     let processListPage = new ProcessListPage();
+    let startProcessPage = new StartProcessPage();
 
     let appA = resources.Files.APP_WITH_PROCESSES;
     let appB = resources.Files.SIMPLE_APP_WITH_USER_FORM;
@@ -69,13 +71,12 @@ describe('Empty Process List Test', () => {
         processServicesPage.checkApsContainer();
         processServicesPage.goToApp(appA.title).clickProcessButton();
         expect(processListPage.checkProcessListTitleIsDisplayed()).toEqual('No Processes Found');
-        expect(processListPage.checkProcessDetailsMessage()).toEqual('No process details found');
+        expect(processDetailsPage.checkProcessDetailsMessage()).toEqual('No process details found');
 
         processFiltersPage.clickCreateProcessButton();
         processFiltersPage.clickNewProcessDropdown();
-        processListPage.openProcessDropdown();
+        startProcessPage.selectFromProcessDropdown(appA.process_wse_name);
-        processListPage.selectProcessDropdown(0);
+        startProcessPage.clickStartProcessButton();
-        processListPage.startProcess();
         expect(processFiltersPage.numberOfProcessRows()).toEqual(1);
 
         processDetailsPage.checkProcessDetailsCard();
@@ -83,13 +84,12 @@ describe('Empty Process List Test', () => {
         processServicesPage.checkApsContainer();
         processServicesPage.goToApp(appB.title).clickProcessButton();
         expect(processListPage.checkProcessListTitleIsDisplayed()).toEqual('No Processes Found');
-        expect(processListPage.checkProcessDetailsMessage()).toEqual('No process details found');
+        expect(processDetailsPage.checkProcessDetailsMessage()).toEqual('No process details found');
 
         processFiltersPage.clickCreateProcessButton();
         processFiltersPage.clickNewProcessDropdown();
-        processListPage.openProcessDropdown();
+        startProcessPage.selectFromProcessDropdown(appB.processName);
-        processListPage.selectProcessDropdown(0);
+        startProcessPage.clickStartProcessButton();
-        processListPage.startProcess();
         expect(processFiltersPage.numberOfProcessRows()).toEqual(1);
         processDetailsPage.checkProcessDetailsCard();
     });

e2e/util/resources.js

@@ -41,6 +41,7 @@ exports.Files = {
         title: "App_with_processes",
         description: "Description for app",
         process_se_name: "process_with_se",
+        process_wse_name: "process_without_se",
         task_name: "Task Test 2"
     },