[ADF-4997] no-duplicate-imports rule (#5256)

* no-duplicate-imports rule

* no-duplicate-imports rule

demo-shell/src/app/app.module.ts

@@ -17,7 +17,7 @@
 
 import { BrowserModule } from '@angular/platform-browser';
 import { NgModule } from '@angular/core';
-import { FormsModule } from '@angular/forms';
+import { FormsModule, ReactiveFormsModule } from '@angular/forms';
 import { FlexLayoutModule } from '@angular/flex-layout';
 import { ChartsModule } from 'ng2-charts';
 import { HttpClientModule, HTTP_INTERCEPTORS } from '@angular/common/http';
@@ -51,7 +51,6 @@ import { MetadataDialogAdapterComponent } from './components/files/metadata-dial
 import { ThemePickerModule } from './components/theme-picker/theme-picker';
 
 import { routing } from './app.routes';
-import { ReactiveFormsModule } from '@angular/forms';
 import { TaskAttachmentsComponent } from './components/process-service/task-attachments.component';
 import { ProcessAttachmentsComponent } from './components/process-service/process-attachments.component';
 import { SharedLinkViewComponent } from './components/shared-link-view/shared-link-view.component';
@@ -63,7 +62,6 @@ import { ContentModule } from '@alfresco/adf-content-services';
 import { InsightsModule } from '@alfresco/adf-insights';
 import { ProcessModule } from '@alfresco/adf-process-services';
 import { AuthBearerInterceptor } from './services';
-import { ProcessServicesCloudModule } from '@alfresco/adf-process-services-cloud';
 import { AppExtensionsModule } from './app-extension.module';
 import { TreeViewSampleComponent } from './components/tree-view/tree-view-sample.component';
 import { CloudLayoutComponent } from './components/cloud/cloud-layout.component';
@@ -85,8 +83,8 @@ import { FormCloudDemoComponent } from './components/app-layout/cloud/form-demo/
 import { environment } from '../environments/environment';
 import { AppCloudSharedModule } from './components/cloud/shared/cloud.shared.module';
 import { DemoErrorComponent } from './components/error/demo-error.component';
-
 import {
+    ProcessServicesCloudModule,
     UserPreferenceCloudService,
     PROCESS_FILTERS_SERVICE_TOKEN,
     TASK_FILTERS_SERVICE_TOKEN

demo-shell/src/app/components/datatable/copy-content/datatable.component.ts

@@ -16,8 +16,7 @@
  */
 
 import { Component, Input } from '@angular/core';
-import { DataColumn, DataRow } from '@alfresco/adf-core';
-import { ObjectDataTableAdapter } from '@alfresco/adf-core';
+import { DataColumn, DataRow, ObjectDataTableAdapter } from '@alfresco/adf-core';
 
 export class FilteredDataAdapter extends ObjectDataTableAdapter {
 

demo-shell/src/app/components/document-list/extension-presets/name-column/name-column.component.ts

@@ -24,10 +24,9 @@ import {
     ElementRef,
     OnDestroy
 } from '@angular/core';
-import { NodeEntry } from '@alfresco/js-api';
+import { NodeEntry, Node } from '@alfresco/js-api';
 import { BehaviorSubject, Subject } from 'rxjs';
 import { AlfrescoApiService } from '@alfresco/adf-core';
-import { Node } from '@alfresco/js-api';
 import { takeUntil } from 'rxjs/operators';
 
 @Component({

demo-shell/src/app/components/files/files.component.ts

@@ -23,7 +23,7 @@ import { Location } from '@angular/common';
 
 import { MatDialog } from '@angular/material';
 import { ActivatedRoute, Params, Router } from '@angular/router';
-import { MinimalNodeEntity, NodePaging, Pagination, MinimalNodeEntryEntity, SiteEntry } from '@alfresco/js-api';
+import { MinimalNodeEntity, NodePaging, Pagination, MinimalNodeEntryEntity, SiteEntry, SearchEntry } from '@alfresco/js-api';
 import {
     AlfrescoApiService, AuthenticationService, AppConfigService, AppConfigValues, ContentService, TranslationService,
     FileUploadEvent, FolderCreatedEvent, LogService, NotificationService,
@@ -48,7 +48,6 @@ import { MetadataDialogAdapterComponent } from './metadata-dialog-adapter.compon
 import { Subject } from 'rxjs';
 import { PreviewService } from '../../services/preview.service';
 import { debounceTime, takeUntil } from 'rxjs/operators';
-import { SearchEntry } from '@alfresco/js-api';
 
 const DEFAULT_FOLDER_TO_SHOW = '-my-';
 

demo-shell/src/app/components/files/version-manager-dialog-adapter.component.ts

@@ -16,9 +16,9 @@
  */
 
 import { Component, Inject, ViewEncapsulation } from '@angular/core';
-import { MAT_DIALOG_DATA, MatDialogRef } from '@angular/material';
+import { MAT_DIALOG_DATA, MatDialogRef } from '@angular/material/dialog';
 import { MinimalNodeEntryEntity } from '@alfresco/js-api';
-import { MatSnackBar } from '@angular/material';
+import { MatSnackBar } from '@angular/material/snack-bar';
 
 @Component({
     templateUrl: './version-manager-dialog-adapter.component.html',

demo-shell/src/app/components/form/fake-form.service.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-import { Observable, of } from 'rxjs';
+import { Observable, of, Subject } from 'rxjs';
 import { Injectable } from '@angular/core';
 import {
     AlfrescoApiService,
@@ -24,7 +24,6 @@ import {
     FormService,
     FormOutcomeEvent
 } from '@alfresco/adf-core';
-import { Subject } from 'rxjs';
 
 @Injectable()
 export class FakeFormService extends FormService {

demo-shell/src/app/components/process-service/process-attachments.component.ts

@@ -18,9 +18,7 @@
 import { Component, Input, OnChanges, OnInit, ViewChild, OnDestroy } from '@angular/core';
 import { ProcessInstance, ProcessService ,
     ProcessAttachmentListComponent, ProcessUploadService } from '@alfresco/adf-process-services';
-import { UploadService } from '@alfresco/adf-core';
-import { AlfrescoApiService } from '@alfresco/adf-core';
-import { AppConfigService } from '@alfresco/adf-core';
+import { UploadService, AlfrescoApiService, AppConfigService } from '@alfresco/adf-core';
 import { PreviewService } from '../../services/preview.service';
 import { Subject } from 'rxjs';
 import { takeUntil } from 'rxjs/operators';

demo-shell/src/app/components/process-service/process-service.component.ts

@@ -35,7 +35,8 @@ import {
 } from '@alfresco/js-api';
 import {
     FORM_FIELD_VALIDATORS, FormRenderingService, FormService,
-    DynamicTableRow, ValidateDynamicTableRowEvent, AppConfigService, PaginationComponent, UserPreferenceValues
+    DynamicTableRow, ValidateDynamicTableRowEvent, AppConfigService, PaginationComponent, UserPreferenceValues,
+    AlfrescoApiService, UserPreferencesService, LogService
 } from '@alfresco/adf-core';
 
 import { AnalyticsReportListComponent } from '@alfresco/adf-insights';
@@ -45,9 +46,7 @@ import {
     ProcessInstance,
     ProcessInstanceDetailsComponent,
     ProcessInstanceListComponent,
-    StartProcessInstanceComponent
-} from '@alfresco/adf-process-services';
-import {
+    StartProcessInstanceComponent,
     AppsListComponent,
     FilterRepresentationModel,
     TaskDetailsComponent,
@@ -55,8 +54,6 @@ import {
     TaskFiltersComponent,
     TaskListComponent
 } from '@alfresco/adf-process-services';
-import { LogService } from '@alfresco/adf-core';
-import { AlfrescoApiService, UserPreferencesService } from '@alfresco/adf-core';
 import { Subject } from 'rxjs';
 import { /*CustomEditorComponent*/ CustomStencil01 } from './custom-editor/custom-editor.component';
 import { DemoFieldValidator } from './demo-field-validator';

demo-shell/src/app/components/search/search-extended.component.ts

@@ -18,8 +18,7 @@
 import { Component, ViewChild, ViewEncapsulation } from '@angular/core';
 import { Pagination, QueryBody, MinimalNodeEntity } from '@alfresco/js-api';
 import { SearchComponent } from '@alfresco/adf-content-services';
-import { ThumbnailService } from '@alfresco/adf-core';
-import { SearchService, SearchConfigurationService } from '@alfresco/adf-core';
+import { ThumbnailService, SearchService, SearchConfigurationService } from '@alfresco/adf-core';
 import { TestSearchConfigurationService } from './search-config-test.service';
 
 @Component({

demo-shell/src/polyfills.ts

@@ -55,8 +55,6 @@ import 'classlist.js';  // Run `npm install --save classlist.js`.
 
 /** Evergreen browsers require these. */
 import 'core-js/es6/reflect';
-
-import 'core-js/es6/array';
 import 'core-js/es7/array';
 
 /***************************************************************************************************