inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ADF-3934] PeoplCloudComponent - add dynamic placeholder (#4548)

Browse Source 
* [ADF-3934]  PeoplCloudComponent - add dynamic placeholder

* [ADF-3934] - fix tests

* [AF-3934] - PR changes

* [ADF-3934] - remove unnecesary test

* [ADF-3934] - lint
This commit is contained in:
Silviu Popa
2019-04-10 03:21:12 +03:00
committed by Eugenio Romano
parent 4bfae518fb
commit 3df30f05f3
6 changed files with 44 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/process-services-cloud/src/lib/task/start-task/components/people-cloud/people-cloud.component.html
View File

@@ -1,6 +1,6 @@
<form>
<mat-form-field class="adf-people-cloud">
<mat-label id="assignee-id">{{'ADF_TASK_LIST.START_TASK.FORM.LABEL.ASSIGNEE' | translate}}</mat-label>
<mat-label id="title-id">{{ title | translate }}</mat-label>
<mat-chip-list #userChipList *ngIf="isMultipleMode(); else singleSelection">
<mat-chip
*ngFor="let user of selectedUsers$ | async"

36
lib/process-services-cloud/src/lib/task/start-task/components/people-cloud/people-cloud.component.spec.ts
View File

@@ -145,6 +145,25 @@ describe('PeopleCloudComponent', () => {
expect(errorMessage.textContent).toContain('ADF_CLOUD_START_TASK.ERROR.MESSAGE');
});
}));
it('should populate placeholder when title is present', async(() => {
component.title = 'TITLE_KEY';
fixture.detectChanges();
const matLabel: HTMLInputElement = <HTMLInputElement> element.querySelector('mat-label');
fixture.whenStable().then( () => {
fixture.detectChanges();
expect(matLabel.textContent).toEqual('TITLE_KEY');
});
}));
it('should not populate placeholder when title is present', async(() => {
const matLabel: HTMLInputElement = <HTMLInputElement> element.querySelector('mat-label');
fixture.detectChanges();
fixture.whenStable().then( () => {
fixture.detectChanges();
expect(matLabel.textContent).toEqual('');
});
}));
});
describe('when application name defined', () => {
@@ -543,7 +562,7 @@ describe('PeopleCloudComponent', () => {
component.preSelectUsers = <any> [{ id: mockUsers[0].id }, { id: mockUsers[1].id }];
component.ngOnChanges({ 'preSelectUsers': change });
fixture.detectChanges();
component.filterPreselectUsers().then((result) => {
component.filterPreselectUsers().then((result: any) => {
fixture.detectChanges();
expect(findByIdSpy).toHaveBeenCalled();
expect(component.userExists(result[0])).toEqual(true);
@@ -636,5 +655,20 @@ describe('PeopleCloudComponent', () => {
});
});
}));
it('should populate placeholder when title is present', () => {
fixture.detectChanges();
component.title = 'ADF_TASK_LIST.START_TASK.FORM.LABEL.ASSIGNEE';
const inputHTMLElement: HTMLInputElement = <HTMLInputElement> element.querySelector('mat-label');
fixture.detectChanges();
expect(inputHTMLElement.textContent).toEqual('ADF_TASK_LIST.START_TASK.FORM.LABEL.ASSIGNEE');
});
it('should not populate placeholder when title is present', () => {
fixture.detectChanges();
const inputHTMLElement: HTMLInputElement = <HTMLInputElement> element.querySelector('mat-label');
fixture.detectChanges();
expect(inputHTMLElement.textContent).toEqual('');
});
});
});

5
lib/process-services-cloud/src/lib/task/start-task/components/people-cloud/people-cloud.component.ts
View File

@@ -71,6 +71,11 @@ export class PeopleCloudComponent implements OnInit, OnChanges {
@Input()
preSelectUsers: IdentityUserModel[];
/** Placeholder translation key
*/
@Input()
title: string;
/** Emitted when a user is selected. */
@Output()
selectUser: EventEmitter<IdentityUserModel> = new EventEmitter<IdentityUserModel>();

1
lib/process-services-cloud/src/lib/task/start-task/components/start-task-cloud.component.html
View File

@@ -64,6 +64,7 @@
[appName]="appName"
[preSelectUsers]="[currentUser]"
(selectUser)="onAssigneeSelect($event)"
[title]="'ADF_TASK_LIST.START_TASK.FORM.LABEL.ASSIGNEE'"
(removeUser)="onAssigneeRemove()"></adf-cloud-people>
</div>