From 3dff1e0091eae98da71a1b0686141cca106c5bc8 Mon Sep 17 00:00:00 2001
From: Denys Vuika <denys.vuika@gmail.com>
Date: Wed, 27 Mar 2024 10:25:58 -0400
Subject: [PATCH] fix: incorrect angular attributes in search components
 (#9479)

---
 .../search-facet-chip-tabbed.component.html        |  6 +++---
 .../search-facet-chip.component.html               |  4 ++--
 .../search-widget-chip.component.html              |  4 ++--
 .../search-form/search-form.component.html         | 14 +++++---------
 4 files changed, 12 insertions(+), 16 deletions(-)

diff --git a/lib/content-services/src/lib/search/components/search-filter-chips/search-facet-chip-tabbed/search-facet-chip-tabbed.component.html b/lib/content-services/src/lib/search/components/search-filter-chips/search-facet-chip-tabbed/search-facet-chip-tabbed.component.html
index 7864ab69e7..2277431ac0 100644
--- a/lib/content-services/src/lib/search/components/search-filter-chips/search-facet-chip-tabbed/search-facet-chip-tabbed.component.html
+++ b/lib/content-services/src/lib/search/components/search-filter-chips/search-facet-chip-tabbed/search-facet-chip-tabbed.component.html
@@ -1,11 +1,11 @@
 <mat-chip [attr.data-automation-id]="'search-filter-chip-tabbed-' + tabbedFacet.label"
-          disableRipple
+          [disableRipple]="true"
           class="adf-search-filter-chip-tabbed"
           [class.adf-search-toggle-chip]="displayValue || menuTrigger.menuOpen"
           [disabled]="!isPopulated"
-          tabIndex="0"
+          [tabIndex]="0"
           [matMenuTriggerFor]="menu"
-          (onMenuOpen)="onMenuOpen()"
+          (menuOpened)="onMenuOpen()"
           (keydown.enter)="onEnterKeydown()"
           (keydown.escape)="onEscKeydown()"
           [attr.title]="displayValue"
diff --git a/lib/content-services/src/lib/search/components/search-filter-chips/search-facet-chip/search-facet-chip.component.html b/lib/content-services/src/lib/search/components/search-filter-chips/search-facet-chip/search-facet-chip.component.html
index b32eda5a93..2bdab66712 100644
--- a/lib/content-services/src/lib/search/components/search-filter-chips/search-facet-chip/search-facet-chip.component.html
+++ b/lib/content-services/src/lib/search/components/search-filter-chips/search-facet-chip/search-facet-chip.component.html
@@ -1,9 +1,9 @@
 <mat-chip [attr.data-automation-id]="'search-filter-chip-' + field.label"
-          disableRipple
+          [disableRipple]="true"
           class="adf-search-filter-chip adf-search-filter-facet-chip"
           [class.adf-search-toggle-chip]="(facetField.displayValue$ | async) || menuTrigger.menuOpen"
           [disabled]="!isPopulated()"
-          tabIndex="0"
+          [tabIndex]="0"
           [matMenuTriggerFor]="menu"
           (menuOpened)="onMenuOpen()"
           (keydown.enter)="onEnterKeydown()"
diff --git a/lib/content-services/src/lib/search/components/search-filter-chips/search-widget-chip/search-widget-chip.component.html b/lib/content-services/src/lib/search/components/search-filter-chips/search-widget-chip/search-widget-chip.component.html
index 5ef712147b..8424470d8a 100644
--- a/lib/content-services/src/lib/search/components/search-filter-chips/search-widget-chip/search-widget-chip.component.html
+++ b/lib/content-services/src/lib/search/components/search-filter-chips/search-widget-chip/search-widget-chip.component.html
@@ -1,8 +1,8 @@
 <mat-chip [attr.data-automation-id]="'search-filter-chip-' + category.name"
-          disableRipple
+          [disableRipple]="true"
           class="adf-search-filter-chip"
           [class.adf-search-toggle-chip]="(widget.getDisplayValue() | async) || menuTrigger.menuOpen"
-          tabIndex="0"
+          [tabIndex]="0"
           [matMenuTriggerFor]="menu"
           (menuOpened)="onMenuOpen()"
           (keydown.enter)="onEnterKeydown()"
diff --git a/lib/content-services/src/lib/search/components/search-form/search-form.component.html b/lib/content-services/src/lib/search/components/search-form/search-form.component.html
index 7b960d6da7..cc77093f47 100644
--- a/lib/content-services/src/lib/search/components/search-form/search-form.component.html
+++ b/lib/content-services/src/lib/search/components/search-form/search-form.component.html
@@ -2,12 +2,11 @@
 
     <ng-container *ngIf="forms.length === 1">
         <button class="adf-search-form adf-search-form-button"
-                [disableRipple] mat-button
+                [disableRipple]="true"
+                mat-button
                 [title]="getSelected(forms) | translate"
                 [attr.aria-label]="getSelected(forms) | translate">
-            <span class="adf-search-form-title">
-                    {{ getSelected(forms) | translate }}
-            </span>
+            <span class="adf-search-form-title">{{ getSelected(forms) | translate }}</span>
         </button>
     </ng-container>
 
@@ -15,16 +14,13 @@
         <button class="adf-search-form adf-search-form-button"
                 [matMenuTriggerFor]="menu"
                 #menuTrigger="matMenuTrigger"
-                [disableRipple]
+                [disableRipple]="true"
                 mat-button
                 [title]="getSelected(forms) | translate"
                 [attr.aria-label]="getSelected(forms) | translate"
                 [matMenuTriggerRestoreFocus]="true">
 
-            <span class="adf-search-form-title" >
-                    {{ getSelected(forms) | translate }}
-            </span>
-
+            <span class="adf-search-form-title">{{ getSelected(forms) | translate }}</span>
             <mat-icon [class.adf-search-form-icon-selected]="menuTrigger.menuOpen" class="adf-search-form-icon">expand_more</mat-icon>
         </button>