From 41597e271a99f7c19faef1bec5fb0074c6fd7b5a Mon Sep 17 00:00:00 2001 From: dhrn <14145706+dhrn@users.noreply.github.com> Date: Fri, 13 Mar 2020 21:12:38 +0530 Subject: [PATCH] [ADF-4522] Metadata value is not rolled back upon error (#5545) --- .../content-metadata/content-metadata.component.spec.ts | 4 +++- .../components/content-metadata/content-metadata.component.ts | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.spec.ts b/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.spec.ts index 52430368e9..1f8825d9c3 100644 --- a/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.spec.ts +++ b/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.spec.ts @@ -147,10 +147,12 @@ describe('ContentMetadataComponent', () => { expect(logService.error).toHaveBeenCalledWith(new Error('My bad')); }); - it('should raise error message', (done) => { + it('should raise error message and reload the properties', (done) => { + spyOn(contentMetadataService, 'getBasicProperties'); const property = { key: 'property-key', value: 'original-value' }; const sub = contentMetadataService.error.subscribe((err) => { + expect(contentMetadataService.getBasicProperties).toHaveBeenCalledWith(node); expect(err.statusCode).toBe(0); expect(err.message).toBe('METADATA.ERRORS.GENERIC'); sub.unsubscribe(); diff --git a/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.ts b/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.ts index 820e49164d..9bd1030795 100644 --- a/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.ts +++ b/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.ts @@ -94,6 +94,7 @@ export class ContentMetadataComponent implements OnChanges, OnInit, OnDestroy { switchMap((changes) => this.saveNode(changes).pipe( catchError((err) => { + this.loadProperties(this.node); this.handleUpdateError(err); return of(null); })