[ADF-3962] sso download directive automated (#4452)

* sso download directive automated

* temp changes

* temp changes

* moving of services under lib testing and ADF-3962 automated

* removed the browser sleep

* cspell and linting fixes.

* codacy improvements

* export public-api update

* remove circular dep

* remove circular dep

* fixes

* fix user info test

* fix datatable

* random commit

* move other string

* fix lint

* fix lint

* fix prolem type

* fix failing test

* fix tag test

* fix problems after rebase

* fix lint

* remove space

* remove visibility method duplicated

e2e/pages/adf/core/headerPage.ts

@@ -17,7 +17,7 @@
 
 import { element, by, protractor } from 'protractor';
 
-import { Util } from '../../../util/util';
+import { BrowserVisibility } from '@alfresco/adf-testing';
 
 export class HeaderPage {
 
@@ -34,24 +34,24 @@ export class HeaderPage {
     sideBarPositionLeft = element(by.css('mat-sidenav.mat-drawer.mat-sidenav'));
 
     checkShowMenuCheckBoxIsDisplayed() {
-        return Util.waitUntilElementIsVisible(this.checkBox);
+        return BrowserVisibility.waitUntilElementIsVisible(this.checkBox);
     }
 
     checkChooseHeaderColourIsDisplayed() {
-        return Util.waitUntilElementIsVisible(this.headerColor);
+        return BrowserVisibility.waitUntilElementIsVisible(this.headerColor);
     }
 
     checkChangeTitleIsDisplayed() {
-        return Util.waitUntilElementIsVisible(this.titleInput);
+        return BrowserVisibility.waitUntilElementIsVisible(this.titleInput);
     }
 
     checkChangeUrlPathIsDisplayed() {
-        return Util.waitUntilElementIsVisible(this.iconInput);
+        return BrowserVisibility.waitUntilElementIsVisible(this.iconInput);
     }
 
     clickShowMenuButton() {
         const checkBox = element.all(by.css('mat-checkbox'));
-        Util.waitUntilElementIsVisible(checkBox);
+        BrowserVisibility.waitUntilElementIsVisible(checkBox);
         return checkBox.get(0).click();
     }
 
@@ -62,11 +62,11 @@ export class HeaderPage {
 
     checkAppTitle(name) {
         const title = element(by.cssContainingText('.adf-app-title', name));
-        return Util.waitUntilElementIsVisible(title);
+        return BrowserVisibility.waitUntilElementIsVisible(title);
     }
 
     addTitle(title) {
-        Util.waitUntilElementIsVisible(this.titleInput);
+        BrowserVisibility.waitUntilElementIsVisible(this.titleInput);
         this.titleInput.click();
         this.titleInput.sendKeys(title);
         this.titleInput.sendKeys(protractor.Key.ENTER);
@@ -74,66 +74,66 @@ export class HeaderPage {
 
     checkIconIsDisplayed(url) {
         const icon = element(by.css('img[src="' + url + '"]'));
-        Util.waitUntilElementIsVisible(icon);
+        BrowserVisibility.waitUntilElementIsVisible(icon);
     }
 
     addIcon(url) {
-        Util.waitUntilElementIsVisible(this.iconInput);
+        BrowserVisibility.waitUntilElementIsVisible(this.iconInput);
         this.iconInput.click();
         this.iconInput.sendKeys(url);
         this.iconInput.sendKeys(protractor.Key.ENTER);
     }
 
     checkHexColorInputIsDisplayed() {
-        return Util.waitUntilElementIsVisible(this.hexColorInput);
+        return BrowserVisibility.waitUntilElementIsVisible(this.hexColorInput);
     }
 
     checkLogoHyperlinkInputIsDisplayed() {
-        return Util.waitUntilElementIsVisible(this.logoHyperlinkInput);
+        return BrowserVisibility.waitUntilElementIsVisible(this.logoHyperlinkInput);
     }
 
     checkLogoTooltipInputIsDisplayed() {
-        return Util.waitUntilElementIsVisible(this.logoTooltipInput);
+        return BrowserVisibility.waitUntilElementIsVisible(this.logoTooltipInput);
     }
 
     addHexCodeColor(hexCode) {
-        Util.waitUntilElementIsVisible(this.hexColorInput);
+        BrowserVisibility.waitUntilElementIsVisible(this.hexColorInput);
         this.hexColorInput.click();
         this.hexColorInput.sendKeys(hexCode);
         return this.hexColorInput.sendKeys(protractor.Key.ENTER);
     }
 
     addLogoHyperlink(hyperlink) {
-        Util.waitUntilElementIsVisible(this.logoHyperlinkInput);
-        Util.waitUntilElementIsClickable(this.logoHyperlinkInput);
+        BrowserVisibility.waitUntilElementIsVisible(this.logoHyperlinkInput);
+        BrowserVisibility.waitUntilElementIsClickable(this.logoHyperlinkInput);
         this.logoHyperlinkInput.click();
         this.logoHyperlinkInput.sendKeys(hyperlink);
         return this.logoHyperlinkInput.sendKeys(protractor.Key.ENTER);
     }
 
     addLogoTooltip(tooltip) {
-        Util.waitUntilElementIsVisible(this.logoTooltipInput);
+        BrowserVisibility.waitUntilElementIsVisible(this.logoTooltipInput);
         this.logoTooltipInput.click();
         this.logoTooltipInput.sendKeys(tooltip);
         return this.logoTooltipInput.sendKeys(protractor.Key.ENTER);
     }
 
     sideBarPositionStart() {
-        Util.waitUntilElementIsVisible(this.positionStart);
+        BrowserVisibility.waitUntilElementIsVisible(this.positionStart);
         return this.positionStart.click();
     }
 
     sideBarPositionEnd() {
-        Util.waitUntilElementIsVisible(this.positionEnd);
+        BrowserVisibility.waitUntilElementIsVisible(this.positionEnd);
         return this.positionEnd.click();
     }
 
     checkSidebarPositionStart() {
-        return Util.waitUntilElementIsVisible(this.sideBarPositionLeft);
+        return BrowserVisibility.waitUntilElementIsVisible(this.sideBarPositionLeft);
     }
 
     checkSidebarPositionEnd() {
-        return Util.waitUntilElementIsVisible(this.sideBarPositionRight);
+        return BrowserVisibility.waitUntilElementIsVisible(this.sideBarPositionRight);
     }
 
 }

e2e/pages/adf/core/infinitePaginationPage.ts

@@ -18,7 +18,7 @@
 import { element, by } from 'protractor';
 import { ElementFinder } from 'protractor/built/element';
 
-import { Util } from '../../../util/util';
+import { BrowserVisibility } from '@alfresco/adf-testing';
 
 export class InfinitePaginationPage {
 
@@ -31,18 +31,18 @@ export class InfinitePaginationPage {
     }
 
     clickLoadMoreButton() {
-        Util.waitUntilElementIsVisible(this.loadMoreButton);
-        Util.waitUntilElementIsClickable(this.loadMoreButton);
+        BrowserVisibility.waitUntilElementIsVisible(this.loadMoreButton);
+        BrowserVisibility.waitUntilElementIsClickable(this.loadMoreButton);
         this.loadMoreButton.click();
         return this;
     }
 
     checkLoadMoreButtonIsDisplayed() {
-        return Util.waitUntilElementIsVisible(this.loadMoreButton);
+        return BrowserVisibility.waitUntilElementIsVisible(this.loadMoreButton);
     }
 
     checkLoadMoreButtonIsNotDisplayed() {
-        return Util.waitUntilElementIsNotOnPage(this.loadMoreButton);
+        return BrowserVisibility.waitUntilElementIsNotOnPage(this.loadMoreButton);
     }
 
 }