From 44f54b2a61b090216f981d132e84ca162d918bc8 Mon Sep 17 00:00:00 2001
From: jatin2008 <105338943+jatin2008@users.noreply.github.com>
Date: Fri, 18 Nov 2022 11:35:28 +0530
Subject: [PATCH] [ACS-3548] Accessibility issues (#7939)

* Accessibility issues

* requested changes

* breadcrumb changes

* review comments resolved of mattooltip

* e2e test cases fixed
---
 e2e/process-services/pages/task-details.page.ts             | 2 +-
 .../content-metadata/content-metadata.component.html        | 4 ++--
 lib/content-services/src/lib/i18n/en.json                   | 6 ++++--
 .../add-permission/add-permission-panel.component.html      | 4 +++-
 .../permission-list/permission-list.component.html          | 5 +++--
 .../src/lib/search/components/search.component.html         | 3 ++-
 .../card-view-textitem/card-view-textitem.component.html    | 4 ++++
 lib/core/src/lib/comments/comments.component.html           | 4 ++--
 .../datatable/components/datatable/datatable.component.html | 1 +
 9 files changed, 22 insertions(+), 11 deletions(-)

diff --git a/e2e/process-services/pages/task-details.page.ts b/e2e/process-services/pages/task-details.page.ts
index f2983df7ae..64badebf48 100644
--- a/e2e/process-services/pages/task-details.page.ts
+++ b/e2e/process-services/pages/task-details.page.ts
@@ -273,7 +273,7 @@ export class TaskDetailsPage {
     }
 
     async checkIsEmptyCommentListDisplayed(): Promise<void> {
-        const emptyList = element(by.cssContainingText('h1[id="comment-header"]', '(0)'));
+        const emptyList = element(by.cssContainingText('div[id="comment-header"]', '(0)'));
         await BrowserVisibility.waitUntilElementIsVisible(emptyList);
     }
 
diff --git a/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.html b/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.html
index 73faf9cfd8..c179ee428e 100644
--- a/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.html
+++ b/lib/content-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.html
@@ -5,8 +5,8 @@
                              [expanded]="canExpandProperties()"
                              [attr.data-automation-id]="'adf-metadata-group-properties'">
             <mat-expansion-panel-header>
-                <mat-panel-title>
-                    <h1 class="adf-metadata-properties-title">{{ 'CORE.METADATA.BASIC.HEADER' | translate }}</h1>
+                <mat-panel-title class="adf-metadata-properties-title">
+                    {{ 'CORE.METADATA.BASIC.HEADER' | translate }}
                 </mat-panel-title>
             </mat-expansion-panel-header>
             <adf-card-view
diff --git a/lib/content-services/src/lib/i18n/en.json b/lib/content-services/src/lib/i18n/en.json
index cb19ba23f2..8085d7382a 100644
--- a/lib/content-services/src/lib/i18n/en.json
+++ b/lib/content-services/src/lib/i18n/en.json
@@ -413,7 +413,8 @@
       "ADD-ACTION": "ADD",
       "CLOSE-ACTION": "CANCEL",
       "BASE-DIALOG-TITLE": "Search a group or people to add...",
-      "EVERYONE": "EVERYONE"
+      "EVERYONE": "EVERYONE",
+      "USER-GROUP-LIST": "User or Group List"
     },
     "COLUMN": {
       "NAME": "Users and Groups ({{ count }})",
@@ -428,7 +429,8 @@
       "DIRECT-PERMISSIONS": "Directly Applied Permission",
       "INHERITED-PERMISSIONS": "Inherited Permission",
       "INHERITED-SUBTITLE": "{{count}} users or groups are inheriting permission from a parent folder",
-      "SELECT-ROLE": "Select role"
+      "SELECT-ROLE": "Select role",
+      "INHERITED_PERMISSION_TOGGLE": "Toggle Inherited Permission"
     },
     "MESSAGE": {
       "EMPTY-PERMISSION": "No users/groups",
diff --git a/lib/content-services/src/lib/permission-manager/components/add-permission/add-permission-panel.component.html b/lib/content-services/src/lib/permission-manager/components/add-permission/add-permission-panel.component.html
index fe72d11099..7bfaa04f37 100644
--- a/lib/content-services/src/lib/permission-manager/components/add-permission/add-permission-panel.component.html
+++ b/lib/content-services/src/lib/permission-manager/components/add-permission/add-permission-panel.component.html
@@ -4,6 +4,7 @@
            id="searchInput"
            [formControl]="searchInput"
            type="text"
+           title="{{'PERMISSION_MANAGER.ADD-PERMISSION.SEARCH' | translate}}"
            placeholder="{{'PERMISSION_MANAGER.ADD-PERMISSION.SEARCH' | translate}}"
            [value]="searchedWord">
 
@@ -34,7 +35,8 @@
             class="adf-permission-result-list"
             [class.adf-permission-result-list-search]="searchedWord.length === 0">
     <ng-template let-data>
-        <mat-selection-list class="adf-permission-result-list-elements" (keydown.control.a)="onSelectionChange()"
+        <mat-selection-list class="adf-permission-result-list-elements"
+                            title="{{'PERMISSION_MANAGER.ADD-PERMISSION.USER-GROUP-LIST' | translate}}"
                             (selectionChange)="onSelectionChange()">
             <mat-list-option id="adf-add-permission-group-everyone"
                              class="adf-list-option-item"
diff --git a/lib/content-services/src/lib/permission-manager/components/permission-list/permission-list.component.html b/lib/content-services/src/lib/permission-manager/components/permission-list/permission-list.component.html
index 555d563f92..bb52464cc6 100644
--- a/lib/content-services/src/lib/permission-manager/components/permission-list/permission-list.component.html
+++ b/lib/content-services/src/lib/permission-manager/components/permission-list/permission-list.component.html
@@ -25,6 +25,7 @@
 
                     <mat-slide-toggle
                         class="adf-inherit-toggle"
+                        title="{{'PERMISSION_MANAGER.LABELS.INHERITED_PERMISSION_TOGGLE' | translate }}"
                         color="primary"
                         data-automation-id="adf-inherit-toggle-button"
                         [checked]="model.node.permissions.isInheritanceEnabled"
@@ -72,7 +73,7 @@
 
                 <button
                     mat-button
-                    [matTooltip]="'PERMISSION_MANAGER.ACTION.ADD-PERMISSION' | translate"
+                    title="{{'PERMISSION_MANAGER.ACTION.ADD-PERMISSION' | translate}}"
                     (click)="openAddPermissionDialog()"
                     data-automation-id="adf-add-permission-button">
                     <mat-icon>person_add_outline</mat-icon>
@@ -80,7 +81,7 @@
 
                 <button
                     mat-button
-                    [matTooltip]="'PERMISSION_MANAGER.ACTION.DELETE' | translate"
+                    title="{{'PERMISSION_MANAGER.ACTION.DELETE' | translate}}"
                     [disabled]="!selectedPermissions?.length"
                     (click)="deleteSelection()"
                     data-automation-id="adf-delete-selected-permission">
diff --git a/lib/content-services/src/lib/search/components/search.component.html b/lib/content-services/src/lib/search/components/search.component.html
index 40f6b736c8..d6e64b04ce 100644
--- a/lib/content-services/src/lib/search/components/search.component.html
+++ b/lib/content-services/src/lib/search/components/search.component.html
@@ -1,4 +1,5 @@
-<div role="listbox" id="adf-search-results-content" [ngClass]="_classList" #panel>
+<div role="listbox" id="adf-search-results-content" title="{{'PERMISSION_MANAGER.ADD-PERMISSION.USER-GROUP-LIST' | translate}}"
+    [ngClass]="_classList" #panel>
     <ng-template
         [ngTemplateOutlet]="template"
         [ngTemplateOutletContext]="{ $implicit: results }">
diff --git a/lib/core/src/lib/card-view/components/card-view-textitem/card-view-textitem.component.html b/lib/core/src/lib/card-view/components/card-view-textitem/card-view-textitem.component.html
index 5cfea8ae04..ed409ba33b 100644
--- a/lib/core/src/lib/card-view/components/card-view-textitem/card-view-textitem.component.html
+++ b/lib/core/src/lib/card-view/components/card-view-textitem/card-view-textitem.component.html
@@ -12,6 +12,7 @@
             <input matInput
                    *ngIf="!property.multiline"
                    class="adf-property-value"
+                   title="{{property.label | translate }}"
                    [placeholder]="property.default"
                    [attr.aria-label]="property.label | translate"
                    [formControl]="textInput"
@@ -22,6 +23,7 @@
                    [attr.data-automation-id]="'card-textitem-value-' + property.key">
             <textarea matInput
                       *ngIf="property.multiline"
+                      title="{{property.label | translate }}"
                       [cdkTextareaAutosize]="true"
                       [cdkAutosizeMaxRows]="1"
                       [cdkAutosizeMaxRows]="5"
@@ -74,6 +76,7 @@
                         [floatLabel]="'never'">
             <input matInput
                    class="adf-property-value"
+                   title="{{property.label | translate }}"
                    [placeholder]="editedValue ? '' : property.default | translate"
                    [attr.aria-label]="property.label | translate"
                    [matChipInputFor]="chipList"
@@ -98,6 +101,7 @@
             <input matInput
                    [type]=property.inputType
                    class="adf-property-value"
+                   title="{{property.label | translate }}"
                    [ngClass]="{ 'adf-textitem-clickable-value': !isEditable }"
                    [placeholder]="property.default"
                    [attr.aria-label]="property.label | translate"
diff --git a/lib/core/src/lib/comments/comments.component.html b/lib/core/src/lib/comments/comments.component.html
index 7749aedb04..53e473e64d 100644
--- a/lib/core/src/lib/comments/comments.component.html
+++ b/lib/core/src/lib/comments/comments.component.html
@@ -1,7 +1,7 @@
 <div class="adf-comments-container">
-    <h1 id="comment-header" class="adf-comments-header">
+    <div id="comment-header" class="adf-comments-header">
         {{'COMMENTS.HEADER' | translate: { count: comments?.length} }}
-    </h1>
+    </div>
     <div class="adf-comments-input-container" *ngIf="!isReadOnly()">
             <mat-form-field class="adf-full-width">
                 <textarea id="comment-input"
diff --git a/lib/core/src/lib/datatable/components/datatable/datatable.component.html b/lib/core/src/lib/datatable/components/datatable/datatable.component.html
index f5ca6489a2..6c7188b8f1 100644
--- a/lib/core/src/lib/datatable/components/datatable/datatable.component.html
+++ b/lib/core/src/lib/datatable/components/datatable/datatable.component.html
@@ -34,6 +34,7 @@
                  [attr.data-automation-id]="'auto_id_' + col.key"
                  [class.adf-datatable__header--sorted-asc]="isColumnSorted(col, 'asc')"
                  [class.adf-datatable__header--sorted-desc]="isColumnSorted(col, 'desc')"
+                 [attr.aria-label]="col.title | translate"
                  (click)="onColumnHeaderClick(col)"
                  (keyup.enter)="onColumnHeaderClick(col)"
                  role="columnheader"