[ADF-510] Drag&Drop check permission to allow user to upload a file (#1948)

* [ADF-510] added permission check for drag&drop

* Improved code for drag and drop side

* Added test for drag and drop upload area changes

* Added test for document list permissions check

* [ADF-510] rebased branch after changes applied to upload

* [ADF-510] rebased branch and fixed tests

ng2-components/ng2-alfresco-upload/src/components/upload-drag-area.component.spec.ts

@@ -25,6 +25,41 @@ import { TranslationMock } from '../assets/translation.service.mock';
 import { UploadService } from '../services/upload.service';
 import { FileModel } from '../models/file.model';
 
+let fakeShareDataRow = {
+    obj: {
+        entry: {
+            createdAt: '2017-06-04T04:32:15.597Z',
+            path: {
+                name: '/Company Home/User Homes/Test',
+                isComplete: true,
+                elements: [
+                    {
+                        id: '94acfc73-7014-4475-9bd9-93a2162f0f8c',
+                        name: 'Company Home'
+                    },
+                    {
+                        id: '55052317-7e59-4058-8e07-769f41e615e1',
+                        name: 'User Homes'
+                    },
+                    {
+                        id: '70e1cc6a-6918-468a-b84a-1048093b06fd',
+                        name: 'Test'
+                    }
+                ]
+            },
+            isFolder: true,
+            name: 'pippo',
+            id: '7462d28e-bd43-4b91-9e7b-0d71598680ac',
+            nodeType: 'cm:folder',
+            allowableOperations: [
+                'delete',
+                'update',
+                'create'
+            ]
+        }
+    }
+};
+
 describe('UploadDragAreaComponent', () => {
 
     let component: UploadDragAreaComponent;
@@ -145,4 +180,37 @@ describe('UploadDragAreaComponent', () => {
         component.onFilesEntityDropped(itemEntity);
         expect(uploadService.uploadFilesInTheQueue).toHaveBeenCalledWith(null);
     });
+
+    it('should upload a file when user has create permission on target folder', async(() => {
+        component.currentFolderPath = '/root-fake-/sites-fake/document-library-fake';
+        component.rootFolderId = '-my-';
+        component.enabled = false;
+
+        let fakeItem = {
+            fullPath: '/folder-fake/file-fake.png',
+            isDirectory: false,
+            isFile: true,
+            name: 'file-fake.png',
+            file: (callbackFile) => {
+                let fileFake = new File(['fakefake'], 'file-fake.png', {type: 'image/png'});
+                callbackFile(fileFake);
+            }
+        };
+
+        fixture.detectChanges();
+        spyOn(uploadService, 'uploadFilesInTheQueue').and.returnValue(Promise.resolve(fakeItem));
+        component.onSuccess.subscribe((val) => {
+            expect(val).not.toBeNull();
+        });
+
+        let fakeCustomEvent: CustomEvent = new CustomEvent('CustomEvent', {
+            detail: {
+                data: fakeShareDataRow,
+                files: [fakeItem]
+            }
+        });
+
+        component.onUploadFiles(fakeCustomEvent);
+    }));
+
 });

ng2-components/ng2-alfresco-upload/src/components/upload-drag-area.component.ts

@@ -67,24 +67,25 @@ export class UploadDragAreaComponent {
 
     /**
      * Handles 'upload-files' events raised by child components.
-     * @param e DOM event
+     * @param event DOM event
      */
-    onUploadFiles(e: CustomEvent) {
-        e.stopPropagation();
-        e.preventDefault();
-        if (this.enabled) {
-            let files: FileInfo[] = e.detail.files;
+    onUploadFiles(event: CustomEvent) {
+        event.stopPropagation();
+        event.preventDefault();
+        let isAllowed: boolean = this.isAllowed(event.detail.data.obj.entry);
+        if (isAllowed) {
+            let files: FileInfo[] = event.detail.files;
             if (files && files.length > 0) {
                 let parentId = this.rootFolderId;
-                if (e.detail.data && e.detail.data.obj.entry.isFolder) {
-                    parentId = e.detail.data.obj.entry.id || this.rootFolderId;
+                if (event.detail.data && event.detail.data.obj.entry.isFolder) {
+                    parentId = event.detail.data.obj.entry.id || this.rootFolderId;
                 }
                 const fileModels = files.map(fileInfo => new FileModel(fileInfo.file, {
                     newVersion: this.versioning,
                     path: fileInfo.relativeFolder,
                     parentId: parentId
                 }));
-                this.uploadFiles(fileModels);
+                this.uploadFiles(fileModels, isAllowed);
             }
         }
     }
@@ -168,8 +169,17 @@ export class UploadDragAreaComponent {
         });
     }
 
-    private uploadFiles(files: FileModel[]): void {
-        if (this.enabled && files.length) {
+    /**
+     * Show the error inside Notification bar
+     * @param Error message
+     * @private
+     */
+    showErrorNotificationBar(errorMessage: string) {
+        this.notificationService.openSnackMessage(errorMessage, 3000);
+    }
+
+    private uploadFiles(files: FileModel[], isAllowed: boolean): void {
+        if (isAllowed && files.length) {
             this.uploadService.addToQueue(...files);
             this.uploadService.uploadFilesInTheQueue(this.onSuccess);
             let latestFilesAdded = this.uploadService.getQueue();
@@ -178,4 +188,17 @@ export class UploadDragAreaComponent {
             }
         }
     }
+
+    private hasCreatePermission(node: any): boolean {
+        let isPermitted = false;
+        if (node && node['allowableOperations']) {
+            let permFound = node['allowableOperations'].find(element => element === 'create');
+            isPermitted = permFound ? true : false;
+        }
+        return isPermitted;
+    }
+
+    private isAllowed(node: any) {
+        return this.enabled || this.hasCreatePermission(node);
+    }
 }