ACS-8761 Noop Auth Module for unit testing ergonomics (#10195)

lib/core/feature-flags/src/lib/services/storage-features.service.spec.ts

@@ -17,7 +17,7 @@
 
 import { TestBed } from '@angular/core/testing';
 import { StorageFeaturesService } from './storage-features.service';
-import { CoreTestingModule, StorageService } from '../../../../src/public-api';
+import { StorageService } from '../../../../src/public-api';
 import { FlagSet, WritableFeaturesServiceConfigToken } from '../interfaces/features.interface';
 import { skip, take } from 'rxjs/operators';
 
@@ -41,7 +41,6 @@ describe('StorageFeaturesService', () => {
 
         beforeEach(() => {
             TestBed.configureTestingModule({
-                imports: [CoreTestingModule],
                 providers: [
                     { provide: StorageService, useValue: mockStorage },
                     {
@@ -49,8 +48,7 @@ describe('StorageFeaturesService', () => {
                         useValue: {
                             storageKey: 'storage-key-test'
                         }
-                    },
-                    StorageFeaturesService
+                    }
                 ]
             });
 
@@ -170,11 +168,6 @@ describe('StorageFeaturesService', () => {
 
     describe('if flags are not present in LocalStorage and no configuration is provided', () => {
         beforeEach(() => {
-            TestBed.configureTestingModule({
-                imports: [CoreTestingModule],
-                providers: [StorageFeaturesService]
-            });
-
             storageFeaturesService = TestBed.inject(StorageFeaturesService);
         });
 

lib/core/feature-flags/src/lib/services/storage-features.service.ts

@@ -30,7 +30,7 @@ import {
 import { FlagSetParser } from './flagset.parser';
 import { StorageService } from '@alfresco/adf-core';
 
-@Injectable()
+@Injectable({ providedIn: 'root' })
 export class StorageFeaturesService implements IFeaturesService, IWritableFeaturesService {
     private currentFlagState: WritableFlagChangeset = {};
     private flags = new BehaviorSubject<WritableFlagChangeset>({});