inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ADF-4441] Save button should be disabled when form fields are invalid (#4817)

Browse Source 
* [ADF-4441] Save button should be disabled when form inputs are invalid, Refactored disable custom outcome buttons unit tests

* [ADF-4441] add missing space

* [ADF-4441] Refactor failing unit tests

* [ADF-4441] Added documentation for disableSaveButton property
This commit is contained in:
arditdomi
2019-06-10 12:01:58 +01:00
committed by Eugenio Romano
parent 3e1092d7bf
commit 4ea656e537
5 changed files with 156 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
lib/process-services-cloud/src/lib/form/components/form-cloud.component.spec.ts
View File

@@ -689,25 +689,48 @@ describe('FormCloudComponent', () => {
});
it('should disable complete outcome button when disableCompleteButton is true', () => {
const formModel = new FormCloud();
const formModel = new FormCloud(cloudFormMock);
formComponent.form = formModel;
formComponent.disableCompleteButton = true;
expect(formModel.isValid).toBeTruthy();
expect(formComponent.form.hasOutcomes()).toBe(true);
const completeOutcome = formComponent.form.outcomes.find((outcome) => outcome.name === FormOutcomeModel.COMPLETE_ACTION);
expect(formComponent.isOutcomeButtonEnabled(completeOutcome)).toBeFalsy();
formComponent.disableCompleteButton = false;
expect(formComponent.isOutcomeButtonEnabled(completeOutcome)).toBeTruthy();
});
it('should disable save outcome button when disableSaveButton is true', () => {
const formModel = new FormCloud(cloudFormMock);
formComponent.form = formModel;
formComponent.disableSaveButton = true;
expect(formModel.isValid).toBeTruthy();
expect(formComponent.form.hasOutcomes()).toBe(true);
const saveOutcome = formComponent.form.outcomes.find((outcome) => outcome.name === FormOutcomeModel.SAVE_ACTION);
expect(formComponent.isOutcomeButtonEnabled(saveOutcome)).toBeFalsy();
formComponent.disableSaveButton = false;
expect(formComponent.isOutcomeButtonEnabled(saveOutcome)).toBeTruthy();
});
it('should disable start process outcome button when disableStartProcessButton is true', () => {
const formModel = new FormCloud();
const formModel = new FormCloud(cloudFormMock);
formComponent.form = formModel;
formComponent.disableStartProcessButton = true;
expect(formModel.isValid).toBeTruthy();
expect(formComponent.form.hasOutcomes()).toBe(true);
const startProcessOutcome = formComponent.form.outcomes.find((outcome) => outcome.name === FormOutcomeModel.START_PROCESS_ACTION);
expect(formComponent.isOutcomeButtonEnabled(startProcessOutcome)).toBeFalsy();
formComponent.disableStartProcessButton = false;
expect(formComponent.isOutcomeButtonEnabled(startProcessOutcome)).toBeTruthy();
});
it('should raise [executeOutcome] event for formService', (done) => {