upload dialog improvements (#1740)

Various upload dialog improvements

- fix: headers alignment
- fix: Name column alignment
- fix: rename ‘CANCEL’ button to ‘Cancel all’ (as it’s what it does)
- fix: ‘Cancel all’ button still visible after all upload complete
- new: improved layout and api for file upload components
- new: strongly typed methods for UploadService
This commit is contained in:
Denys Vuika
2017-03-21 14:45:48 +00:00
committed by Mario Romano
parent 4df72af86d
commit 4ebe1e77b9
12 changed files with 89 additions and 96 deletions

View File

@@ -80,7 +80,7 @@ describe('FileUploadingDialogComponent', () => {
});
it('should render dialog box with css class show when an element is added to Observer', () => {
uploadService.addToQueue([file]);
uploadService.addToQueue([<File> { name: 'file' }]);
component.filesUploadingList = [file];
fixture.detectChanges();
@@ -88,8 +88,8 @@ describe('FileUploadingDialogComponent', () => {
expect(element.querySelector('.file-dialog').getAttribute('class')).toEqual('file-dialog show');
});
it('should render dialog box with css class show when the toggleShowDialog is called', () => {
component.toggleShowDialog();
it('should render dialog box with css class show when the toggleVisible is called', () => {
component.toggleVisible();
fixture.detectChanges();
expect(element.querySelector('.file-dialog').getAttribute('class')).toEqual('file-dialog show');
@@ -98,7 +98,7 @@ describe('FileUploadingDialogComponent', () => {
it('should render dialog box with css class hide', () => {
component.isDialogActive = true;
component.toggleShowDialog();
component.toggleVisible();
fixture.detectChanges();
expect(element.querySelector('.file-dialog').getAttribute('class')).toEqual('file-dialog');
@@ -107,7 +107,7 @@ describe('FileUploadingDialogComponent', () => {
it('should render minimize dialog as default', () => {
component.isDialogActive = true;
component.toggleDialogMinimize();
component.toggleMinimized();
fixture.detectChanges();
expect(element.querySelector('.minimize-button').getAttribute('class')).toEqual('minimize-button active');