From 4ec5548c24962c230da2c19f260a67a2cd9aafb3 Mon Sep 17 00:00:00 2001 From: Eugenio Romano Date: Mon, 6 Nov 2017 17:54:54 +0000 Subject: [PATCH] log service warn fix (#2617) --- .../src/models/log-levels.model.ts | 1 + .../src/services/log.service.spec.ts | 20 +++++++++++++++++++ 2 files changed, 21 insertions(+) diff --git a/ng2-components/ng2-alfresco-core/src/models/log-levels.model.ts b/ng2-components/ng2-alfresco-core/src/models/log-levels.model.ts index 7bab531a56..67682f3915 100644 --- a/ng2-components/ng2-alfresco-core/src/models/log-levels.model.ts +++ b/ng2-components/ng2-alfresco-core/src/models/log-levels.model.ts @@ -28,6 +28,7 @@ export let logLevels: any[] = [ {level: LogLevelsEnum.TRACE, name: 'TRACE'}, {level: LogLevelsEnum.DEBUG, name: 'DEBUG'}, {level: LogLevelsEnum.INFO, name: 'INFO'}, + {level: LogLevelsEnum.WARN, name: 'WARN'}, {level: LogLevelsEnum.ERROR, name: 'ERROR'}, {level: LogLevelsEnum.SILENT, name: 'SILENT'} ]; diff --git a/ng2-components/ng2-alfresco-core/src/services/log.service.spec.ts b/ng2-components/ng2-alfresco-core/src/services/log.service.spec.ts index 365a268a28..14dc5c6cc9 100644 --- a/ng2-components/ng2-alfresco-core/src/services/log.service.spec.ts +++ b/ng2-components/ng2-alfresco-core/src/services/log.service.spec.ts @@ -78,6 +78,26 @@ describe('Log Service', () => { expect(console.trace).not.toHaveBeenCalled(); }); + it('should log only warning and errors if is warning level', () => { + appConfigService.config['logLevel'] = 'WARN'; + providesLogComponent = TestBed.createComponent(ProvidesLogComponent); + + spyOn(console, 'log'); + spyOn(console, 'error'); + spyOn(console, 'trace'); + spyOn(console, 'warn'); + + providesLogComponent.componentInstance.log(); + providesLogComponent.componentInstance.error(); + providesLogComponent.componentInstance.trace(); + providesLogComponent.componentInstance.warn(); + + expect(console.log).not.toHaveBeenCalled(); + expect(console.error).toHaveBeenCalled(); + expect(console.warn).toHaveBeenCalled(); + expect(console.trace).not.toHaveBeenCalled(); + }); + }); @Component({