[ADF-859] add codelyzer in core and datatable (#2056)

* add codelyzer in core and datatable

* add codelyzer in the main build

* order imports

* fix import in test

* fix import test

* import reorder form

* tasklist and processlist import reorder
This commit is contained in:
Eugenio Romano
2017-07-07 10:20:41 +02:00
committed by Eugenio Romano
parent 9870964c0e
commit 53a614bfbf
388 changed files with 9335 additions and 2242 deletions

View File

@@ -15,9 +15,9 @@
* limitations under the License.
*/
import { ComponentFixture, TestBed, async } from '@angular/core/testing';
import { AccordionComponent } from './accordion.component';
import { async, ComponentFixture, TestBed } from '@angular/core/testing';
import { AccordionGroupComponent } from './accordion-group.component';
import { AccordionComponent } from './accordion.component';
describe('AccordionGroupComponent', () => {

View File

@@ -15,7 +15,7 @@
* limitations under the License.
*/
import { Component, Input, OnDestroy, Output, EventEmitter, ViewChild } from '@angular/core';
import { Component, EventEmitter, Input, OnDestroy, Output, ViewChild } from '@angular/core';
import { AccordionComponent } from './accordion.component';
@Component({

View File

@@ -15,9 +15,9 @@
* limitations under the License.
*/
import { ComponentFixture, TestBed, async } from '@angular/core/testing';
import { AccordionComponent } from './accordion.component';
import { async, ComponentFixture, TestBed } from '@angular/core/testing';
import { AccordionGroupComponent } from './accordion-group.component';
import { AccordionComponent } from './accordion.component';
describe('AccordionComponent', () => {

View File

@@ -15,11 +15,11 @@
* limitations under the License.
*/
import { NgModule } from '@angular/core';
import { CommonModule } from '@angular/common';
import { NgModule } from '@angular/core';
import { AccordionComponent } from './accordion.component';
import { AccordionGroupComponent } from './accordion-group.component';
import { AccordionComponent } from './accordion.component';
@NgModule({
imports: [

View File

@@ -15,8 +15,8 @@
* limitations under the License.
*/
import { ContextMenuService } from './context-menu.service';
import { ContextMenuHolderComponent } from './context-menu-holder.component';
import { ContextMenuService } from './context-menu.service';
describe('ContextMenuHolderComponent', () => {

View File

@@ -15,7 +15,7 @@
* limitations under the License.
*/
import { Directive, Input, HostListener } from '@angular/core';
import { Directive, HostListener, Input } from '@angular/core';
import { ContextMenuService } from './context-menu.service';
@Directive({

View File

@@ -15,8 +15,8 @@
* limitations under the License.
*/
import { NgModule } from '@angular/core';
import { CommonModule } from '@angular/common';
import { NgModule } from '@angular/core';
import { ContextMenuHolderComponent } from './context-menu-holder.component';
import { ContextMenuDirective } from './context-menu.directive';

View File

@@ -15,7 +15,7 @@
* limitations under the License.
*/
import { TestBed, async } from '@angular/core/testing';
import { async, TestBed } from '@angular/core/testing';
import { DataColumnListComponent } from './data-column-list.component';
describe('DataColumnListComponent', () => {

View File

@@ -15,7 +15,7 @@
* limitations under the License.
*/
import { TestBed, async } from '@angular/core/testing';
import { async, TestBed } from '@angular/core/testing';
import { DataColumnComponent } from './data-column.component';
describe('DataColumnListComponent', () => {

View File

@@ -15,13 +15,13 @@
* limitations under the License.
*/
import { Component, Input, ContentChild, TemplateRef } from '@angular/core';
import { Component, ContentChild, Input, OnInit, TemplateRef } from '@angular/core';
@Component({
selector: 'data-column',
template: ''
})
export class DataColumnComponent {
export class DataColumnComponent implements OnInit {
@Input()
key: string;

View File

@@ -15,7 +15,7 @@
* limitations under the License.
*/
import { Directive, ElementRef, AfterViewInit } from '@angular/core';
import { AfterViewInit, Directive, ElementRef } from '@angular/core';
declare var componentHandler;

View File

@@ -15,7 +15,7 @@
* limitations under the License.
*/
import { Directive, ElementRef, AfterViewInit } from '@angular/core';
import { AfterViewInit, Directive, ElementRef } from '@angular/core';
declare var componentHandler;

View File

@@ -15,7 +15,7 @@
* limitations under the License.
*/
import { Directive, ElementRef, AfterViewInit } from '@angular/core';
import { AfterViewInit, Directive, ElementRef } from '@angular/core';
declare var componentHandler;

View File

@@ -15,7 +15,7 @@
* limitations under the License.
*/
import { Directive, ElementRef, AfterViewInit } from '@angular/core';
import { AfterViewInit, Directive, ElementRef } from '@angular/core';
declare var componentHandler;

View File

@@ -15,13 +15,13 @@
* limitations under the License.
*/
import { Directive, AfterViewInit } from '@angular/core';
import { AfterViewInit, Directive } from '@angular/core';
declare var componentHandler;
@Directive({
selector: '[mdl]'
})
export class MDL implements AfterViewInit {
export class MDLDirective implements AfterViewInit {
ngAfterViewInit() {
componentHandler.upgradeAllRegistered();
}

View File

@@ -15,7 +15,7 @@
* limitations under the License.
*/
import { Component, Input, ChangeDetectionStrategy, ViewEncapsulation } from '@angular/core';
import { ChangeDetectionStrategy, Component, Input, ViewEncapsulation } from '@angular/core';
@Component({
selector: 'adf-toolbar',

View File

@@ -15,20 +15,20 @@
* limitations under the License.
*/
import { ComponentFixture, TestBed, async } from '@angular/core/testing';
import { CardView } from './adf-card-view.component';
import { CardViewModel } from '../../models/card-view.model';
import { async, ComponentFixture, TestBed } from '@angular/core/testing';
import { By } from '@angular/platform-browser';
import { CardViewModel } from '../../models/card-view.model';
import { CardViewComponent } from './adf-card-view.component';
describe('AdfCardView', () => {
let fixture: ComponentFixture<CardView>;
let component: CardView;
let fixture: ComponentFixture<CardViewComponent>;
let component: CardViewComponent;
beforeEach(async(() => {
TestBed.configureTestingModule({
declarations: [
CardView
CardViewComponent
],
providers: [
]
@@ -36,7 +36,7 @@ describe('AdfCardView', () => {
}));
beforeEach(() => {
fixture = TestBed.createComponent(CardView);
fixture = TestBed.createComponent(CardViewComponent);
component = fixture.componentInstance;
});

View File

@@ -16,15 +16,15 @@
*/
import { Component, Input } from '@angular/core';
import { CardViewModel } from '../../models/card-view.model';
import * as moment from 'moment';
import { CardViewModel } from '../../models/card-view.model';
@Component({
selector: 'adf-card-view',
templateUrl: './adf-card-view.component.html',
styleUrls: ['./adf-card-view.component.css']
})
export class CardView {
export class CardViewComponent {
@Input()
properties: CardViewModel [];

View File

@@ -15,19 +15,19 @@
* limitations under the License.
*/
import { NgModule } from '@angular/core';
import { CommonModule } from '@angular/common';
import { CardView } from './adf-card-view.component';
import { NgModule } from '@angular/core';
import { CardViewComponent } from './adf-card-view.component';
@NgModule({
imports: [
CommonModule
],
declarations: [
CardView
CardViewComponent
],
exports: [
CardView
CardViewComponent
]
})
export class CardViewModule {}

View File

@@ -16,8 +16,8 @@
*/
import { ElementRef } from '@angular/core';
import { UploadDirective } from './upload.directive';
import { FileInfo } from './../utils/file-utils';
import { UploadDirective } from './upload.directive';
describe('UploadDirective', () => {

View File

@@ -15,8 +15,8 @@
* limitations under the License.
*/
import { Directive, Input, HostListener, ElementRef, Renderer, OnInit, NgZone, OnDestroy } from '@angular/core';
import { FileUtils, FileInfo } from '../utils/file-utils';
import { Directive, ElementRef, HostListener, Input, NgZone, OnDestroy, OnInit, Renderer } from '@angular/core';
import { FileInfo, FileUtils } from '../utils/file-utils';
@Directive({
selector: '[adf-upload]'

View File

@@ -16,7 +16,7 @@
*/
import { NgModule } from '@angular/core';
import { MdSnackBarModule, MdToolbarModule, MdButtonModule } from '@angular/material';
import { MdButtonModule, MdSnackBarModule, MdToolbarModule } from '@angular/material';
export function modules() {
return [

View File

@@ -16,8 +16,8 @@
*/
import { Injectable } from '@angular/core';
import { AlfrescoApi } from 'alfresco-js-api';
import * as alfrescoApi from 'alfresco-js-api';
import { AlfrescoApi } from 'alfresco-js-api';
import * as alfrescoApi from 'alfresco-js-api';
import { AlfrescoSettingsService } from './alfresco-settings.service';
import { AppConfigService } from './app-config.service';
import { StorageService } from './storage.service';

View File

@@ -15,15 +15,15 @@
* limitations under the License.
*/
import { TestBed, async } from '@angular/core/testing';
import { AlfrescoSettingsService } from './alfresco-settings.service';
import { AlfrescoAuthenticationService } from './alfresco-authentication.service';
import { AlfrescoApiService } from './alfresco-api.service';
import { StorageService } from './storage.service';
import { CookieService } from './cookie.service';
import { async, TestBed } from '@angular/core/testing';
import { CookieServiceMock } from './../assets/cookie.service.mock';
import { LogService } from './log.service';
import { AlfrescoApiService } from './alfresco-api.service';
import { AlfrescoAuthenticationService } from './alfresco-authentication.service';
import { AlfrescoSettingsService } from './alfresco-settings.service';
import { AppConfigModule } from './app-config.service';
import { CookieService } from './cookie.service';
import { LogService } from './log.service';
import { StorageService } from './storage.service';
declare let jasmine: any;

View File

@@ -17,11 +17,11 @@
import { Injectable } from '@angular/core';
import { Observable, Subject } from 'rxjs/Rx';
import { AlfrescoApiService } from './alfresco-api.service';
import { AlfrescoSettingsService } from './alfresco-settings.service';
import { StorageService } from './storage.service';
import { CookieService } from './cookie.service';
import { LogService } from './log.service';
import { AlfrescoApiService } from './alfresco-api.service';
import { StorageService } from './storage.service';
const REMEMBER_ME_COOKIE_KEY = 'ALFRESCO_REMEMBER_ME';
const REMEMBER_ME_UNTIL = 1000 * 60 * 60 * 24 * 30 ;

View File

@@ -15,16 +15,16 @@
* limitations under the License.
*/
import { TestBed, async } from '@angular/core/testing';
import { AlfrescoSettingsService } from './alfresco-settings.service';
import { async, TestBed } from '@angular/core/testing';
import { CookieServiceMock } from './../assets/cookie.service.mock';
import { AlfrescoApiService } from './alfresco-api.service';
import { AlfrescoAuthenticationService } from './alfresco-authentication.service';
import { AlfrescoContentService } from './alfresco-content.service';
import { AlfrescoApiService } from './alfresco-api.service';
import { StorageService } from './storage.service';
import { CookieService } from './cookie.service';
import { CookieServiceMock } from './../assets/cookie.service.mock';
import { LogService } from './log.service';
import { AlfrescoSettingsService } from './alfresco-settings.service';
import { AppConfigModule } from './app-config.service';
import { CookieService } from './cookie.service';
import { LogService } from './log.service';
import { StorageService } from './storage.service';
declare let jasmine: any;

View File

@@ -17,10 +17,10 @@
import { Injectable } from '@angular/core';
import { Observable, Subject } from 'rxjs/Rx';
import { AlfrescoAuthenticationService } from './alfresco-authentication.service';
import { AlfrescoApiService } from './alfresco-api.service';
import { LogService } from './log.service';
import { FolderCreatedEvent } from '../events/folder-created.event';
import { AlfrescoApiService } from './alfresco-api.service';
import { AlfrescoAuthenticationService } from './alfresco-authentication.service';
import { LogService } from './log.service';
@Injectable()
export class AlfrescoContentService {

View File

@@ -15,9 +15,9 @@
* limitations under the License.
*/
import { TestBed, async } from '@angular/core/testing';
import { AppConfigModule } from './app-config.service';
import { async, TestBed } from '@angular/core/testing';
import { AlfrescoSettingsService } from './alfresco-settings.service';
import { AppConfigModule } from './app-config.service';
describe('AlfrescoSettingsService', () => {

View File

@@ -16,9 +16,9 @@
*/
import { Injectable } from '@angular/core';
import { Response, Http } from '@angular/http';
import { Observable } from 'rxjs/Rx';
import { Http, Response } from '@angular/http';
import { TranslateLoader } from '@ngx-translate/core';
import { Observable } from 'rxjs/Rx';
import { ComponentTranslationModel } from '../models/component.model';
import { LogService } from './log.service';

View File

@@ -15,11 +15,11 @@
* limitations under the License.
*/
import { TranslateModule, TranslateLoader } from '@ngx-translate/core';
import { Injector } from '@angular/core';
import { ResponseOptions, Response, XHRBackend, HttpModule } from '@angular/http';
import { MockBackend, MockConnection } from '@angular/http/testing';
import {getTestBed, TestBed} from '@angular/core/testing';
import { HttpModule, Response, ResponseOptions, XHRBackend } from '@angular/http';
import { MockBackend, MockConnection } from '@angular/http/testing';
import { TranslateLoader, TranslateModule } from '@ngx-translate/core';
import { AlfrescoTranslateLoader } from './alfresco-translate-loader.service';
import { AlfrescoTranslationService } from './alfresco-translation.service';

View File

@@ -15,14 +15,14 @@
* limitations under the License.
*/
import { TranslateModule, TranslateLoader } from '@ngx-translate/core';
import { Injector } from '@angular/core';
import { ResponseOptions, Response, XHRBackend, HttpModule } from '@angular/http';
import { MockBackend, MockConnection } from '@angular/http/testing';
import { getTestBed, TestBed } from '@angular/core/testing';
import { HttpModule, Response, ResponseOptions, XHRBackend } from '@angular/http';
import { MockBackend, MockConnection } from '@angular/http/testing';
import { TranslateLoader, TranslateModule } from '@ngx-translate/core';
import { AlfrescoTranslationService } from './alfresco-translation.service';
import { AlfrescoTranslateLoader } from './alfresco-translate-loader.service';
import { AlfrescoTranslationService } from './alfresco-translation.service';
import { LogService } from './log.service';
const mockBackendResponse = (connection: MockConnection, response: string) => {

View File

@@ -16,8 +16,8 @@
*/
import { Injectable } from '@angular/core';
import { Observable } from 'rxjs/Rx';
import { TranslateService } from '@ngx-translate/core';
import { Observable } from 'rxjs/Rx';
import { AlfrescoTranslateLoader } from './alfresco-translate-loader.service';
@Injectable()

View File

@@ -15,8 +15,8 @@
* limitations under the License.
*/
import { TestBed, inject } from '@angular/core/testing';
import { HttpModule, XHRBackend, Response, ResponseOptions } from '@angular/http';
import { inject, TestBed } from '@angular/core/testing';
import { HttpModule, Response, ResponseOptions, XHRBackend } from '@angular/http';
import { MockBackend, MockConnection } from '@angular/http/testing';
import { AppConfigModule, AppConfigService } from './app-config.service';

View File

@@ -15,8 +15,8 @@
* limitations under the License.
*/
import { Injectable, APP_INITIALIZER, NgModule, ModuleWithProviders } from '@angular/core';
import { HttpModule, Http } from '@angular/http';
import { APP_INITIALIZER, Injectable, ModuleWithProviders, NgModule } from '@angular/core';
import { Http, HttpModule } from '@angular/http';
import { ObjectUtils } from '../utils/object-utils';
@Injectable()

View File

@@ -15,19 +15,19 @@
* limitations under the License.
*/
import { TestBed, async, inject } from '@angular/core/testing';
import { async, inject, TestBed } from '@angular/core/testing';
import { Router} from '@angular/router';
import { RouterTestingModule } from '@angular/router/testing';
import { AlfrescoSettingsService } from './alfresco-settings.service';
import { AlfrescoAuthenticationService } from './alfresco-authentication.service';
import { AlfrescoApiService } from './alfresco-api.service';
import { StorageService } from './storage.service';
import { LogService } from './log.service';
import { CookieService } from './cookie.service';
import { CookieServiceMock } from './../assets/cookie.service.mock';
import { AuthGuardBpm } from './auth-guard-bpm.service';
import { AlfrescoApiService } from './alfresco-api.service';
import { AlfrescoAuthenticationService } from './alfresco-authentication.service';
import { AlfrescoSettingsService } from './alfresco-settings.service';
import { AppConfigModule } from './app-config.service';
import { AuthGuardBpm } from './auth-guard-bpm.service';
import { CookieService } from './cookie.service';
import { LogService } from './log.service';
import { StorageService } from './storage.service';
describe('AuthGuardService BPM', () => {

View File

@@ -17,8 +17,8 @@
import { Injectable } from '@angular/core';
import {
CanActivate, Router, CanActivateChild,
ActivatedRouteSnapshot,
ActivatedRouteSnapshot, CanActivate, CanActivateChild,
Router,
RouterStateSnapshot
} from '@angular/router';

View File

@@ -15,19 +15,19 @@
* limitations under the License.
*/
import { TestBed, async, inject } from '@angular/core/testing';
import { async, inject, TestBed } from '@angular/core/testing';
import { Router} from '@angular/router';
import { RouterTestingModule } from '@angular/router/testing';
import { AlfrescoSettingsService } from './alfresco-settings.service';
import { AlfrescoAuthenticationService } from './alfresco-authentication.service';
import { AlfrescoApiService } from './alfresco-api.service';
import { StorageService } from './storage.service';
import { CookieService } from './cookie.service';
import { CookieServiceMock } from './../assets/cookie.service.mock';
import { LogService } from './log.service';
import { AuthGuardEcm } from './auth-guard-ecm.service';
import { AlfrescoApiService } from './alfresco-api.service';
import { AlfrescoAuthenticationService } from './alfresco-authentication.service';
import { AlfrescoSettingsService } from './alfresco-settings.service';
import { AppConfigModule } from './app-config.service';
import { AuthGuardEcm } from './auth-guard-ecm.service';
import { CookieService } from './cookie.service';
import { LogService } from './log.service';
import { StorageService } from './storage.service';
describe('AuthGuardService ECM', () => {

View File

@@ -17,8 +17,8 @@
import { Injectable } from '@angular/core';
import {
CanActivate, Router, CanActivateChild,
ActivatedRouteSnapshot,
ActivatedRouteSnapshot, CanActivate, CanActivateChild,
Router,
RouterStateSnapshot
} from '@angular/router';

View File

@@ -15,19 +15,19 @@
* limitations under the License.
*/
import { TestBed, async, inject } from '@angular/core/testing';
import { async, inject, TestBed } from '@angular/core/testing';
import { Router} from '@angular/router';
import { RouterTestingModule } from '@angular/router/testing';
import { AlfrescoSettingsService } from './alfresco-settings.service';
import { AlfrescoAuthenticationService } from './alfresco-authentication.service';
import { AlfrescoApiService } from './alfresco-api.service';
import { StorageService } from './storage.service';
import { CookieService } from './cookie.service';
import { CookieServiceMock } from './../assets/cookie.service.mock';
import { LogService } from './log.service';
import { AuthGuard } from './auth-guard.service';
import { AlfrescoApiService } from './alfresco-api.service';
import { AlfrescoAuthenticationService } from './alfresco-authentication.service';
import { AlfrescoSettingsService } from './alfresco-settings.service';
import { AppConfigModule } from './app-config.service';
import { AuthGuard } from './auth-guard.service';
import { CookieService } from './cookie.service';
import { LogService } from './log.service';
import { StorageService } from './storage.service';
describe('AuthGuardService', () => {

View File

@@ -17,8 +17,8 @@
import { Injectable } from '@angular/core';
import {
CanActivate, Router, CanActivateChild,
ActivatedRouteSnapshot,
ActivatedRouteSnapshot, CanActivate, CanActivateChild,
Router,
RouterStateSnapshot
} from '@angular/router';

View File

@@ -15,11 +15,11 @@
* limitations under the License.
*/
import { async, ComponentFixture, TestBed } from '@angular/core/testing';
import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
import { Component } from '@angular/core';
import { async, ComponentFixture, TestBed } from '@angular/core/testing';
import { LiveAnnouncer, MdSnackBar, MdSnackBarModule, OVERLAY_PROVIDERS, OverlayModule } from '@angular/material';
import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
import { NotificationService } from './notification.service';
import { MdSnackBarModule, MdSnackBar, OverlayModule, OVERLAY_PROVIDERS, LiveAnnouncer } from '@angular/material';
describe('NotificationService', () => {
let fixture: ComponentFixture<ComponentThatProvidesNotificationService>;

View File

@@ -15,14 +15,14 @@
* limitations under the License.
*/
import { TestBed, async } from '@angular/core/testing';
import { AlfrescoApiService } from './alfresco-api.service';
import { RenditionsService } from './renditions.service';
import { AlfrescoSettingsService } from './alfresco-settings.service';
import { StorageService } from './storage.service';
import { LogService } from './log.service';
import { async, TestBed } from '@angular/core/testing';
import { fakeRedition, fakeReditionCreated, fakeReditionsList } from '../assets/renditionsService.mock';
import { AlfrescoApiService } from './alfresco-api.service';
import { AlfrescoSettingsService } from './alfresco-settings.service';
import { AppConfigModule } from './app-config.service';
import { LogService } from './log.service';
import { RenditionsService } from './renditions.service';
import { StorageService } from './storage.service';
declare let jasmine: any;

View File

@@ -42,7 +42,7 @@ export class RenditionsService {
}
observer.next(isAvailable);
observer.complete();
}, () => {
}, () => {
observer.next(false);
observer.complete();
});
@@ -54,7 +54,7 @@ export class RenditionsService {
this.getRendition(nodeId, encoding).subscribe(() => {
observer.next(true);
observer.complete();
}, () => {
}, () => {
observer.next(false);
observer.complete();
});

View File

@@ -15,18 +15,18 @@
* limitations under the License.
*/
import { TestBed, async } from '@angular/core/testing';
import { async, TestBed } from '@angular/core/testing';
import { HttpModule } from '@angular/http';
import { ThumbnailService } from './thumbnail.service';
import { AlfrescoContentService } from './alfresco-content.service';
import { CookieServiceMock } from './../assets/cookie.service.mock';
import { AlfrescoApiService } from './alfresco-api.service';
import { AlfrescoAuthenticationService } from './alfresco-authentication.service';
import { AlfrescoContentService } from './alfresco-content.service';
import { AlfrescoSettingsService } from './alfresco-settings.service';
import { AppConfigService } from './app-config.service';
import { LogService } from './log.service';
import { AlfrescoApiService } from './alfresco-api.service';
import { StorageService } from './storage.service';
import { CookieService } from './cookie.service';
import { CookieServiceMock } from './../assets/cookie.service.mock';
import { LogService } from './log.service';
import { StorageService } from './storage.service';
import { ThumbnailService } from './thumbnail.service';
describe('ThumbnailService', () => {

View File

@@ -15,7 +15,7 @@
* limitations under the License.
*/
import { TestBed, async } from '@angular/core/testing';
import { async, TestBed } from '@angular/core/testing';
import { AppConfigModule } from './app-config.service';
import { StorageService } from './storage.service';
import { UserPreferencesService } from './user-preferences.service';