inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

AAE-21233 Enable no angular material selectors rule for adf (#9430)

Browse Source 
* AAE-20779 enable material selectors rule

* AAE-20779 fixes in units in already covered libs

* AAE-20779 simplified local package linking
This commit is contained in:
Wojciech Duda
2024-04-09 17:08:51 +02:00
committed by GitHub
parent d45a02042e
commit 5494aa8728
8 changed files with 64 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
lib/core/src/lib/datatable/components/icon-cell/icon-cell.component.spec.ts
View File

@@ -20,20 +20,23 @@ import { ComponentFixture, TestBed } from '@angular/core/testing';
import { IconCellComponent } from './icon-cell.component';
import { ObjectDataTableAdapter } from '../../data/object-datatable-adapter';
import { ObjectDataColumn } from '../../data/object-datacolumn.model';
import { HarnessLoader } from '@angular/cdk/testing';
import { TestbedHarnessEnvironment } from '@angular/cdk/testing/testbed';
import { MatIconHarness } from '@angular/material/icon/testing';
describe('IconCellComponent', () => {
let component: IconCellComponent;
let fixture: ComponentFixture<IconCellComponent>;
const getIconElement = () => fixture.debugElement.nativeElement.querySelector('mat-icon');
const renderAndCheckResult = (value: any, expectedOccurrence: boolean, expectedIconName?: string) => {
let loader: HarnessLoader;
const renderAndCheckResult = async (value: any, expectedOccurrence: boolean, expectedIconName?: string) => {
component.value$.next(value);
fixture.detectChanges();
const iconElement = getIconElement();
const icon = await loader.getHarnessOrNull(MatIconHarness);
expectedOccurrence ? expect(iconElement).toBeTruthy() : expect(iconElement).toBeFalsy();
expectedOccurrence ? expect(icon).not.toBeNull() : expect(icon).toBeNull();
if (expectedIconName) {
expect(iconElement.textContent.trim()).toBe(expectedIconName);
expect(await icon?.getName()).toBe(expectedIconName);
}
};
@@ -44,6 +47,7 @@ describe('IconCellComponent', () => {
fixture = TestBed.createComponent(IconCellComponent);
component = fixture.componentInstance;
loader = TestbedHarnessEnvironment.loader(fixture);
});
describe('Initialization', () => {
@@ -80,23 +84,23 @@ describe('IconCellComponent', () => {
});
describe('UI', () => {
it('should render icon element in case of non-empty string (icon name validation NOT included)', () => {
renderAndCheckResult('group', true, 'group');
renderAndCheckResult('groupe', true, 'groupe');
renderAndCheckResult('0', true, '0');
renderAndCheckResult('false', true, 'false');
it('should render icon element in case of non-empty string (icon name validation NOT included)', async () => {
await renderAndCheckResult('group', true, 'group');
await renderAndCheckResult('groupe', true, 'groupe');
await renderAndCheckResult('0', true, '0');
await renderAndCheckResult('false', true, 'false');
});
it('should NOT render icon element in case of empty string', () => {
renderAndCheckResult('', false);
it('should NOT render icon element in case of empty string', async () => {
await renderAndCheckResult('', false);
});
it('should NOT render icon element in case of type different than string', () => {
renderAndCheckResult(0, false);
renderAndCheckResult({}, false);
renderAndCheckResult(null, false);
renderAndCheckResult(undefined, false);
renderAndCheckResult(NaN, false);
it('should NOT render icon element in case of type different than string', async () => {
await renderAndCheckResult(0, false);
await renderAndCheckResult({}, false);
await renderAndCheckResult(null, false);
await renderAndCheckResult(undefined, false);
await renderAndCheckResult(NaN, false);
});
});
});

25
lib/core/src/lib/dialogs/unsaved-changes-dialog/unsaved-changes-dialog.component.spec.ts
View File

@@ -36,12 +36,10 @@ describe('UnsavedChangesDialog', () => {
let closeIconButton: DebugElement;
beforeEach(() => {
closeIconButton = fixture.debugElement.query(By.css(
'[data-automation-id="adf-unsaved-changes-dialog-close-button"]'
));
closeIconButton = fixture.debugElement.query(By.css('[data-automation-id="adf-unsaved-changes-dialog-close-button"]'));
});
it('should have assigned mat-dialog-close with false as result', () => {
it('should have assigned dialog close button with false as result', () => {
expect(closeIconButton.injector.get(MatDialogClose).dialogResult).toBeFalse();
});
@@ -51,18 +49,21 @@ describe('UnsavedChangesDialog', () => {
});
describe('Cancel button', () => {
it('should have assigned mat-dialog-close with false as result', () => {
expect(fixture.debugElement.query(By.css(
'[data-automation-id="adf-unsaved-changes-dialog-cancel-button"]'
)).injector.get(MatDialogClose).dialogResult).toBeFalse();
it('should have assigned dialog close button with false as result', () => {
expect(
fixture.debugElement.query(By.css('[data-automation-id="adf-unsaved-changes-dialog-cancel-button"]')).injector.get(MatDialogClose)
.dialogResult
).toBeFalse();
});
});
describe('Discard changes button', () => {
it('should have assigned mat-dialog-close with true as result', () => {
expect(fixture.debugElement.query(By.css(
'[data-automation-id="adf-unsaved-changes-dialog-discard-changes-button"]'
)).injector.get(MatDialogClose).dialogResult).toBeTrue();
it('should have assigned dialog close button with true as result', () => {
expect(
fixture.debugElement
.query(By.css('[data-automation-id="adf-unsaved-changes-dialog-discard-changes-button"]'))
.injector.get(MatDialogClose).dialogResult
).toBeTrue();
});
});
});