inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ADF-5204] Metadata - Error message still appears after exiting Edit form (#5922)

Browse Source 
* show error only in editable mode

* reset errors when reset value

* update tests
This commit is contained in:
Cilibiu Bogdan
2020-07-29 11:27:17 +03:00
committed by GitHub
parent 1581cfc662
commit 54df083311
3 changed files with 37 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/core/card-view/components/card-view-textitem/card-view-textitem.component.html
View File

@@ -53,7 +53,7 @@
<mat-error [attr.data-automation-id]="'card-textitem-error-' + property.key"
class="adf-textitem-editable-error"
*ngIf="hasErrors">
*ngIf="isEditable && hasErrors">
<ul>
<li *ngFor="let error of errors">{{ error.message | translate: error }}</li>
</ul>

34
lib/core/card-view/components/card-view-textitem/card-view-textitem.component.spec.ts
View File

@@ -454,6 +454,40 @@ describe('CardViewTextItemComponent', () => {
expect(component.errors).toBe(expectedErrorMessages);
});
it('should render the error when the editedValue is invalid', async () => {
const expectedErrorMessages = [{ message: 'Something went wrong' } as CardViewItemValidator];
component.property.isValid = () => false;
component.property.getValidationErrors = () => expectedErrorMessages;
component.editable = true;
component.ngOnChanges();
fixture.detectChanges();
await fixture.whenStable();
updateTextField(component.property.key, 'updated-value');
const errorMessage = fixture.debugElement.nativeElement.querySelector('.adf-textitem-editable-error').textContent;
expect(errorMessage).toBe('Something went wrong');
});
it('should reset erros when exiting editable mode', async () => {
let errorMessage: string;
const expectedErrorMessages = [{ message: 'Something went wrong' } as CardViewItemValidator];
component.property.isValid = () => false;
component.property.getValidationErrors = () => expectedErrorMessages;
component.editable = true;
component.ngOnChanges();
fixture.detectChanges();
await fixture.whenStable();
updateTextField(component.property.key, 'updated-value');
component.editable = false;
component.ngOnChanges();
fixture.detectChanges();
errorMessage = fixture.debugElement.nativeElement.querySelector('.adf-textitem-editable-error');
expect(errorMessage).toBe(null);
expect(component.errors).toEqual([]);
});
it('should update the property value after a successful update attempt', async () => {
component.property.isValid = () => true;
component.update();

2
lib/core/card-view/components/card-view-textitem/card-view-textitem.component.ts
View File

@@ -90,6 +90,8 @@ export class CardViewTextItemComponent extends BaseCardView<CardViewTextItemMode
} else {
this.editedValue = this.property.displayValue;
}
this.resetErrorMessages();
}
private resetErrorMessages() {