inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-31 17:38:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix typos in component properties (#1560)

Browse Source 
* Fix typo `fallbackThubnail` -> `fallbackThumbnail`

* Fix typo `showUdoNotificationBar` -> `showNotificationBar`

Update upload mis-spelled properties to 'showNotificationBar' since
showUndoNotificationBar is already a method on the drag area component

Refs #1559

* Fix test cases
This commit is contained in:
Will Abson
2017-01-28 14:52:23 +00:00
committed by Mario Romano
parent 09b98e7071
commit 5519f9fb00
9 changed files with 23 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ng2-components/ng2-alfresco-upload/src/components/upload-button.component.ts
View File

@@ -26,7 +26,7 @@ declare let componentHandler: any;
const ERROR_FOLDER_ALREADY_EXIST = 409;
/**
* <alfresco-upload-button [showUdoNotificationBar]="boolean"
* <alfresco-upload-button [showNotificationBar]="boolean"
* [uploadFolders]="boolean"
* [multipleFiles]="boolean"
* [acceptedFilesType]="string"
@@ -35,7 +35,7 @@ const ERROR_FOLDER_ALREADY_EXIST = 409;
*
* This component, provide a set of buttons to upload files to alfresco.
*
* @InputParam {boolean} [true] showUdoNotificationBar - hide/show notification bar.
* @InputParam {boolean} [true] showNotificationBar - hide/show notification bar.
* @InputParam {boolean} [false] versioning - true to indicate that a major version should be created
* @InputParam {boolean} [false] uploadFolders - allow/disallow upload folders (only for chrome).
* @InputParam {boolean} [false] multipleFiles - allow/disallow multiple files.
@@ -56,7 +56,7 @@ export class UploadButtonComponent {
private static DEFAULT_ROOT_ID: string = '-root-';
@Input()
showUdoNotificationBar: boolean = true;
showNotificationBar: boolean = true;
@Input()
uploadFolders: boolean = false;
@@ -160,7 +160,7 @@ export class UploadButtonComponent {
if (files.length) {
let latestFilesAdded = this.uploadService.addToQueue(files);
this.uploadService.uploadFilesInTheQueue(this.rootFolderId, path, this.onSuccess);
if (this.showUdoNotificationBar) {
if (this.showNotificationBar) {
this._showUndoNotificationBar(latestFilesAdded);
}
}

10
ng2-components/ng2-alfresco-upload/src/components/upload-drag-area.component.spec.ts
View File

@@ -66,7 +66,7 @@ describe('UploadDragAreaComponent', () => {
});
it('should show an folder non supported error in console when the file type is empty', () => {
component.showUdoNotificationBar = false;
component.showNotificationBar = false;
spyOn(logService, 'error');
let fileFake = new File([''], 'folder-fake', {type: ''});
@@ -77,7 +77,7 @@ describe('UploadDragAreaComponent', () => {
it('should show an folder non supported error in the notification bar when the file type is empty', () => {
component.showErrorNotificationBar = jasmine.createSpy('_showErrorNotificationBar');
component.showUdoNotificationBar = true;
component.showNotificationBar = true;
let fileFake = new File([''], 'folder-fake', {type: ''});
component.onFilesDropped([fileFake]);
@@ -88,7 +88,7 @@ describe('UploadDragAreaComponent', () => {
it('should upload the list of files dropped', () => {
component.currentFolderPath = '/root-fake-/sites-fake/folder-fake';
component.onSuccess = null;
component.showUdoNotificationBar = false;
component.showNotificationBar = false;
uploadService.addToQueue = jasmine.createSpy('addToQueue');
uploadService.uploadFilesInTheQueue = jasmine.createSpy('uploadFilesInTheQueue');
@@ -104,7 +104,7 @@ describe('UploadDragAreaComponent', () => {
it('should show the loading messages in the notification bar when the files are dropped', () => {
component.currentFolderPath = '/root-fake-/sites-fake/folder-fake';
component.onSuccess = null;
component.showUdoNotificationBar = true;
component.showNotificationBar = true;
uploadService.uploadFilesInTheQueue = jasmine.createSpy('uploadFilesInTheQueue');
component.showUndoNotificationBar = jasmine.createSpy('_showUndoNotificationBar');
@@ -166,7 +166,7 @@ describe('UploadDragAreaComponent', () => {
xit('should throws an exception and show it in the notification bar when the folder already exist', done => {
component.currentFolderPath = '/root-fake-/sites-fake/folder-fake';
component.showUdoNotificationBar = true;
component.showNotificationBar = true;
fixture.detectChanges();
let fakeRest = {

10
ng2-components/ng2-alfresco-upload/src/components/upload-drag-area.component.ts
View File

@@ -44,7 +44,7 @@ export class UploadDragAreaComponent {
private static DEFAULT_ROOT_ID: string = '-root-';
@Input()
showUdoNotificationBar: boolean = true;
showNotificationBar: boolean = true;
@Input()
versioning: boolean = false;
@@ -83,13 +83,13 @@ export class UploadDragAreaComponent {
this.uploadService.addToQueue(files);
this.uploadService.uploadFilesInTheQueue(this.rootFolderId, this.currentFolderPath, this.onSuccess);
let latestFilesAdded = this.uploadService.getQueue();
if (this.showUdoNotificationBar) {
if (this.showNotificationBar) {
this.showUndoNotificationBar(latestFilesAdded);
}
} else {
let errorMessage: any;
errorMessage = this.translateService.get('FILE_UPLOAD.MESSAGES.FOLDER_NOT_SUPPORTED');
if (this.showUdoNotificationBar) {
if (this.showNotificationBar) {
this.showErrorNotificationBar(errorMessage.value);
} else {
this.logService.error(errorMessage.value);
@@ -143,7 +143,7 @@ export class UploadDragAreaComponent {
for (let i = 0; i < entries.length; i++) {
this._traverseFileTree(entries[i]);
}
if (this.showUdoNotificationBar) {
if (this.showNotificationBar) {
let latestFilesAdded = this.uploadService.getQueue();
this.showUndoNotificationBar(latestFilesAdded);
}
@@ -152,7 +152,7 @@ export class UploadDragAreaComponent {
error => {
let errorMessagePlaceholder = this.getErrorMessage(error.response);
let errorMessage = this.formatString(errorMessagePlaceholder, [folder.name]);
if (this.showUdoNotificationBar) {
if (this.showNotificationBar) {
this.showErrorNotificationBar(errorMessage);
} else {
this.logService.error(errorMessage);