[MIGRATION] - Something happened on the way to heaven

lib/testing/src/lib/protractor/core/actions/identity/group-identity.service.ts

@@ -22,7 +22,6 @@ import { Logger } from '../../utils/logger';
 import { browser } from 'protractor';
 
 export class GroupIdentityService {
-
     api: ApiService;
 
     constructor(api: ApiService) {
@@ -75,9 +74,11 @@ export class GroupIdentityService {
 
                 Logger.log(`Data ${JSON.stringify(data)}`);
 
-                return data[0];                Logger.error('Group not found');
-
+                return data[0];
+                Logger.error('Group not found');
             } catch (error) {
+                Logger.error('Group not found');
+                return null;
             }
         };
 
@@ -135,5 +136,4 @@ export class GroupIdentityService {
         const data = await this.api.performIdentityOperation(path, method, queryParams, postBody);
         return data[0].id;
     }
-
 }

lib/testing/src/lib/protractor/core/pages/data-table-component.page.ts

@@ -388,7 +388,9 @@ export class DataTableComponentPage {
                     this.rootElement.element(by.tagName(materialLocators.Progress.spinner.root)),
                     MAX_LOADING_TIME
                 );
-            } catch (error) {}
+            } catch (error) {
+                Logger.error('Loading spinner is not present');
+            }
 
             if (await this.isEmpty()) {
                 Logger.log('empty page');
@@ -414,7 +416,9 @@ export class DataTableComponentPage {
             try {
                 Logger.log('wait datatable loading spinner is present');
                 await BrowserVisibility.waitUntilElementIsVisible(element(by.tagName(materialLocators.Progress.bar.root)));
-            } catch (error) {}
+            } catch (error) {
+                Logger.error('Infinite pagination spinner is not present');
+            }
             if (await this.isEmpty()) {
                 Logger.log('empty page');
             } else {

lib/testing/src/lib/protractor/core/pages/login.page.ts

@@ -43,6 +43,7 @@ export class LoginPage {
         try {
             currentUrl = await browser.getCurrentUrl();
         } catch (e) {
+            /* do nothing */
         }
 
         if (!currentUrl || currentUrl.indexOf(this.loginUrl) === -1) {
@@ -87,7 +88,7 @@ export class LoginPage {
         if (oauth2 && oauth2.silentLogin === false) {
             Logger.log(`Login SSO`);
             await this.clickOnSSOButton();
-        }else{
+        } else {
             Logger.log(`Login SSO silent login`);
         }
 

lib/testing/src/lib/protractor/core/pages/viewer.page.ts

@@ -75,7 +75,9 @@ export class ViewerPage {
                 Logger.log('wait spinner is present');
                 await BrowserVisibility.waitUntilElementIsVisible(element(by.tagName(materialLocators.Progress.spinner.root)));
                 await BrowserVisibility.waitUntilElementIsNotVisible(element(by.tagName(materialLocators.Progress.spinner.root)), MAX_LOADING_TIME);
-            } catch (error) {}
+            } catch (error) {
+                Logger.error('Spinner is not present');
+            }
         }
     }