From 56ad656c914063307e395fedb4544fa0fc16efe5 Mon Sep 17 00:00:00 2001
From: Will Abson <will.abson@alfresco.com>
Date: Fri, 4 Nov 2016 17:12:51 +0000
Subject: [PATCH] Add placeholder text in process type select control

Refs #730
---
 .../src/components/activiti-start-process.component.html      | 1 +
 .../src/components/activiti-start-process.component.spec.ts   | 4 ++--
 ng2-components/ng2-activiti-processlist/src/i18n/en.json      | 1 +
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/ng2-components/ng2-activiti-processlist/src/components/activiti-start-process.component.html b/ng2-components/ng2-activiti-processlist/src/components/activiti-start-process.component.html
index 93f7d9f3c2..d20903ba4d 100644
--- a/ng2-components/ng2-activiti-processlist/src/components/activiti-start-process.component.html
+++ b/ng2-components/ng2-activiti-processlist/src/components/activiti-start-process.component.html
@@ -5,6 +5,7 @@
     <div class="mdl-dialog__content">
         <div class="mdl-textfield mdl-js-textfield alf-mdl-selectfield">
             <select name="processDefinition" [(ngModel)]="processDefinitionId" id="processDefinition">
+                <option value="" selected="selected">{{'START_PROCESS.DIALOG.TYPE_PLACEHOLDER'|translate}}</option>
                 <option *ngFor="let processDef of processDefinitions" [value]="processDef.id">
                     {{processDef.name}}
                 </option>
diff --git a/ng2-components/ng2-activiti-processlist/src/components/activiti-start-process.component.spec.ts b/ng2-components/ng2-activiti-processlist/src/components/activiti-start-process.component.spec.ts
index 1c8becbf26..597396fa5b 100644
--- a/ng2-components/ng2-activiti-processlist/src/components/activiti-start-process.component.spec.ts
+++ b/ng2-components/ng2-activiti-processlist/src/components/activiti-start-process.component.spec.ts
@@ -80,13 +80,13 @@ describe('ActivitiStartProcessButton', () => {
     it('should display the correct number of processes in the select list', () => {
         fixture.detectChanges();
         de = fixture.debugElement.query(By.css('select'));
-        expect(de.children.length).toBe(2);
+        expect(de.children.length).toBe(3);
     });
 
     it('should display the correct process def details', (done) => {
         fixture.detectChanges();
         fixture.whenStable().then(() => {
-            de = fixture.debugElement.query(By.css('select option'));
+            de = fixture.debugElement.queryAll(By.css('select option'))[1];
             let optionEl: HTMLOptionElement = de.nativeElement;
             expect(optionEl.value).toBe('my:process1');
             expect(optionEl.textContent.trim()).toBe('My Process 1');
diff --git a/ng2-components/ng2-activiti-processlist/src/i18n/en.json b/ng2-components/ng2-activiti-processlist/src/i18n/en.json
index 5c45ffab35..2c124caa35 100644
--- a/ng2-components/ng2-activiti-processlist/src/i18n/en.json
+++ b/ng2-components/ng2-activiti-processlist/src/i18n/en.json
@@ -45,6 +45,7 @@
                 "TYPE": "Type",
                 "NAME": "Name"
             },
+            "TYPE_PLACEHOLDER": "Choose one...",
             "ACTION": {
                 "START": "Start",
                 "CANCEL": "Cancel"