ACS-8586: Remove internal dependency on PipeModule (#10086)

2025-07-24 17:32:15 +00:00 · 2024-08-12 14:00:46 -04:00
parent 9527f067a3
commit 58484dd907
21 changed files with 52 additions and 183 deletions
--- a/lib/core/src/lib/card-view/components/card-view-arrayitem/card-view-arrayitem.component.spec.ts
+++ b/lib/core/src/lib/card-view/components/card-view-arrayitem/card-view-arrayitem.component.spec.ts
@@ -26,10 +26,7 @@ import { TestbedHarnessEnvironment } from '@angular/cdk/testing/testbed';
 import { MatChipHarness, MatChipListboxHarness } from '@angular/material/chips/testing';
 import { MatButtonHarness } from '@angular/material/button/testing';
 import { MatIconHarness } from '@angular/material/icon/testing';
-import { MatChipsModule } from '@angular/material/chips';
-import { MatMenuModule } from '@angular/material/menu';
-import { MatButtonModule } from '@angular/material/button';
-import { TranslateModule } from '@ngx-translate/core';
+import { CoreTestingModule } from '@alfresco/adf-core';

 describe('CardViewArrayItemComponent', () => {
    let loader: HarnessLoader;
@@ -54,7 +51,7 @@ describe('CardViewArrayItemComponent', () => {

    beforeEach(() => {
        TestBed.configureTestingModule({
-            imports: [TranslateModule.forRoot(), MatMenuModule, MatButtonModule, MatChipsModule]
+            imports: [CoreTestingModule, CardViewArrayItemComponent]
        });
        fixture = TestBed.createComponent(CardViewArrayItemComponent);
        service = TestBed.inject(CardViewUpdateService);
--- a/lib/core/src/lib/card-view/components/card-view-dateitem/card-view-dateitem.component.spec.ts
+++ b/lib/core/src/lib/card-view/components/card-view-dateitem/card-view-dateitem.component.spec.ts
@@ -22,21 +22,14 @@ import { CardViewUpdateService } from '../../services/card-view-update.service';
 import { CardViewDateItemComponent } from './card-view-dateitem.component';
 import { ClipboardService } from '../../../clipboard/clipboard.service';
 import { CardViewDatetimeItemModel } from '../../models/card-view-datetimeitem.model';
-import { TranslateModule } from '@ngx-translate/core';
 import { AppConfigService } from '../../../app-config/app-config.service';
 import { MatDatetimepickerInputEvent } from '@mat-datetimepicker/core';
 import { HarnessLoader } from '@angular/cdk/testing';
 import { TestbedHarnessEnvironment } from '@angular/cdk/testing/testbed';
 import { MatChipHarness } from '@angular/material/chips/testing';
-import { HttpClientTestingModule } from '@angular/common/http/testing';
-import { MatSnackBarModule } from '@angular/material/snack-bar';
-import { TranslationMock } from '../../../mock';
-import { TranslationService } from '../../../translation';
-import { MatTooltipModule } from '@angular/material/tooltip';
-import { MatDialogModule } from '@angular/material/dialog';
-import { NoopAnimationsModule } from '@angular/platform-browser/animations';
-import { MatDatepickerModule } from '@angular/material/datepicker';
 import { addMinutes } from 'date-fns';
+import { MatSnackBarModule } from '@angular/material/snack-bar';
+import { CoreTestingModule } from '@alfresco/adf-core';

 describe('CardViewDateItemComponent', () => {
    let loader: HarnessLoader;
@@ -46,16 +39,7 @@ describe('CardViewDateItemComponent', () => {

    beforeEach(() => {
        TestBed.configureTestingModule({
-            imports: [
-                TranslateModule.forRoot(),
-                NoopAnimationsModule,
-                HttpClientTestingModule,
-                MatSnackBarModule,
-                MatDatepickerModule,
-                MatDialogModule,
-                MatTooltipModule
-            ],
-            providers: [ClipboardService, { provide: TranslationService, useClass: TranslationMock }]
+            imports: [CoreTestingModule, MatSnackBarModule, CardViewDateItemComponent]
        });
        appConfigService = TestBed.inject(AppConfigService);
        appConfigService.config.dateValues = {
--- a/lib/core/src/lib/card-view/components/card-view-keyvaluepairsitem/card-view-keyvaluepairsitem.component.spec.ts
+++ b/lib/core/src/lib/card-view/components/card-view-keyvaluepairsitem/card-view-keyvaluepairsitem.component.spec.ts
@@ -20,8 +20,7 @@ import { By } from '@angular/platform-browser';
 import { CardViewKeyValuePairsItemModel } from '../../models/card-view-keyvaluepairs.model';
 import { CardViewKeyValuePairsItemComponent } from './card-view-keyvaluepairsitem.component';
 import { CardViewUpdateService } from '../../services/card-view-update.service';
-import { TranslateModule } from '@ngx-translate/core';
-import { NoopAnimationsModule } from '@angular/platform-browser/animations';
+import { CoreTestingModule } from '@alfresco/adf-core';

 describe('CardViewKeyValuePairsItemComponent', () => {
    let fixture: ComponentFixture<CardViewKeyValuePairsItemComponent>;
@@ -32,8 +31,7 @@ describe('CardViewKeyValuePairsItemComponent', () => {

    beforeEach(() => {
        TestBed.configureTestingModule({
-            imports: [NoopAnimationsModule, TranslateModule.forRoot(), CardViewKeyValuePairsItemComponent],
-            providers: [CardViewUpdateService]
+            imports: [CoreTestingModule, CardViewKeyValuePairsItemComponent]
        });
        fixture = TestBed.createComponent(CardViewKeyValuePairsItemComponent);
        cardViewUpdateService = TestBed.inject(CardViewUpdateService);
--- a/lib/core/src/lib/card-view/components/card-view-mapitem/card-view-mapitem.component.spec.ts
+++ b/lib/core/src/lib/card-view/components/card-view-mapitem/card-view-mapitem.component.spec.ts
@@ -21,7 +21,7 @@ import { By } from '@angular/platform-browser';
 import { CardViewMapItemModel } from '../../models/card-view-mapitem.model';
 import { CardViewUpdateService } from '../../services/card-view-update.service';
 import { CardViewMapItemComponent } from './card-view-mapitem.component';
-import { TranslateModule } from '@ngx-translate/core';
+import { CoreTestingModule } from '@alfresco/adf-core';

 describe('CardViewMapItemComponent', () => {
    let service: CardViewUpdateService;
@@ -33,7 +33,7 @@ describe('CardViewMapItemComponent', () => {

    beforeEach(() => {
        TestBed.configureTestingModule({
-            imports: [TranslateModule.forRoot()]
+            imports: [CoreTestingModule, CardViewMapItemComponent]
        });
        fixture = TestBed.createComponent(CardViewMapItemComponent);
        service = TestBed.inject(CardViewUpdateService);
--- a/lib/core/src/lib/card-view/components/card-view-selectitem/card-view-selectitem.component.spec.ts
+++ b/lib/core/src/lib/card-view/components/card-view-selectitem/card-view-selectitem.component.spec.ts
@@ -25,10 +25,7 @@ import { HarnessLoader } from '@angular/cdk/testing';
 import { TestbedHarnessEnvironment } from '@angular/cdk/testing/testbed';
 import { MatSelectHarness } from '@angular/material/select/testing';
 import { MatFormFieldHarness } from '@angular/material/form-field/testing';
-import { HttpClientTestingModule } from '@angular/common/http/testing';
-import { MatSelectModule } from '@angular/material/select';
-import { NoopAnimationsModule } from '@angular/platform-browser/animations';
-import { TranslateModule } from '@ngx-translate/core';
+import { CoreTestingModule } from '@alfresco/adf-core';

 describe('CardViewSelectItemComponent', () => {
    let loader: HarnessLoader;
@@ -62,7 +59,7 @@ describe('CardViewSelectItemComponent', () => {

    beforeEach(() => {
        TestBed.configureTestingModule({
-            imports: [NoopAnimationsModule, TranslateModule.forRoot(), HttpClientTestingModule, MatSelectModule]
+            imports: [CoreTestingModule, CardViewSelectItemComponent]
        });
        fixture = TestBed.createComponent(CardViewSelectItemComponent);
        component = fixture.componentInstance;
--- a/lib/core/src/lib/card-view/components/card-view-textitem/card-view-textitem.component.spec.ts
+++ b/lib/core/src/lib/card-view/components/card-view-textitem/card-view-textitem.component.spec.ts
@@ -25,7 +25,7 @@ import { CardViewItemFloatValidator } from '../../validators/card-view-item-floa
 import { CardViewItemIntValidator } from '../../validators/card-view-item-int.validator';
 import { CardViewIntItemModel } from '../../models/card-view-intitem.model';
 import { CardViewFloatItemModel } from '../../models/card-view-floatitem.model';
-import { MatChipInputEvent, MatChipsModule } from '@angular/material/chips';
+import { MatChipInputEvent } from '@angular/material/chips';
 import { ClipboardService } from '../../../clipboard/clipboard.service';
 import { DebugElement, SimpleChange } from '@angular/core';
 import { CardViewItemValidator } from '../../interfaces/card-view-item-validator.interface';
@@ -111,7 +111,7 @@ describe('CardViewTextItemComponent', () => {

    beforeEach(() => {
        TestBed.configureTestingModule({
-            imports: [CoreTestingModule, MatChipsModule]
+            imports: [CoreTestingModule, CardViewTextItemComponent]
        });
        fixture = TestBed.createComponent(CardViewTextItemComponent);
        component = fixture.componentInstance;
--- a/lib/core/src/lib/card-view/components/card-view/card-view.component.spec.ts
+++ b/lib/core/src/lib/card-view/components/card-view/card-view.component.spec.ts
@@ -20,7 +20,6 @@ import { By } from '@angular/platform-browser';
 import { CardViewDateItemModel } from '../../models/card-view-dateitem.model';
 import { CardViewTextItemModel } from '../../models/card-view-textitem.model';
 import { CardViewComponent } from './card-view.component';
-import { TranslateModule } from '@ngx-translate/core';
 import { CardViewSelectItemModel } from '../../models/card-view-selectitem.model';
 import { of } from 'rxjs';
 import { CardViewSelectItemOption } from '../../interfaces/card-view-selectitem-properties.interface';
@@ -29,36 +28,19 @@ import { CardViewItemDispatcherComponent } from '../card-view-item-dispatcher/ca
 import { HarnessLoader } from '@angular/cdk/testing';
 import { TestbedHarnessEnvironment } from '@angular/cdk/testing/testbed';
 import { MatSelectHarness } from '@angular/material/select/testing';
-import { HttpClientTestingModule } from '@angular/common/http/testing';
 import { MatSnackBarModule } from '@angular/material/snack-bar';
-import { TranslationService } from '../../../translation';
-import { TranslationMock } from '../../../mock';
-import { MatTooltipModule } from '@angular/material/tooltip';
-import { NoopAnimationsModule } from '@angular/platform-browser/animations';
 import { MatDialogModule } from '@angular/material/dialog';
-import { MatDatepickerModule } from '@angular/material/datepicker';
-import { MatSelectModule } from '@angular/material/select';
+import { CoreTestingModule } from '@alfresco/adf-core';

 describe('CardViewComponent', () => {
    let loader: HarnessLoader;
    let fixture: ComponentFixture<CardViewComponent>;
    let component: CardViewComponent;

-    beforeEach(async () => {
-        await TestBed.configureTestingModule({
-            imports: [
-                TranslateModule.forRoot(),
-                NoopAnimationsModule,
-                MatSnackBarModule,
-                MatTooltipModule,
-                MatDialogModule,
-                MatDatepickerModule,
-                MatSelectModule,
-                HttpClientTestingModule,
-                CardViewComponent
-            ],
-            providers: [{ provide: TranslationService, useClass: TranslationMock }]
-        }).compileComponents();
+    beforeEach(() => {
+        TestBed.configureTestingModule({
+            imports: [CoreTestingModule, MatSnackBarModule, MatDialogModule, CardViewComponent]
+        });

        fixture = TestBed.createComponent(CardViewComponent);
        component = fixture.componentInstance;
--- a/lib/core/src/lib/core.module.ts
+++ b/lib/core/src/lib/core.module.ts
@@ -99,7 +99,6 @@ import { MaterialModule } from './material.module';
        }),
        MaterialModule
    ],
-    providers: [...CORE_PIPES],
    exports: [
        ...ABOUT_DIRECTIVES,
        ...VIEWER_DIRECTIVES,
--- a/lib/core/src/lib/form/components/widgets/date-time/date-time.widget.spec.ts
+++ b/lib/core/src/lib/form/components/widgets/date-time/date-time.widget.spec.ts
@@ -20,17 +20,13 @@ import { FormFieldModel } from '../core/form-field.model';
 import { FormModel } from '../core/form.model';
 import { DateTimeWidgetComponent } from './date-time.widget';
 import { TranslateModule } from '@ngx-translate/core';
-import { MatTooltipModule } from '@angular/material/tooltip';
 import { FormFieldTypes } from '../core/form-field-types';
 import { HarnessLoader } from '@angular/cdk/testing';
 import { TestbedHarnessEnvironment } from '@angular/cdk/testing/testbed';
 import { MatInputHarness } from '@angular/material/input/testing';
 import { addMinutes } from 'date-fns';
 import { MatDialogModule } from '@angular/material/dialog';
-import { MatFormFieldModule } from '@angular/material/form-field';
 import { MatDatetimepickerModule, MatNativeDatetimeModule } from '@mat-datetimepicker/core';
-import { MatMenuModule } from '@angular/material/menu';
-import { MatButtonModule } from '@angular/material/button';
 import { MatDatepickerModule } from '@angular/material/datepicker';
 import { NoopAnimationsModule } from '@angular/platform-browser/animations';
 import { HttpClientTestingModule } from '@angular/common/http/testing';
@@ -49,13 +45,10 @@ describe('DateTimeWidgetComponent', () => {
                HttpClientTestingModule,
                NoopAnimationsModule,
                MatDialogModule,
-                MatMenuModule,
-                MatFormFieldModule,
                MatNativeDatetimeModule,
                MatDatepickerModule,
-                MatButtonModule,
                MatDatetimepickerModule,
-                MatTooltipModule
+                DateTimeWidgetComponent
            ]
        });
        fixture = TestBed.createComponent(DateTimeWidgetComponent);
--- a/lib/core/src/lib/form/components/widgets/text/text.widget.spec.ts
+++ b/lib/core/src/lib/form/components/widgets/text/text.widget.spec.ts
@@ -20,15 +20,10 @@ import { FormFieldTypes } from '../core/form-field-types';
 import { FormFieldModel } from '../core/form-field.model';
 import { FormModel } from '../core/form.model';
 import { TextWidgetComponent } from './text.widget';
-import { FormsModule } from '@angular/forms';
-import { MatIconModule } from '@angular/material/icon';
-import { MatInputModule } from '@angular/material/input';
 import { TranslateModule } from '@ngx-translate/core';
 import { HarnessLoader } from '@angular/cdk/testing';
 import { TestbedHarnessEnvironment } from '@angular/cdk/testing/testbed';
 import { MatInputHarness } from '@angular/material/input/testing';
-import { MatFormFieldModule } from '@angular/material/form-field';
-import { MatTooltipModule } from '@angular/material/tooltip';
 import { NoopAnimationsModule } from '@angular/platform-browser/animations';

 describe('TextWidgetComponent', () => {
@@ -42,15 +37,7 @@ describe('TextWidgetComponent', () => {

    beforeEach(() => {
        TestBed.configureTestingModule({
-            imports: [
-                TranslateModule.forRoot(),
-                NoopAnimationsModule,
-                MatInputModule,
-                MatFormFieldModule,
-                MatTooltipModule,
-                FormsModule,
-                MatIconModule
-            ]
+            imports: [TranslateModule.forRoot(), NoopAnimationsModule, TextWidgetComponent]
        });
        fixture = TestBed.createComponent(TextWidgetComponent);
        widget = fixture.componentInstance;
--- a/lib/core/src/lib/pipes/pipe.module.ts
+++ b/lib/core/src/lib/pipes/pipe.module.ts
@@ -61,7 +61,6 @@ export const CORE_PIPES = [
 */
@NgModule({
    imports: [...CORE_PIPES],
-    providers: [...CORE_PIPES],
    exports: [...CORE_PIPES]
 })
 export class PipeModule {}