[ADF-863] codelyzer documentlist (#2059)

* codelyzer documentlist

* tslint error after codelizer

* fix import

* fix tag test

ng2-components/ng2-alfresco-documentlist/config/webpack.common.js

@@ -43,7 +43,8 @@ module.exports = {
                 loader: 'tslint-loader',
                 options: {
                     emitErrors: true,
-                    failOnHint: true
+                    failOnHint: true,
+                    fix: true
                 },
                 exclude: [/node_modules/, /bundles/, /dist/, /demo/]
             },

ng2-components/ng2-alfresco-documentlist/index.ts

@@ -26,7 +26,7 @@ import { ContentColumnListComponent } from './src/components/content-column/cont
 import { ContentColumnComponent } from './src/components/content-column/content-column.component';
 import { DocumentListComponent } from './src/components/document-list.component';
 import { DocumentMenuActionComponent } from './src/components/document-menu-action.component';
-import { EmptyFolderContentComponent } from './src/components/empty-folder/empty-folder-content.component';
+import { EmptyFolderContentDirective } from './src/components/empty-folder/empty-folder-content.directive';
 import { MaterialModule } from './src/material.module';
 
 import { DocumentActionsService } from './src/services/document-actions.service';
@@ -40,7 +40,7 @@ export * from './src/components/content-column/content-column.component';
 export * from './src/components/content-column/content-column-list.component';
 export * from './src/components/content-action/content-action.component';
 export * from './src/components/content-action/content-action-list.component';
-export * from './src/components/empty-folder/empty-folder-content.component';
+export * from './src/components/empty-folder/empty-folder-content.directive';
 export * from './src/components/breadcrumb/breadcrumb.component';
 
 // data
@@ -63,7 +63,7 @@ export const DOCUMENT_LIST_DIRECTIVES: any[] = [
     ContentColumnListComponent,
     ContentActionComponent,
     ContentActionListComponent,
-    EmptyFolderContentComponent,
+    EmptyFolderContentDirective,
     BreadcrumbComponent
 ];
 

ng2-components/ng2-alfresco-documentlist/src/assets/document-library.model.mock.ts

@@ -16,12 +16,12 @@
  */
 
 import {
-    NodePaging,
-    NodeMinimalEntry,
-    NodeMinimal,
-    PathInfoEntity,
     ContentInfo,
-    NodePagingList
+    NodeMinimal,
+    NodeMinimalEntry,
+    NodePaging,
+    NodePagingList,
+    PathInfoEntity
 } from '../models/document-library.model';
 
 export class PageNode extends NodePaging {

ng2-components/ng2-alfresco-documentlist/src/assets/document-list.service.mock.ts

@@ -15,18 +15,18 @@
  * limitations under the License.
  */
 
-import { Observable } from 'rxjs/Rx';
-import { NodePaging } from './../models/document-library.model';
-import { PageNode } from './document-library.model.mock';
-import { DocumentListService } from './../services/document-list.service';
 import {
-    AlfrescoSettingsService,
+    AlfrescoApiService,
     AlfrescoAuthenticationService,
     AlfrescoContentService,
-    AlfrescoApiService,
+    AlfrescoSettingsService,
     LogService
     ThumbnailService
 } from 'ng2-alfresco-core';
+import { Observable } from 'rxjs/Rx';
+import { NodePaging } from './../models/document-library.model';
+import { DocumentListService } from './../services/document-list.service';
+import { PageNode } from './document-library.model.mock';
 
 export class DocumentListServiceMock extends DocumentListService {
 

ng2-components/ng2-alfresco-documentlist/src/components/breadcrumb/breadcrumb.component.spec.ts

@@ -15,13 +15,13 @@
  * limitations under the License.
  */
 
-import { PathElementEntity } from 'alfresco-js-api';
-import { BreadcrumbComponent } from './breadcrumb.component';
-import { DocumentListComponent } from '../document-list.component';
-import { CoreModule } from 'ng2-alfresco-core';
-import { ComponentFixture, TestBed, async } from '@angular/core/testing';
-import { fakeNodeWithCreatePermission } from '../../assets/document-list.component.mock';
 import { SimpleChange } from '@angular/core';
+import { async, ComponentFixture, TestBed } from '@angular/core/testing';
+import { PathElementEntity } from 'alfresco-js-api';
+import { CoreModule } from 'ng2-alfresco-core';
+import { fakeNodeWithCreatePermission } from '../../assets/document-list.component.mock';
+import { DocumentListComponent } from '../document-list.component';
+import { BreadcrumbComponent } from './breadcrumb.component';
 
 declare let jasmine: any;
 

ng2-components/ng2-alfresco-documentlist/src/components/content-action/content-action-list.component.spec.ts

@@ -15,9 +15,9 @@
  * limitations under the License.
  */
 
-import { DocumentListComponent } from './../document-list.component';
 import { DocumentListServiceMock } from './../../assets/document-list.service.mock';
 import { ContentActionModel } from './../../models/content-action.model';
+import { DocumentListComponent } from './../document-list.component';
 import { ContentActionListComponent } from './content-action-list.component';
 
 describe('ContentColumnList', () => {

ng2-components/ng2-alfresco-documentlist/src/components/content-action/content-action.component.spec.ts

@@ -17,14 +17,14 @@
 
 import { EventEmitter } from '@angular/core';
 
-import { DocumentListComponent } from './../document-list.component';
+import { FileNode } from './../../assets/document-library.model.mock';
 import { DocumentListServiceMock } from './../../assets/document-list.service.mock';
-import { ContentActionListComponent } from './content-action-list.component';
-import { ContentActionComponent } from './content-action.component';
+import { ContentActionHandler } from './../../models/content-action.model';
 import { DocumentActionsService } from './../../services/document-actions.service';
 import { FolderActionsService } from './../../services/folder-actions.service';
-import { ContentActionHandler } from './../../models/content-action.model';
-import { FileNode } from './../../assets/document-library.model.mock';
+import { DocumentListComponent } from './../document-list.component';
+import { ContentActionListComponent } from './content-action-list.component';
+import { ContentActionComponent } from './content-action.component';
 
 describe('ContentAction', () => {
 

ng2-components/ng2-alfresco-documentlist/src/components/content-column/content-column-list.component.spec.ts

@@ -17,8 +17,8 @@
 
 import { DataColumn } from 'ng2-alfresco-datatable';
 
-import { DocumentListComponent } from './../document-list.component';
 import { DocumentListServiceMock } from './../../assets/document-list.service.mock';
+import { DocumentListComponent } from './../document-list.component';
 import { ContentColumnListComponent } from './content-column-list.component';
 
 describe('ContentColumnList', () => {

ng2-components/ng2-alfresco-documentlist/src/components/content-column/content-column.component.spec.ts

@@ -15,10 +15,10 @@
  * limitations under the License.
  */
 
-import { DocumentListComponent } from './../document-list.component';
-import { ContentColumnComponent } from './content-column.component';
 import { DocumentListServiceMock } from './../../assets/document-list.service.mock';
+import { DocumentListComponent } from './../document-list.component';
 import { ContentColumnListComponent } from './content-column-list.component';
+import { ContentColumnComponent } from './content-column.component';
 
 describe('ContentColumn', () => {
 

ng2-components/ng2-alfresco-documentlist/src/components/document-list.component.html

@@ -11,7 +11,6 @@
     [actions]="contentActions"
     [actionsPosition]="contentActionsPosition"
     [multiselect]="multiselect"
-    [fallbackThumbnail]="fallbackThumbnail"
     [allowDropFiles]="allowDropFiles"
     [contextMenu]="contextMenuActions"
     [rowStyle]="rowStyle"

ng2-components/ng2-alfresco-documentlist/src/components/document-list.component.spec.ts

@@ -17,7 +17,6 @@
 
 import { NgZone, SimpleChange, TemplateRef } from '@angular/core';
 import { async, ComponentFixture, TestBed } from '@angular/core/testing';
-import { AlfrescoTranslationService, CoreModule } from 'ng2-alfresco-core';
 import { DataTableModule } from 'ng2-alfresco-datatable';
 import { DataColumn, DataRowEvent, DataTableComponent } from 'ng2-alfresco-datatable';
 import { Observable, Subject } from 'rxjs/Rx';
@@ -35,6 +34,7 @@ import { ImageResolver, RowFilter, ShareDataRow } from './../data/share-datatabl
 import { DocumentListService } from './../services/document-list.service';
 import { DocumentListComponent } from './document-list.component';
 import { DocumentMenuActionComponent } from './document-menu-action.component';
+import { CoreModule, AlfrescoTranslationService } from 'ng2-alfresco-core';
 
 declare let jasmine: any;
 

ng2-components/ng2-alfresco-documentlist/src/components/document-menu-action.component.spec.ts

@@ -15,19 +15,19 @@
  * limitations under the License.
  */
 
-import { async, ComponentFixture, TestBed } from '@angular/core/testing';
 import { SimpleChange } from '@angular/core';
+import { async, ComponentFixture, TestBed } from '@angular/core/testing';
+import { MdButtonModule, MdIconModule, MdMenuModule } from '@angular/material';
 import {
+    AlfrescoApiService,
     AlfrescoAuthenticationService,
     AlfrescoSettingsService,
     AlfrescoTranslationService,
-    AlfrescoApiService,
     CoreModule,
     LogService
 } from 'ng2-alfresco-core';
 import { DocumentListService } from './../services/document-list.service';
 import { DocumentMenuActionComponent } from './document-menu-action.component';
-import { MdMenuModule, MdButtonModule, MdIconModule } from '@angular/material';
 
 declare let jasmine: any;
 

ng2-components/ng2-alfresco-documentlist/src/components/empty-folder/empty-folder-content.directive.spec.ts

@@ -17,20 +17,20 @@
 
 import { DataTableComponent } from 'ng2-alfresco-datatable';
 
-import { EmptyFolderContentComponent } from './empty-folder-content.component';
-import { DocumentListComponent } from './../document-list.component';
 import { DocumentListServiceMock } from './../../assets/document-list.service.mock';
+import { DocumentListComponent } from './../document-list.component';
+import { EmptyFolderContentDirective } from './empty-folder-content.directive';
 
 describe('EmptyFolderContent', () => {
 
-    let emptyFolderContent: EmptyFolderContentComponent;
+    let emptyFolderContent: EmptyFolderContentDirective;
     let documentList: DocumentListComponent;
 
     beforeEach(() => {
         let documentListService = new DocumentListServiceMock();
         documentList = new DocumentListComponent(documentListService, null, null, null);
         documentList.dataTable = new DataTableComponent(null, null);
-        emptyFolderContent = new EmptyFolderContentComponent(documentList);
+        emptyFolderContent = new EmptyFolderContentDirective(documentList);
     });
 
     it('is defined', () => {

ng2-components/ng2-alfresco-documentlist/src/components/empty-folder/empty-folder-content.directive.ts

@@ -21,7 +21,7 @@ import { DocumentListComponent } from './../document-list.component';
 @Directive({
     selector: 'empty-folder-content'
 })
-export class EmptyFolderContentComponent implements AfterContentInit {
+export class EmptyFolderContentDirective implements AfterContentInit {
 
     @ContentChild(TemplateRef)
     template: any;

ng2-components/ng2-alfresco-documentlist/src/data/share-datatable-adapter.spec.ts

@@ -15,12 +15,12 @@
  * limitations under the License.
  */
 
-import { TestBed, async } from '@angular/core/testing';
-import { DataColumn, DataRow, DataSorting } from 'ng2-alfresco-datatable';
-import { DocumentListService } from './../services/document-list.service';
-import { ShareDataTableAdapter, ShareDataRow } from './share-datatable-adapter';
-import { FileNode, FolderNode } from './../assets/document-library.model.mock';
+import { async, TestBed } from '@angular/core/testing';
 import { CoreModule } from 'ng2-alfresco-core';
+import { DataColumn, DataRow, DataSorting } from 'ng2-alfresco-datatable';
+import { FileNode, FolderNode } from './../assets/document-library.model.mock';
+import { DocumentListService } from './../services/document-list.service';
+import { ShareDataRow, ShareDataTableAdapter } from './share-datatable-adapter';
 
 describe('ShareDataTableAdapter', () => {
 

ng2-components/ng2-alfresco-documentlist/src/data/share-datatable-adapter.ts

@@ -280,10 +280,6 @@ export class ShareDataRow implements DataRow {
     }
 }
 
-export interface RowFilter {
-    (value: ShareDataRow, index: number, array: ShareDataRow[]): any;
-}
+export type RowFilter = (value: ShareDataRow, index: number, array: ShareDataRow[]) => any;
 
-export interface ImageResolver {
-    (row: DataRow, column: DataColumn): string;
-}
+export type ImageResolver = (row: DataRow, column: DataColumn) => string;

ng2-components/ng2-alfresco-documentlist/src/models/content-action.model.ts

@@ -39,9 +39,7 @@ export class ContentActionModel {
     }
 }
 
-export interface ContentActionHandler {
-    (obj: any, target?: any, permission?: string): any;
-}
+export type ContentActionHandler = (obj: any, target?: any, permission?: string) => any;
 
 export class DocumentActionModel extends ContentActionModel {
     constructor(json?: any)  {

ng2-components/ng2-alfresco-documentlist/src/services/document-actions.service.spec.ts

@@ -16,11 +16,11 @@
  */
 
 import { AlfrescoContentService } from 'ng2-alfresco-core';
+import { FileNode, FolderNode } from '../assets/document-library.model.mock';
+import { DocumentListServiceMock } from '../assets/document-list.service.mock';
 import { ContentActionHandler } from '../models/content-action.model';
 import { DocumentActionsService } from './document-actions.service';
-import { DocumentListServiceMock } from '../assets/document-list.service.mock';
 import { DocumentListService } from './document-list.service';
-import { FileNode, FolderNode } from '../assets/document-library.model.mock';
 
 describe('DocumentActionsService', () => {
 

ng2-components/ng2-alfresco-documentlist/src/services/document-actions.service.ts

@@ -17,7 +17,7 @@
 
 import { Injectable } from '@angular/core';
 import { AlfrescoContentService } from 'ng2-alfresco-core';
-import { Observable } from 'rxjs';
+import { Observable } from 'rxjs/Observable';
 import { Subject } from 'rxjs/Rx';
 import { ContentActionHandler } from '../models/content-action.model';
 import { PermissionModel } from '../models/permissions.model';

ng2-components/ng2-alfresco-documentlist/src/services/document-list.service.spec.ts

@@ -15,10 +15,10 @@
  * limitations under the License.
  */
 
-import { TestBed, async } from '@angular/core/testing';
+import { async, TestBed } from '@angular/core/testing';
 import {
-    CoreModule,
     CookieService,
+    CoreModule,
     LogService,
     LogServiceMock
 } from 'ng2-alfresco-core';

ng2-components/ng2-alfresco-documentlist/src/services/folder-actions.service.spec.ts

@@ -15,11 +15,11 @@
  * limitations under the License.
  */
 
-import { FolderActionsService } from './folder-actions.service';
-import { ContentActionHandler } from '../models/content-action.model';
 import { FileNode, FolderNode } from '../assets/document-library.model.mock';
-import { DocumentListService } from './document-list.service';
 import { DocumentListServiceMock } from '../assets/document-list.service.mock';
+import { ContentActionHandler } from '../models/content-action.model';
+import { DocumentListService } from './document-list.service';
+import { FolderActionsService } from './folder-actions.service';
 
 describe('FolderActionsService', () => {
 

ng2-components/ng2-alfresco-documentlist/tslint.json

@@ -1,4 +1,7 @@
 {
+    "rulesDirectory": [
+        "node_modules/codelyzer"
+    ],
     "rules": {
         "align": [
             true,
@@ -105,14 +108,50 @@
             "allow-leading-underscore",
             "ban-keywords"
         ],
+        "callable-types": true,
+        "import-blacklist": [
+            true,
+            "rxjs"
+        ],
+        "import-spacing": true,
+        "interface-over-type-literal": true,
+        "member-access": false,
+        "no-empty-interface": true,
+        "no-string-literal": false,
+        "no-string-throw": true,
+        "prefer-const": false,
+        "typeof-compare": true,
+        "unified-signatures": true,
         "whitespace": [
             true,
             "check-branch",
+            "check-decl",
             "check-operator",
             "check-separator",
-            "check-type",
-            "check-module",
-            "check-decl"
-        ]
+            "check-type"
+        ],
+        "directive-selector": [
+            true,
+            "attribute",
+            "app",
+            "camelCase"
+        ],
+        "component-selector": [
+            true,
+            "element",
+            "app",
+            "kebab-case"
+        ],
+        "ordered-imports": true,
+        "use-input-property-decorator": true,
+        "use-output-property-decorator": true,
+        "use-host-property-decorator": true,
+        "use-life-cycle-interface": true,
+        "use-pipe-transform-interface": true,
+        "component-class-suffix": true,
+        "directive-class-suffix": true,
+        "no-access-missing-member": true,
+        "templates-use-public": true,
+        "invoke-injectable": true
     }
 }