From 5aec3d4a28a59aacc1587b435be266111a907a17 Mon Sep 17 00:00:00 2001 From: Eugenio Romano Date: Tue, 15 Jan 2019 22:47:28 +0000 Subject: [PATCH] fix linting --- .../datatable/datatable.component.spec.ts | 125 ++++++++++-------- 1 file changed, 68 insertions(+), 57 deletions(-) diff --git a/lib/core/datatable/components/datatable/datatable.component.spec.ts b/lib/core/datatable/components/datatable/datatable.component.spec.ts index 681dd5af70..406854dfdd 100644 --- a/lib/core/datatable/components/datatable/datatable.component.spec.ts +++ b/lib/core/datatable/components/datatable/datatable.component.spec.ts @@ -32,12 +32,15 @@ import { DataColumnComponent } from '../../../data-column/data-column.component' class FakeDataRow implements DataRow { isDropTarget = false; isSelected = true; + hasValue(key: any) { return true; } + getValue() { return '1'; } + imageErrorResolver() { return './assets/images/ft_ic_miscellaneous.svg'; } @@ -467,7 +470,10 @@ describe('DataTable', () => { done(); }); - dataTable.onRowClick(rows[0], { metaKey: true, preventDefault() { } }); + dataTable.onRowClick(rows[0], { + metaKey: true, preventDefault() { + } + }); }); it('should select multiple rows with [multiple] selection mode and modifier key', (done) => { @@ -547,7 +553,7 @@ describe('DataTable', () => { }); it('should emit row click event', (done) => { - let row = {}; + let row = {}; dataTable.rowClick.subscribe((e) => { expect(e.value).toBe(row); @@ -560,7 +566,7 @@ describe('DataTable', () => { it('should emit double click if there are two single click in 250ms', (done) => { - let row = {}; + let row = {}; dataTable.ngOnChanges({}); dataTable.rowDblClick.subscribe(() => { @@ -569,15 +575,15 @@ describe('DataTable', () => { dataTable.onRowClick(row, null); setTimeout(() => { - dataTable.onRowClick(row, null); - } + dataTable.onRowClick(row, null); + } , 240); }); it('should emit double click if there are more than two single click in 250ms', (done) => { - let row = {}; + let row = {}; dataTable.ngOnChanges({}); dataTable.rowDblClick.subscribe(() => { @@ -587,16 +593,16 @@ describe('DataTable', () => { dataTable.onRowClick(row, null); setTimeout(() => { - dataTable.onRowClick(row, null); - dataTable.onRowClick(row, null); - } + dataTable.onRowClick(row, null); + dataTable.onRowClick(row, null); + } , 240); }); it('should emit single click if there are two single click in more than 250ms', (done) => { - let row = {}; + let row = {}; let clickCount = 0; dataTable.ngOnChanges({}); @@ -610,13 +616,13 @@ describe('DataTable', () => { dataTable.onRowClick(row, null); setTimeout(() => { - dataTable.onRowClick(row, null); - } + dataTable.onRowClick(row, null); + } , 260); }); it('should emit row-click dom event', (done) => { - let row = {}; + let row = {}; fixture.nativeElement.addEventListener('row-click', (e) => { expect(e.detail.value).toBe(row); @@ -628,7 +634,7 @@ describe('DataTable', () => { }); it('should emit row-dblclick dom event', (done) => { - let row = {}; + let row = {}; fixture.nativeElement.addEventListener('row-dblclick', (e) => { expect(e.detail.value).toBe(row); @@ -730,9 +736,9 @@ describe('DataTable', () => { it('should invert "select all" status', () => { expect(dataTable.isSelectAllChecked).toBeFalsy(); - dataTable.onSelectAllClick({ checked: true }); + dataTable.onSelectAllClick( { checked: true }); expect(dataTable.isSelectAllChecked).toBeTruthy(); - dataTable.onSelectAllClick({ checked: false }); + dataTable.onSelectAllClick( { checked: false }); expect(dataTable.isSelectAllChecked).toBeFalsy(); }); @@ -742,7 +748,7 @@ describe('DataTable', () => { dataTable.data = data; dataTable.multiselect = true; dataTable.ngAfterContentInit(); - dataTable.onSelectAllClick({ checked: true }); + dataTable.onSelectAllClick( {checked: true }); expect(dataTable.selection.every((entry) => entry.isSelected)); @@ -760,13 +766,13 @@ describe('DataTable', () => { dataTable.multiselect = true; dataTable.ngAfterContentInit(); - dataTable.onSelectAllClick({ checked: true }); + dataTable.onSelectAllClick( {checked: true }); expect(dataTable.isSelectAllChecked).toBe(true); for (let i = 0; i < rows.length; i++) { expect(rows[i].isSelected).toBe(true); } - dataTable.onSelectAllClick({ checked: false }); + dataTable.onSelectAllClick( {checked: false }); expect(dataTable.isSelectAllChecked).toBe(false); for (let i = 0; i < rows.length; i++) { expect(rows[i].isSelected).toBe(false); @@ -777,7 +783,7 @@ describe('DataTable', () => { dataTable.multiselect = true; dataTable.ngOnChanges({ 'data': new SimpleChange('123', {}, true) }); - dataTable.onSelectAllClick({ checked: true }); + dataTable.onSelectAllClick( {checked: true }); expect(dataTable.isSelectAllChecked).toBe(true); }); @@ -789,7 +795,7 @@ describe('DataTable', () => { dataTable.multiselect = false; dataTable.ngAfterContentInit(); - dataTable.onSelectAllClick({ checked: true }); + dataTable.onSelectAllClick( {checked: true }); expect(dataTable.isSelectAllChecked).toBe(true); for (let i = 0; i < rows.length; i++) { expect(rows[i].isSelected).toBe(false); @@ -798,12 +804,12 @@ describe('DataTable', () => { it('should require row and column for icon value check', () => { expect(dataTable.isIconValue(null, null)).toBeFalsy(); - expect(dataTable.isIconValue({}, null)).toBeFalsy(); - expect(dataTable.isIconValue(null, {})).toBeFalsy(); + expect(dataTable.isIconValue( {}, null)).toBeFalsy(); + expect(dataTable.isIconValue(null, {})).toBeFalsy(); }); it('should use special material url scheme', () => { - let column = {}; + let column = {}; let row = { getValue: function (key: string) { @@ -811,11 +817,11 @@ describe('DataTable', () => { } }; - expect(dataTable.isIconValue(row, column)).toBeTruthy(); + expect(dataTable.isIconValue( row, column)).toBeTruthy(); }); it('should not use special material url scheme', () => { - let column = {}; + let column = {}; let row = { getValue: function (key: string) { @@ -823,11 +829,11 @@ describe('DataTable', () => { } }; - expect(dataTable.isIconValue(row, column)).toBeFalsy(); + expect(dataTable.isIconValue( row, column)).toBeFalsy(); }); it('should parse icon value', () => { - let column = {}; + let column = {}; let row = { getValue: function (key: string) { @@ -835,11 +841,11 @@ describe('DataTable', () => { } }; - expect(dataTable.asIconValue(row, column)).toBe('android'); + expect(dataTable.asIconValue( row, column)).toBe('android'); }); it('should not parse icon value', () => { - let column = {}; + let column = {}; let row = { getValue: function (key: string) { @@ -847,7 +853,7 @@ describe('DataTable', () => { } }; - expect(dataTable.asIconValue(row, column)).toBe(null); + expect(dataTable.asIconValue( row, column)).toBe(null); }); it('should parse icon values to a valid i18n key', () => { @@ -858,25 +864,25 @@ describe('DataTable', () => { it('should require column and direction to evaluate sorting state', () => { expect(dataTable.isColumnSorted(null, null)).toBeFalsy(); - expect(dataTable.isColumnSorted({}, null)).toBeFalsy(); + expect(dataTable.isColumnSorted( {}, null)).toBeFalsy(); expect(dataTable.isColumnSorted(null, 'asc')).toBeFalsy(); }); it('should require adapter sorting to evaluate sorting state', () => { dataTable.ngOnChanges({ 'data': new SimpleChange('123', {}, true) }); spyOn(dataTable.data, 'getSorting').and.returnValue(null); - expect(dataTable.isColumnSorted({}, 'asc')).toBeFalsy(); + expect(dataTable.isColumnSorted( {}, 'asc')).toBeFalsy(); }); it('should evaluate column sorting state', () => { dataTable.ngOnChanges({ 'data': new SimpleChange('123', {}, true) }); spyOn(dataTable.data, 'getSorting').and.returnValue(new DataSorting('column_1', 'asc')); - expect(dataTable.isColumnSorted({ key: 'column_1' }, 'asc')).toBeTruthy(); - expect(dataTable.isColumnSorted({ key: 'column_2' }, 'desc')).toBeFalsy(); + expect(dataTable.isColumnSorted( { key: 'column_1' }, 'asc')).toBeTruthy(); + expect(dataTable.isColumnSorted( { key: 'column_2' }, 'desc')).toBeFalsy(); }); it('should replace image source with fallback thumbnail on error', () => { - let event = { + let event = { target: { src: 'missing-image' } @@ -889,7 +895,7 @@ describe('DataTable', () => { it('should replace image source with miscellaneous icon when fallback is not available', () => { const originalSrc = 'missing-image'; - let event = { + let event = { target: { src: originalSrc } @@ -901,48 +907,54 @@ describe('DataTable', () => { }); it('should not get cell tooltip when row is not provided', () => { - const col = { key: 'name', type: 'text' }; + const col = { key: 'name', type: 'text' }; expect(dataTable.getCellTooltip(null, col)).toBeNull(); }); it('should not get cell tooltip when column is not provided', () => { - const row = {}; + const row = {}; expect(dataTable.getCellTooltip(row, null)).toBeNull(); }); it('should not get cell tooltip when formatter is not provided', () => { - const col = { key: 'name', type: 'text' }; - const row = {}; + const col = { key: 'name', type: 'text' }; + const row = {}; expect(dataTable.getCellTooltip(row, col)).toBeNull(); }); it('should use formatter function to generate tooltip', () => { const tooltip = 'tooltip value'; - const col = { + const col = { key: 'name', type: 'text', formatTooltip: () => tooltip }; - const row = {}; + const row = {}; expect(dataTable.getCellTooltip(row, col)).toBe(tooltip); }); it('should return null value from the tooltip formatter', () => { - const col = { + const col = { key: 'name', type: 'text', formatTooltip: () => null }; - const row = {}; + const row = {}; expect(dataTable.getCellTooltip(row, col)).toBeNull(); }); it('should reset the menu cache after rows change', () => { let emitted = 0; - dataTable.showRowActionsMenu.subscribe(() => { emitted++; }); + dataTable.showRowActionsMenu.subscribe(() => { + emitted++; + }); - const column = {}; - const row = { getValue: function (key: string) { return 'id'; } }; + const column = {}; + const row = { + getValue: function (key: string) { + return 'id'; + } + }; dataTable.getRowActions(row, column); dataTable.ngOnChanges({ 'data': new SimpleChange('123', {}, true) }); @@ -952,7 +964,6 @@ describe('DataTable', () => { }); }); - describe('Accesibility', () => { let fixture: ComponentFixture; @@ -976,7 +987,7 @@ describe('Accesibility', () => { fixture.destroy(); }); - it('should have accesibility tags', () => { + it('should have accessibility tags', () => { const dataRows = [ @@ -1001,11 +1012,11 @@ describe('Accesibility', () => { const datatableBodyRowAttributes = element.querySelector('.adf-datatable-body .adf-datatable-row').attributes; const datatableBodyCellAttributes = element.querySelector('.adf-datatable-body .adf-datatable-table-cell').attributes; - expect(datatableAttributes.getNamedItem('role').value).toEqual("grid"); - expect(datatableHeaderAttributes.getNamedItem('role').value).toEqual("rowgroup"); - expect(datatableHeaderCellAttributes.getNamedItem('role').value).toEqual("columnheader"); - expect(datatableBodyAttributes.getNamedItem('role').value).toEqual("rowgroup"); - expect(datatableBodyRowAttributes.getNamedItem('role').value).toEqual("row"); - expect(datatableBodyCellAttributes.getNamedItem('role').value).toEqual("gridcell"); + expect(datatableAttributes.getNamedItem('role').value).toEqual('grid'); + expect(datatableHeaderAttributes.getNamedItem('role').value).toEqual('rowgroup'); + expect(datatableHeaderCellAttributes.getNamedItem('role').value).toEqual('columnheader'); + expect(datatableBodyAttributes.getNamedItem('role').value).toEqual('rowgroup'); + expect(datatableBodyRowAttributes.getNamedItem('role').value).toEqual('row'); + expect(datatableBodyCellAttributes.getNamedItem('role').value).toEqual('gridcell'); }); -}) \ No newline at end of file +});