[ADF-4457] StorageService should be independent of AppConfigService (#4712)

* [ADF-4457] StorageService should be independent of AppConfigService

* [ADF-4457] Fix e2e tests

* [ADF-4457] Fix e2e tests

* [ADF-4457] Improve storage service workflow

* Fix linting

* Fix unit tests

* Fix e2e test

* Add missing class to constructor

* Fix e2e test

* Rebase branch

* Improve unit test

* fix test
This commit is contained in:
davidcanonieto
2019-06-25 16:21:13 +01:00
committed by Eugenio Romano
parent 90c403ae9e
commit 5c07d5b3e6
29 changed files with 432 additions and 369 deletions

View File

@@ -19,7 +19,8 @@ import { async } from '@angular/core/testing';
import { mockError, fakeProcessFilters } from '../../mock';
import { FilterProcessRepresentationModel } from '../models/filter-process.model';
import { ProcessFilterService } from './process-filter.service';
import { AlfrescoApiServiceMock, AlfrescoApiService, AppConfigService, setupTestBed, CoreModule } from '@alfresco/adf-core';
import { AlfrescoApiServiceMock, AlfrescoApiService, AppConfigService,
setupTestBed, CoreModule, StorageService } from '@alfresco/adf-core';
declare let jasmine: any;
@@ -36,7 +37,7 @@ describe('Process filter', () => {
});
beforeEach(() => {
apiService = new AlfrescoApiServiceMock(new AppConfigService(null));
apiService = new AlfrescoApiServiceMock(new AppConfigService(null), new StorageService());
service = new ProcessFilterService(apiService);
alfrescoApi = apiService.getInstance();
});

View File

@@ -21,7 +21,8 @@ import { mockError, fakeProcessDef, fakeTasksList } from '../../mock';
import { ProcessFilterParamRepresentationModel } from '../models/filter-process.model';
import { ProcessInstanceVariable } from '../models/process-instance-variable.model';
import { ProcessService } from './process.service';
import { AlfrescoApiService, AlfrescoApiServiceMock, AppConfigService, setupTestBed, CoreModule } from '@alfresco/adf-core';
import { AlfrescoApiService, AlfrescoApiServiceMock, AppConfigService,
setupTestBed, CoreModule, StorageService } from '@alfresco/adf-core';
declare let moment: any;
@@ -38,7 +39,7 @@ describe('ProcessService', () => {
});
beforeEach(() => {
apiService = new AlfrescoApiServiceMock(new AppConfigService(null));
apiService = new AlfrescoApiServiceMock(new AppConfigService(null), new StorageService());
service = new ProcessService(apiService);
alfrescoApi = apiService.getInstance();
});

View File

@@ -19,7 +19,7 @@ import { async } from '@angular/core/testing';
import { fakeAppFilter, fakeAppPromise, fakeFilters } from '../../mock';
import { FilterRepresentationModel } from '../models/filter.model';
import { TaskFilterService } from './task-filter.service';
import { AlfrescoApiServiceMock, LogService, AppConfigService, setupTestBed, CoreModule } from '@alfresco/adf-core';
import { AlfrescoApiServiceMock, LogService, AppConfigService, setupTestBed, CoreModule, StorageService } from '@alfresco/adf-core';
declare let jasmine: any;
@@ -34,7 +34,9 @@ describe('Activiti Task filter Service', () => {
});
beforeEach(async(() => {
service = new TaskFilterService(new AlfrescoApiServiceMock(new AppConfigService(null)), new LogService(new AppConfigService(null)));
service = new TaskFilterService(
new AlfrescoApiServiceMock(new AppConfigService(null), new StorageService()),
new LogService(new AppConfigService(null)));
jasmine.Ajax.install();
}));

View File

@@ -16,7 +16,7 @@
*/
import { async } from '@angular/core/testing';
import { UserProcessModel, setupTestBed, CoreModule } from '@alfresco/adf-core';
import { UserProcessModel, setupTestBed, CoreModule, StorageService } from '@alfresco/adf-core';
import { of } from 'rxjs';
import {
fakeCompletedTaskList,
@@ -50,7 +50,9 @@ describe('Activiti TaskList Service', () => {
});
beforeEach(async(() => {
service = new TaskListService(new AlfrescoApiServiceMock(new AppConfigService(null)), new LogService(new AppConfigService(null)));
service = new TaskListService(
new AlfrescoApiServiceMock(new AppConfigService(null), new StorageService()),
new LogService(new AppConfigService(null)));
jasmine.Ajax.install();
}));