Removing js-api external dep as it has been moved into ADF repo (#9255)

* Removing js-api external dep

* Fixed targeting

* Fixed targeting with local js-api

* [affected:*] Fixed targeting with local js-api

* Fixed bundle for CI

.github/workflows/pull-request.yml

@@ -206,6 +206,7 @@ jobs:
       - name: install
         run: |
           npm ci
+          npx nx run js-api:bundle
           npx nx run cli:bundle
           npx nx run testing:bundle
       - run: npx nx print-affected $NX_CALCULATION_FLAGS

.github/workflows/release-branch.yml

@@ -97,6 +97,7 @@ jobs:
       - name: install
         run: |
           npm ci
+          npx nx run js-api:bundle
           npx nx run cli:bundle
           npx nx run testing:bundle
       - uses: ./.github/actions/upload-node-modules-and-artifacts

.github/workflows/release.yml

@@ -102,6 +102,7 @@ jobs:
       - name: install
         run: |
           npm ci
+          npx nx run js-api:bundle
           npx nx run cli:bundle
           npx nx run testing:bundle
       - uses: ./.github/actions/upload-node-modules-and-artifacts

angular.json

@@ -253,6 +253,35 @@
           },
           "defaultConfiguration": "production"
         },
+        "bundle": {
+          "executor": "nx:run-commands",
+          "options": {
+            "commands": [
+              {
+                "command": "echo cli bundle created"
+              }
+            ]
+          },
+          "dependsOn": [
+            "copyToNodeModules"
+          ]
+        },
+        "copyToNodeModules": {
+          "executor": "nx:run-commands",
+          "options": {
+            "commands": [
+              {
+                "command": "rm -rf ./node_modules/@alfresco/js-api/ && mkdir -p ./node_modules/@alfresco/js-api/ && cp -R ./dist/libs/js-api/* ./node_modules/@alfresco/js-api/"
+              }
+            ]
+          },
+          "dependsOn": [
+            {
+              "projects": "self",
+              "target": "build"
+            }
+          ]
+        },
         "test": {
           "executor": "nx:run-commands",
           "options": {
@@ -964,7 +993,7 @@
           "options": {
             "commands": [
               {
-                "command": "rm -rf ./node_modules/@alfresco/adf-testing/ && mkdir -p ./node_modules/@alfresco/adf-testing/ &&  cp -R ./dist/libs/testing/* ./node_modules/@alfresco/adf-testing/"
+                "command": "rm -rf ./node_modules/@alfresco/adf-testing/ && mkdir -p ./node_modules/@alfresco/adf-testing/ && cp -R ./dist/libs/testing/* ./node_modules/@alfresco/adf-testing/"
               }
             ]
           },

lib/cli/tsconfig.json

@@ -21,7 +21,10 @@
     "baseUrl": ".",
     "typeRoots": ["node_modules/@types"],
     "types": ["node"],
-    "paths": {}
+    "paths": {
+      "@alfresco/js-api": ["../../dist/libs/js-api"],
+      "@alfresco/js-api/*": ["../../dist/libs/js-api/*"]
+    }
   },
   "exclude": ["dist/**/*", "./build.ts", "node_modules"]
 }

lib/extensions/tsconfig.lib.json

@@ -3,6 +3,10 @@
   "compilerOptions": {
     "outDir": "../../dist/out-tsc",
     "declaration": true,
-    "declarationMap": true
+    "declarationMap": true,
+    "paths": {
+      "@alfresco/js-api": ["../../../dist/libs/js-api"],
+      "@alfresco/js-api/*": ["../../../dist/libs/js-api/*"]
+    }
   }
 }

lib/testing/src/package.json

@@ -1,8 +0,0 @@
-{
-  "ngPackage": {
-    "lib": {
-      "entryFile": "./resources.ts",
-      "flatModuleFile": "adf-testing-resources"
-    }
-  }
-}

lib/testing/tsconfig.json

@@ -8,9 +8,6 @@
     },
     {
       "path": "./tsconfig.lib.prod.json"
-    },
-    {
-      "path": "./tsconfig.spec.json"
     }
   ],
   "compilerOptions": {

lib/testing/tsconfig.lib.json

@@ -1,8 +1,13 @@
 {
   "extends": "./tsconfig.json",
   "compilerOptions": {
-    "outDir": "../../dist/bla",
+    "outDir": "../../dist/out-tsc",
     "declaration": true,
-    "declarationMap": true
+    "declarationMap": true,
+    "resolveJsonModule": true,
+    "paths": {
+      "@alfresco/js-api": ["../../../dist/libs/js-api"],
+      "@alfresco/js-api/*": ["../../../dist/libs/js-api/*"]
+    }
   }
 }

package-lock.json

@@ -10,7 +10,6 @@
       "hasInstallScript": true,
       "license": "Apache-2.0",
       "dependencies": {
-        "@alfresco/js-api": ">=7.6.0",
         "@angular/animations": "14.1.3",
         "@angular/cdk": "14.1.2",
         "@angular/common": "14.1.3",
@@ -169,16 +168,6 @@
         "node": ">=0.10.0"
       }
     },
-    "node_modules/@alfresco/js-api": {
-      "version": "7.6.0",
-      "resolved": "https://registry.npmjs.org/@alfresco/js-api/-/js-api-7.6.0.tgz",
-      "integrity": "sha512-HeWXMfyQLcE0R++LdM+Ex1ORzfF/T6//U3qVRnFzVRjEHlxkuWdZRF78XfK/1rt0PQndYhw9DRacCQyDcPydYw==",
-      "dependencies": {
-        "event-emitter": "^0.3.5",
-        "superagent": "^8.0.9",
-        "tslib": "^2.6.1"
-      }
-    },
     "node_modules/@ampproject/remapping": {
       "version": "2.2.0",
       "dev": true,

package.json

@@ -54,7 +54,6 @@
     "process services-cloud"
   ],
   "dependencies": {
-    "@alfresco/js-api": ">=7.6.0",
     "@angular/animations": "14.1.3",
     "@angular/cdk": "14.1.2",
     "@angular/common": "14.1.3",