Increase timeout and modify login async (#4795)

* increase timeout and modify login async

* run e2e if testing is changed

* improve cdk fix

* fix travis update projects

* disable ghostMode lite server

* lint fix

* fix timeout

* multiple try

* Update content-services-e2e.sh

* Update search-e2e.sh

* Update process-services-e2e.sh

* Update core-e2e.sh

* Update protractor.conf.ts

* fix unit

* remove async

* increqase notification time

* 3 parallel

* dix path issue in save

* small refactor protractor ts

* fix save

* create license check first script adf cli

* modify regex check

* refactor notification history component

* decrease notification

* fix notification message problem

* fix test

* update packages wit high risk

* revert cahnge login sso e2e

* fix dep

* fix documentation duplication and issue

* fix after review

* fix after review

* try 6 parallel test

* back to 3 parallel test no real time improve with 6

lib/core/core.module.ts

@@ -41,6 +41,7 @@ import { CommentsModule } from './comments/comments.module';
 import { ButtonsMenuModule } from './buttons-menu/buttons-menu.module';
 import { TemplateModule } from './templates/template.module';
 import { ClipboardModule } from './clipboard/clipboard.module';
+import { NotificationHistoryModule } from './notification-history/notification-history.module';
 
 import { DirectiveModule } from './directives/directive.module';
 import { DialogModule } from './dialogs/dialog.module';
@@ -87,7 +88,8 @@ import { DirectionalityConfigService } from './services/directionality-config.se
         ButtonsMenuModule,
         TemplateModule,
         IconModule,
-        SortingPickerModule
+        SortingPickerModule,
+        NotificationHistoryModule
     ],
     exports: [
         AboutModule,
@@ -119,7 +121,8 @@ import { DirectionalityConfigService } from './services/directionality-config.se
         ButtonsMenuModule,
         TemplateModule,
         SortingPickerModule,
-        IconModule
+        IconModule,
+        NotificationHistoryModule
     ]
 })
 export class CoreModule {

lib/core/i18n/en.json

@@ -5,6 +5,11 @@
   "CLAIM": "CLAIM",
   "UNCLAIM": "RELEASE",
   "START PROCESS": "START PROCESS",
+  "NOTIFICATION_HISTORY":{
+    "NO_MESSAGE" : "No messages",
+    "NOTIFICATIONS": "Notifications",
+    "MARK_AS_READ": "Mark all as read"
+  },
   "FORM": {
     "START_FORM": {
       "TITLE": "Start Form"

lib/core/index.ts

@@ -41,6 +41,7 @@ export * from './directives/index';
 export * from './clipboard/index';
 export * from './dialogs/index';
 export * from './icon/index';
+export * from './notification-history/index';
 
 export * from './utils/index';
 export * from './interface/index';

lib/core/info-drawer/info-drawer.component.ts

@@ -22,7 +22,7 @@ import { MatTabChangeEvent } from '@angular/material';
     template: '<ng-template><ng-content></ng-content></ng-template>'
 })
 export class InfoDrawerTabComponent {
-    /** The title of the tab. */
+    /** The title of the tab (string or translation key). */
     @Input()
     label: string = '';
 
@@ -42,7 +42,7 @@ export class InfoDrawerTabComponent {
     host: { 'class': 'adf-info-drawer' }
 })
 export class InfoDrawerComponent {
-    /** The title of the info drawer. */
+    /** The title of the info drawer (string or translation key). */
     @Input()
     title: string|null = null;
 

lib/core/models/notification.model.ts

@@ -0,0 +1,21 @@
+/*!
+ * @license
+ * Copyright 2019 Alfresco Software, Ltd.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+export interface NotificationModel {
+    dateTime: Date;
+    message: string;
+}

lib/core/models/public-api.ts

@@ -26,3 +26,4 @@ export * from './redirection.model';
 export * from './pagination.model';
 export * from './oauth-config.model';
 export * from './request-pagination.model';
+export * from './notification.model';

lib/core/notification-history/index.ts

@@ -0,0 +1,18 @@
+/*!
+ * @license
+ * Copyright 2019 Alfresco Software, Ltd.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+export * from './public-api';

lib/core/notification-history/notification-history.component.html

@@ -0,0 +1,33 @@
+<div (keyup)="onKeyPress($event)">
+    <button mat-button [matMenuTriggerFor]="menu" class="adf-notification-history-menu_button"
+            id="adf-notification-history-open-button">
+        <mat-icon>mail_outline</mat-icon>
+    </button>
+    <mat-menu #menu="matMenu" [xPosition]="menuPositionX" [yPosition]="menuPositionY"
+              [overlapTrigger]="false" id="adf-notification-history-menu" class="adf-notification-history-menu">
+
+        <div id="adf-notification-history-list">
+            <mat-list>
+                <mat-list-item>
+                    <h6 mat-line>{{ 'NOTIFICATION_HISTORY.NOTIFICATIONS' | translate }}</h6>
+                </mat-list-item>
+            </mat-list>
+            <mat-divider></mat-divider>
+
+            <mat-list>
+                <mat-list-item *ngFor="let notification of notifications">
+                    <mat-icon mat-list-icon>{{notification.info? notification.info: 'info'}}</mat-icon>
+                    <h4 mat-line>{{notification.message}}</h4>
+                    <p mat-line> {{notification.dateTime | date}} </p>
+                </mat-list-item>
+                <mat-list-item *ngIf="isEmptyNotification()" id="adf-notification-history-component-no-message">
+                    <h4 mat-line>{{ 'NOTIFICATION_HISTORY.NO_MESSAGE' | translate }}</h4>
+                </mat-list-item>
+                <mat-action-list *ngIf="!isEmptyNotification()" id="adf-notification-history-mark-as-read">
+                    <button mat-list-item (click)="markAsRead()">{{ 'NOTIFICATION_HISTORY.MARK_AS_READ' | translate }}
+                    </button>
+                </mat-action-list>
+            </mat-list>
+        </div>
+    </mat-menu>
+</div>

lib/core/notification-history/notification-history.component.scss

@@ -0,0 +1,23 @@
+.adf {
+
+    &-notification-history-menu_button.mat-button {
+        margin-right: 0;
+        border-radius: 90%;
+        padding: 0;
+        min-width: 40px;
+        height: 40px;
+    }
+}
+
+@media only screen and (min-device-width: 480px) {
+    .mat-menu-panel.adf-notification-history-menu {
+        max-height: 450px;
+        min-width: 450px;
+        overflow: auto;
+        padding: 0;
+    }
+}
+
+.mat-menu-panel.adf-notification-history-menu .mat-menu-content {
+    padding: 0;
+}

lib/core/notification-history/notification-history.component.spec.ts

@@ -0,0 +1,80 @@
+/*!
+ * @license
+ * Copyright 2019 Alfresco Software, Ltd.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { async, ComponentFixture, inject, TestBed } from '@angular/core/testing';
+import { NotificationService } from '../services';
+import { setupTestBed } from '../testing/setupTestBed';
+import { CoreTestingModule } from '../testing/core.testing.module';
+import { NotificationHistoryComponent } from './notification-history.component';
+import { OverlayContainer } from '@angular/cdk/overlay';
+
+describe('Notification History Component', () => {
+
+    let fixture: ComponentFixture<NotificationHistoryComponent>;
+    let element: HTMLElement;
+    let notificationService: NotificationService;
+    let overlayContainerElement: HTMLElement;
+
+    function openNotification() {
+        fixture.detectChanges();
+        const button: HTMLButtonElement = <HTMLButtonElement> element.querySelector('#adf-notification-history-open-button');
+        button.click();
+        fixture.detectChanges();
+    }
+
+    setupTestBed({
+        imports: [CoreTestingModule]
+    });
+
+    beforeEach(async(() => {
+        fixture = TestBed.createComponent(NotificationHistoryComponent);
+        element = fixture.nativeElement;
+
+        notificationService = TestBed.get(NotificationService);
+    }));
+
+    beforeEach(inject([OverlayContainer], (oc: OverlayContainer) => {
+        overlayContainerElement = oc.getContainerElement();
+    }));
+
+    afterEach(() => {
+        fixture.destroy();
+    });
+
+    describe('ui ', () => {
+
+        it('should empty message be present when there are no notifications in the history', (done) => {
+            openNotification();
+            fixture.detectChanges();
+            fixture.whenStable().then(() => {
+                expect(overlayContainerElement.querySelector('#adf-notification-history-component-no-message')).toBeDefined();
+                done();
+            });
+        });
+
+        it('should  message be present and empty message not be present when there are notifications in the history', (done) => {
+            notificationService.showInfo('Example Message');
+            openNotification();
+            fixture.detectChanges();
+            fixture.whenStable().then(() => {
+                expect(overlayContainerElement.querySelector('#adf-notification-history-component-no-message')).toBeNull();
+                expect(overlayContainerElement.querySelector('#adf-notification-history-list').innerHTML).toContain('Example Message');
+                done();
+            });
+        });
+    });
+});

lib/core/notification-history/notification-history.component.ts

@@ -0,0 +1,78 @@
+/*!
+ * @license
+ * Copyright 2019 Alfresco Software, Ltd.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { Component, Input, ViewChild, OnDestroy } from '@angular/core';
+import { NotificationService } from '../services/notification.service';
+import { NotificationModel } from '../models/notification.model';
+import { MatMenuTrigger } from '@angular/material';
+import { takeUntil } from 'rxjs/operators';
+import { Subject } from 'rxjs';
+
+@Component({
+    selector: 'adf-notification-history',
+    styleUrls: ['notification-history.component.scss'],
+    templateUrl: 'notification-history.component.html'
+})
+export class NotificationHistoryComponent implements OnDestroy {
+
+    onDestroy$ = new Subject<boolean>();
+
+    notifications: NotificationModel[] = [];
+
+    @ViewChild(MatMenuTrigger)
+    trigger: MatMenuTrigger;
+
+    /** Custom choice for opening the menu at the bottom. Can be `before` or `after`. */
+    @Input()
+    menuPositionX: string = 'after';
+
+    /** Custom choice for opening the menu at the bottom. Can be `above` or `below`. */
+    @Input()
+    menuPositionY: string = 'below';
+
+    constructor(
+        private notificationService: NotificationService) {
+        this.notificationService.messages
+            .pipe(takeUntil(this.onDestroy$))
+            .subscribe((message) => {
+            this.notifications.push(message);
+        });
+    }
+
+    isEmptyNotification(): boolean {
+        return (!this.notifications || this.notifications.length === 0);
+    }
+
+    onKeyPress(event: KeyboardEvent) {
+        this.closeUserModal(event);
+    }
+
+    markAsRead() {
+        this.notifications = [];
+    }
+
+    ngOnDestroy() {
+        this.onDestroy$.next(true);
+        this.onDestroy$.complete();
+    }
+
+    private closeUserModal($event: KeyboardEvent) {
+        if ($event.keyCode === 27) {
+            this.trigger.closeMenu();
+        }
+    }
+}

lib/core/notification-history/notification-history.module.ts

@@ -0,0 +1,38 @@
+/*!
+ * @license
+ * Copyright 2019 Alfresco Software, Ltd.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { CommonModule } from '@angular/common';
+import { NgModule } from '@angular/core';
+import { MaterialModule } from '../material.module';
+
+import { NotificationHistoryComponent } from './notification-history.component';
+import { TranslateModule } from '@ngx-translate/core';
+
+@NgModule({
+    imports: [
+        CommonModule,
+        MaterialModule,
+        TranslateModule.forChild()
+    ],
+    declarations: [
+        NotificationHistoryComponent
+    ],
+    exports: [
+        NotificationHistoryComponent
+    ]
+})
+export class NotificationHistoryModule {}

lib/core/notification-history/public-api.ts

@@ -0,0 +1,19 @@
+/*!
+ * @license
+ * Copyright 2019 Alfresco Software, Ltd.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+export * from './notification-history.component';
+export * from './notification-history.module';

lib/core/services/notification.service.ts

@@ -19,6 +19,8 @@ import { Injectable } from '@angular/core';
 import { MatSnackBar, MatSnackBarRef, MatSnackBarConfig } from '@angular/material';
 import { TranslationService } from './translation.service';
 import { AppConfigService, AppConfigValues } from '../app-config/app-config.service';
+import { Subject } from 'rxjs';
+import { NotificationModel } from '../models/notification.model';
 
 @Injectable({
     providedIn: 'root'
@@ -27,6 +29,8 @@ export class NotificationService {
 
     DEFAULT_DURATION_MESSAGE: number = 5000;
 
+    messages: Subject<NotificationModel> = new Subject();
+
     constructor(private snackBar: MatSnackBar,
                 private translationService: TranslationService,
                 private appConfigService: AppConfigService) {
@@ -53,6 +57,8 @@ export class NotificationService {
             };
         }
 
+        this.messages.next({ message: translatedMessage, dateTime: new Date });
+
         return this.snackBar.open(translatedMessage, null, config);
     }
 
@@ -76,6 +82,8 @@ export class NotificationService {
             };
         }
 
+        this.messages.next({ message: translatedMessage, dateTime: new Date });
+
         return this.snackBar.open(translatedMessage, action, config);
     }
 
@@ -89,6 +97,8 @@ export class NotificationService {
     protected showMessage(message: string, panelClass: string, action?: string): MatSnackBarRef<any> {
         message = this.translationService.instant(message);
 
+        this.messages.next({ message: message, dateTime: new Date });
+
         return this.snackBar.open(message, action, {
             duration: this.DEFAULT_DURATION_MESSAGE,
             panelClass

lib/core/userinfo/components/user-info.component.scss

@@ -183,7 +183,6 @@
     @media only screen and (min-device-width: 480px) {
         .mat-menu-panel.adf-userinfo-menu {
             max-height: 450px;
-            min-width: 4500px;
             min-width: 450px;
             overflow: auto;
             padding: 0;