inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

[NO-ISSUE] RE enable failing test (#3168)

Browse Source 
* restore viewer test

* fix content node selector breadcrumb tests

* fix skipped test

* notification service uncomment test

* remove duplicated test
exclude dialog test
This commit is contained in:
Eugenio Romano
2018-04-11 09:03:03 +01:00
committed by GitHub
parent 12df7500da
commit 5f8b41411a
11 changed files with 58 additions and 143 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/core/pagination/infinite-pagination.component.html
View File

@@ -1,4 +1,4 @@
<div *ngIf="pagination?.hasMoreItems" class="adf-infinite-pagination">
<div *ngIf="pagination?.hasMoreItems || isLoading" class="adf-infinite-pagination">
<button mat-button
*ngIf="!isLoading"
class="adf-infinite-pagination-load-more"

3
lib/core/pagination/infinite-pagination.component.ts
View File

@@ -46,7 +46,7 @@ export class InfinitePaginationComponent implements OnInit, OnDestroy, Paginatio
merge: true
};
/** Pagination object. */
/** @deprecated 2.3.0 Pagination object. */
@Input()
pagination: PaginationModel;
@@ -58,7 +58,6 @@ export class InfinitePaginationComponent implements OnInit, OnDestroy, Paginatio
@Input()
pageSize: number = InfinitePaginationComponent.DEFAULT_PAGE_SIZE;
/** @deprecated 2.3.0 use the paginated component interface to use it. */
/** Is a new page loading? */
@Input('loading')
isLoading: boolean = false;

4
lib/core/pagination/paginated-component.interface.ts
View File

@@ -24,6 +24,6 @@ export interface PaginatedComponent {
* @deprecated 2.3.0 : the supported page size should be retrieved via the user preferences
* and given to the pagination component, and not retrieved by the paginated object
*/
supportedPageSizes: number[];
updatePagination(params: PaginationModel);
supportedPageSizes?: number[];
updatePagination(pagination: PaginationModel);
}

4
lib/core/services/notification.service.spec.ts
View File

@@ -51,7 +51,7 @@ describe('NotificationService', () => {
fixture.detectChanges();
});
xit('should open a message notification bar', (done) => {
it('should open a message notification bar', (done) => {
let promise = fixture.componentInstance.sendMessage();
promise.afterDismissed().subscribe(() => {
done();
@@ -62,7 +62,7 @@ describe('NotificationService', () => {
expect(document.querySelector('snack-bar-container')).not.toBeNull();
});
xit('should open a message notification bar with action', (done) => {
it('should open a message notification bar with action', (done) => {
let promise = fixture.componentInstance.sendMessageAction();
promise.afterDismissed().subscribe(() => {
done();

2
lib/core/viewer/components/viewer.component.spec.ts
View File

@@ -430,7 +430,7 @@ describe('ViewerComponent', () => {
});
xdescribe('View', () => {
describe('View', () => {
describe('Overlay mode true', () => {