Fixed build for all the packages

.eslintignore

@@ -10,3 +10,4 @@ scripts
 docs/**/*.md
 lib/js-api/docs/**/*.md
 .storybook
+webpack.config.js

lib/cli/project.json

@@ -50,7 +50,7 @@
       }
     },
     "lint": {
-      "executor": "@nrwl/linter:eslint",
+      "executor": "@nx/eslint:lint",
       "options": {
         "lintFilePatterns": ["lib/cli/**/*.ts", "lib/cli/**/*.html"]
       }

lib/content-services/project.json

@@ -33,7 +33,7 @@
       }
     },
     "lint": {
-      "executor": "@nrwl/linter:eslint",
+      "executor": "@nx/eslint:lint",
       "options": {
         "lintFilePatterns": ["lib/content-services/**/*.ts", "lib/content-services/**/*.html"]
       }

lib/core/project.json

@@ -24,7 +24,7 @@
       "defaultConfiguration": "production"
     },
     "build-schematics": {
-      "executor": "@nrwl/js:tsc",
+      "executor": "@nx/js:tsc",
       "outputs": ["{options.outputPath}"],
       "options": {
         "outputPath": "dist/libs/core/schematics/migrations",
@@ -48,7 +48,7 @@
       }
     },
     "lint": {
-      "executor": "@nrwl/linter:eslint",
+      "executor": "@nx/eslint:lint",
       "options": {
         "lintFilePatterns": [
           "lib/core/**/*.ts",

lib/eslint-angular/project.json

@@ -11,8 +11,8 @@
         "projectRoot": "lib/eslint-angular",
         "outputPath": "dist/libs/eslint-plugin-eslint-angular",
         "main": "lib/eslint-angular/index.ts",
-        "generatePackageJson": true,
         "tsConfig": "lib/eslint-angular/tsconfig.lib.prod.json",
+        "webpackConfig": "lib/eslint-angular/webpack.config.js",
         "stylePreprocessorOptions": {
           "includePaths": ["lib", "lib/core/src/lib"]
         },
@@ -24,14 +24,13 @@
           "projectRoot": "lib/eslint-angular",
           "outputPath": "dist/libs/eslint-plugin-eslint-angular",
           "main": "lib/eslint-angular/index.ts",
-          "generatePackageJson": true,
           "tsConfig": "lib/eslint-angular/tsconfig.lib.prod.json"
         }
       },
       "defaultConfiguration": "production"
     },
     "lint": {
-      "executor": "@nrwl/linter:eslint",
+      "executor": "@nx/eslint:lint:eslint",
       "options": {
         "lintFilePatterns": ["lib/eslint-angular/**/*.ts"]
       }

lib/eslint-angular/src/rules/no-angular-material-selectors/no-angular-material-selectors.ts

@@ -33,7 +33,7 @@ const messages = {
 
 type MessageIds = keyof typeof messages;
 
-const filetypeErrors: {regexp: RegExp; messageId: MessageIds}[] = [
+const filetypeErrors: { regexp: RegExp; messageId: MessageIds }[] = [
     {
         regexp: /.*\.spec\.ts/,
         messageId: 'useAngularMaterialTestingHarness'
@@ -52,8 +52,7 @@ export default createESLintRule<unknown[], MessageIds>({
     meta: {
         type: 'suggestion',
         docs: {
-            description: 'Disallows using Angular Material internal selectors',
+            description: 'Disallows using Angular Material internal selectors'
-            recommended: 'error'
         },
         hasSuggestions: true,
         schema: [],
@@ -63,9 +62,9 @@ export default createESLintRule<unknown[], MessageIds>({
     create(context) {
         return {
             [ASTSelectors.join(',')](node: TSESTree.Literal | TSESTree.TemplateLiteral) {
-                const message = filetypeErrors.find((fileTypeError) =>
+                const message = filetypeErrors.find((fileTypeError) => context.getFilename().match(fileTypeError.regexp)) || {
-                    context.getFilename().match(fileTypeError.regexp)
+                    messageId: 'noAngularMaterialSelectors'
-                ) || { messageId: 'noAngularMaterialSelectors' };
+                };
 
                 context.report({
                     node,

lib/eslint-angular/src/rules/use-none-component-view-encapsulation/use-none-component-view-encapsulation.ts

@@ -21,7 +21,7 @@ import { createESLintRule } from '../../utils/create-eslint-rule/create-eslint-r
 
 export const RULE_NAME = 'use-none-component-view-encapsulation';
 
-type MessageIds = 'useNoneComponentViewEncapsulation'| 'suggestAddViewEncapsulationNone';
+type MessageIds = 'useNoneComponentViewEncapsulation' | 'suggestAddViewEncapsulationNone';
 type DecoratorForClass = TSESTree.Decorator & {
     parent: TSESTree.ClassDeclaration;
 };
@@ -53,8 +53,7 @@ export default createESLintRule<unknown[], MessageIds>({
     meta: {
         type: 'suggestion',
         docs: {
-            description: `Disallows using other encapsulation than \`${viewEncapsulationNone}\``,
+            description: `Disallows using other encapsulation than \`${viewEncapsulationNone}\``
-            recommended: false
         },
         hasSuggestions: true,
         schema: [],
@@ -65,18 +64,13 @@ export default createESLintRule<unknown[], MessageIds>({
     },
     defaultOptions: [],
     create(context) {
-        const encapsulationProperty = Selectors.metadataProperty(
+        const encapsulationProperty = Selectors.metadataProperty(metadataPropertyName);
-            metadataPropertyName
-        );
         const withoutEncapsulationProperty =
             `${Selectors.COMPONENT_CLASS_DECORATOR}:matches([expression.arguments.length=0], [expression.arguments.0.type='ObjectExpression']:not(:has(${encapsulationProperty})))` as const;
         const nonNoneViewEncapsulationNoneProperty =
             `${Selectors.COMPONENT_CLASS_DECORATOR} > CallExpression > ObjectExpression > ` +
             `${encapsulationProperty}:matches([value.type='Identifier'][value.name='undefined'], [value.object.name='ViewEncapsulation'][value.property.name!='None'])`;
-        const selectors = [
+        const selectors = [withoutEncapsulationProperty, nonNoneViewEncapsulationNoneProperty].join(',');
-            withoutEncapsulationProperty,
-            nonNoneViewEncapsulationNoneProperty
-        ].join(',');
         return {
             [selectors](node: DecoratorForClass | PropertyInClassDecorator) {
                 context.report({
@@ -92,7 +86,7 @@ export default createESLintRule<unknown[], MessageIds>({
                                             fixer,
                                             importName: 'ViewEncapsulation',
                                             moduleName: '@angular/core',
-                                            node: node.parent.parent.parent.parent
+                                            node: node.parent
                                         }),
                                         ASTUtils.isMemberExpression(node.value)
                                             ? fixer.replaceText(node.value.property, 'None')
@@ -107,11 +101,7 @@ export default createESLintRule<unknown[], MessageIds>({
                                         moduleName: '@angular/core',
                                         node: node.parent
                                     }),
-                                    RuleFixes.getDecoratorPropertyAddFix(
+                                    RuleFixes.getDecoratorPropertyAddFix(node, fixer, `${metadataPropertyName}: ${viewEncapsulationNone}`)
-                                        node,
-                                        fixer,
-                                        `${metadataPropertyName}: ${viewEncapsulationNone}`
-                                    )
                                 ].filter(isNotNullOrUndefined);
                             }
                         }

lib/eslint-angular/tsconfig.json

@@ -11,7 +11,7 @@
         "skipLibCheck": true,
         "baseUrl": "src",
         "types": [
-            "node"
+            "node", "@typescript-eslint/utils"
         ]
     },
     "include": [

lib/eslint-angular/webpack.config.js

@@ -0,0 +1,20 @@
+const { NxAppWebpackPlugin } = require('@nx/webpack/app-plugin');
+const { join } = require('path');
+
+module.exports = {
+    output: {
+        path: join(__dirname, '../../dist/libs/eslint-angular')
+    },
+    devServer: {
+        port: 4200
+    },
+    plugins: [
+        new NxAppWebpackPlugin({
+            main: './index.ts',
+            tsConfig: './tsconfig.lib.json',
+            index: './index.ts',
+            outputHashing: process.env['NODE_ENV'] === 'production' ? 'all' : 'none',
+            optimization: process.env['NODE_ENV'] === 'production'
+        })
+    ]
+};

lib/extensions/project.json

@@ -32,7 +32,7 @@
       }
     },
     "lint": {
-      "executor": "@nrwl/linter:eslint",
+      "executor": "@nx/eslint:lint",
       "options": {
         "lintFilePatterns": ["lib/extensions/**/*.ts", "lib/extensions/**/*.html"]
       }

lib/insights/project.json

@@ -33,7 +33,7 @@
       }
     },
     "lint": {
-      "executor": "@nrwl/linter:eslint",
+      "executor": "@nx/eslint:lint",
       "options": {
         "lintFilePatterns": ["lib/insights/**/*.ts", "lib/insights/**/*.html"]
       }

lib/js-api/project.json

@@ -6,7 +6,7 @@
   "prefix": "adf",
   "targets": {
     "build": {
-      "executor": "@nrwl/js:tsc",
+      "executor": "@nx/js:tsc",
       "outputs": ["{options.outputPath}"],
       "dependsOn": ["build-esm5"],
       "options": {
@@ -24,7 +24,7 @@
       }
     },
     "build-esm5": {
-      "executor": "@nrwl/js:tsc",
+      "executor": "@nx/js:tsc",
       "outputs": ["{options.outputPath}"],
       "dependsOn": ["build-esm2015"],
       "options": {
@@ -34,7 +34,7 @@
       }
     },
     "build-esm2015": {
-      "executor": "@nrwl/js:tsc",
+      "executor": "@nx/js:tsc",
       "outputs": ["{options.outputPath}"],
       "dependsOn": ["build-cjs"],
       "options": {
@@ -44,7 +44,7 @@
       }
     },
     "build-cjs": {
-      "executor": "@nrwl/js:tsc",
+      "executor": "@nx/js:tsc",
       "outputs": ["{options.outputPath}"],
       "options": {
         "outputPath": "dist/libs/js-api",
@@ -54,7 +54,7 @@
       }
     },
     "build-types": {
-      "executor": "@nrwl/js:tsc",
+      "executor": "@nx/js:tsc",
       "outputs": ["{options.outputPath}"],
       "options": {
         "outputPath": "dist/libs/js-api/typings",
@@ -76,7 +76,7 @@
       }
     },
     "lint": {
-      "executor": "@nrwl/linter:eslint",
+      "executor": "@nx/eslint:lint",
       "outputs": ["{options.outputFile}"],
       "options": {
         "lintFilePatterns": ["lib/js-api/**/*.ts"]

lib/process-services-cloud/project.json

@@ -33,7 +33,7 @@
       }
     },
     "lint": {
-      "executor": "@nrwl/linter:eslint",
+      "executor": "@nx/eslint:lint",
       "options": {
         "lintFilePatterns": ["lib/process-services-cloud/**/*.ts", "lib/process-services-cloud/**/*.html"]
       }

lib/process-services/project.json

@@ -33,7 +33,7 @@
       }
     },
     "lint": {
-      "executor": "@nrwl/linter:eslint",
+      "executor": "@nx/eslint:lint",
       "options": {
         "lintFilePatterns": ["lib/process-services/**/*.ts", "lib/process-services/**/*.html"]
       }

lib/testing/project.json

@@ -6,12 +6,11 @@
   "prefix": "adf",
   "targets": {
     "build": {
-      "executor": "@nrwl/webpack:webpack",
+      "executor": "@nx/webpack:webpack",
       "options": {
         "projectRoot": "lib/testing",
         "outputPath": "dist/libs/testing",
         "main": "lib/testing/index.ts",
-        "generatePackageJson": true,
         "tsConfig": "lib/testing/tsconfig.lib.prod.json",
         "webpackConfig": "lib/testing/webpack.config.js",
         "stylePreprocessorOptions": {
@@ -25,14 +24,13 @@
           "projectRoot": "lib/testing",
           "outputPath": "dist/libs/testing",
           "main": "lib/testing/index.ts",
-          "generatePackageJson": true,
+          "tsConfig": "lib/testing/tsconfig.lib.prod.json"
-          "tsConfig": "lib/testing/tsconfig.lib.prod.json",
         }
       },
       "defaultConfiguration": "production"
     },
     "lint": {
-      "executor": "@nrwl/linter:eslint",
+      "executor": "@nx/eslint:lint",
       "options": {
         "lintFilePatterns": ["lib/testing/**/*.ts", "lib/testing/**/*.html"]
       }

nx.json

@@ -6,22 +6,12 @@
   "$schema": "./node_modules/nx/schemas/nx-schema.json",
   "targetDefaults": {
     "build": {
-      "dependsOn": [
+      "dependsOn": ["^build"],
-        "^build"
+      "inputs": ["production", "^production"],
-      ],
-      "inputs": [
-        "production",
-        "^production"
-      ],
       "cache": true
     },
     "build-storybook": {
-      "inputs": [
+      "inputs": ["default", "^production", "{projectRoot}/.storybook/**/*", "{projectRoot}/tsconfig.storybook.json"]
-        "default",
-        "^production",
-        "{projectRoot}/.storybook/**/*",
-        "{projectRoot}/tsconfig.storybook.json"
-      ]
     },
     "lint": {
       "cache": true
@@ -36,18 +26,12 @@
   "tasksRunnerOptions": {
     "default": {
       "options": {
-        "cacheDirectory": "nxcache",
+        "runtimeCacheInputs": ["node -v"]
-        "runtimeCacheInputs": [
-          "node -v"
-        ]
       }
     }
   },
   "namedInputs": {
-    "default": [
+    "default": ["{projectRoot}/**/*", "sharedGlobals"],
-      "{projectRoot}/**/*",
-      "sharedGlobals"
-    ],
     "sharedGlobals": [
       "{workspaceRoot}/angular.json",
       "{workspaceRoot}/demo-shell/src/index.html",
@@ -63,5 +47,6 @@
       "!{projectRoot}/karma.conf.js",
       "!{projectRoot}/tsconfig.storybook.json"
     ]
-  }
+  },
+  "cacheDirectory": "nxcache"
 }

package.json

@@ -117,6 +117,7 @@
     "@typescript-eslint/eslint-plugin": "6.21.0",
     "@typescript-eslint/parser": "6.21.0",
     "@typescript-eslint/typescript-estree": "7.1.1",
+    "@typescript-eslint/utils": "^8.8.1",
     "ajv": "^8.12.0",
     "commander": "12.0.0",
     "css-loader": "^7.1.2",
@@ -130,7 +131,7 @@
     "eslint-config-prettier": "9.1.0",
     "eslint-plugin-ban": "^1.6.0",
     "eslint-plugin-import": "2.29.1",
-    "eslint-plugin-jsdoc": "50.6.1",
+    "eslint-plugin-jsdoc": "50.3.1",
     "eslint-plugin-license-header": "0.6.0",
     "eslint-plugin-prefer-arrow": "1.2.3",
     "eslint-plugin-prettier": "^4.2.1",
@@ -161,7 +162,7 @@
     "ng-packagr": "17.1.2",
     "nock": "13.5.5",
     "npm-run-all": "^4.1.5",
-    "nx": "17.3.1",
+    "nx": "^20.0.0",
     "postcss": "8.4.41",
     "postcss-sass": "^0.5.0",
     "prettier": "2.8.8",