Addressed review comments

This commit is contained in:
Raviraj Bahirsheth 2023-04-14 13:39:28 +05:30 committed by GitHub
parent bf287f8a6c
commit 6474e7b865
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -19,15 +19,14 @@ upgrade.
### Manual update ### Manual update
1. Update the `package.json` file with the latest library versions: 1. Update the `package.json` file with the latest library versions:
``` ```json
"dependencies": { "dependencies": {
... "@alfresco/adf-core": "5.0.0",
@alfresco/adf-core: "5.0.0", "@alfresco/adf-content-services": "5.0.0",
@alfresco/adf-content-services: "5.0.0", "@alfresco/adf-process-services-cloud": "5.0.0",
@alfresco/adf-process-services-cloud: "5.0.0", "@alfresco/adf-insights": "5.0.0",
@alfresco/adf-insights: "5.0.0", "@alfresco/js-api": "5.0.0",
@alfresco/js-api: "5.0.0", }
...
``` ```
2. Clean your old distribution and dependencies by deleting `node_modules` and `package-lock.json`. 2. Clean your old distribution and dependencies by deleting `node_modules` and `package-lock.json`.
@ -58,12 +57,12 @@ upgrade.
**Note:**: Consider the possibility of leveraging [ADF v5.0.0-angular.13.2](https://www.npmjs.com/package/@alfresco/adf-core/v/5.0.0-angular.13.2), **Note:**: Consider the possibility of leveraging [ADF v5.0.0-angular.13.2](https://www.npmjs.com/package/@alfresco/adf-core/v/5.0.0-angular.13.2),
a version of ADF compatible with Angular 13 that is meant to be used as intermediate step towards ADF v5. with angular v14. a version of ADF compatible with Angular 13 that is meant to be used as intermediate step towards ADF v5. with angular v14.
4. A breaking change worth mentioning is related to style import. with ADF v5.0.0 an extra `\lib` is required. 4. A breaking change worth mentioning is related to style import. with ADF v5.0.0 an extra `/lib` is required.
**example**: **example**:
previous versions of ADF : `@import '~@alfresco/adf-core/prebuilt-themes/adf-blue-orange.css';` previous versions of ADF : `@import '~@alfresco/adf-core/prebuilt-themes/adf-blue-orange.css';`
starting ADF 5.0.0 : `@import '~@alfresco/adf-core/lib/prebuilt-themes/adf-blue-orange.css';` starting ADF 5.0.0 : `@import '~@alfresco/adf-core/lib/prebuilt-themes/adf-blue-orange.css';`