inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-31 17:38:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Updated unit tests based on code review suggestions

Browse Source
This commit is contained in:
Denys Vuika
2016-10-14 11:53:15 +01:00
parent 3d3b156194
commit 64b8343f02
6 changed files with 92 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
ng2-components/ng2-activiti-form/src/components/widgets/display-value/display-value.widget.spec.ts
View File

@@ -292,15 +292,15 @@ describe('DisplayValueWidget', () => {
});
it('should setup rest field values with REST options', () => {
spyOn(formService, 'getRestFieldValues').and.callFake(() => {
return Observable.create(observer => {
spyOn(formService, 'getRestFieldValues').and.returnValue(
Observable.create(observer => {
observer.next([
{ id: '1', name: 'option 1' },
{ id: '2', name: 'option 2' }
]);
observer.complete();
});
});
})
);
let form = new FormModel({ taskId: '<id>' });
@@ -324,15 +324,15 @@ describe('DisplayValueWidget', () => {
});
it('should not setup rest field values with missing REST option', () => {
spyOn(formService, 'getRestFieldValues').and.callFake(() => {
return Observable.create(observer => {
spyOn(formService, 'getRestFieldValues').and.returnValue(
Observable.create(observer => {
observer.next([
{ id: '1', name: 'option 1' },
{ id: '2', name: 'option 2' }
]);
observer.complete();
});
});
})
);
let form = new FormModel({ taskId: '<id>' });
@@ -352,12 +352,12 @@ describe('DisplayValueWidget', () => {
});
it('should not setup rest field values with no REST response', () => {
spyOn(formService, 'getRestFieldValues').and.callFake(() => {
return Observable.create(observer => {
spyOn(formService, 'getRestFieldValues').and.returnValue(
Observable.create(observer => {
observer.next(null);
observer.complete();
});
});
})
);
let form = new FormModel({ taskId: '<id>' });
@@ -378,9 +378,9 @@ describe('DisplayValueWidget', () => {
it('should handle rest error', () => {
const error = 'ERROR';
spyOn(formService, 'getRestFieldValues').and.callFake(() => {
return Observable.throw(error);
});
spyOn(formService, 'getRestFieldValues').and.returnValue(
Observable.throw(error)
);
spyOn(console, 'log').and.stub();