Pre-Angular 9 upgrade fixes (#5712)

* remove deprecated angular/http

* upgrade adf libs

* fix production builds

* ivy-compatible translate module usage

* improved module usage

* upgrade content services module

* fix process services tests

* upgrade process cloud tests

* lint fixes

* update core max size

* fix insights test module

* remove insights lazy loading workaround

* fix insights module exports

* * Fixed skipped form-cloud unit test and removed duplicated tests

* cleanup the use of services

Co-authored-by: sivakumar414ram <siva.kumar@muraai.com>
This commit is contained in:
Denys Vuika
2020-05-20 16:51:51 +01:00
committed by GitHub
parent 4cb3a876d9
commit 654be10dd2
185 changed files with 622 additions and 1156 deletions

View File

@@ -21,12 +21,9 @@ import { FormFieldModel, FormFieldTypes, FormModel } from './../widgets/core/ind
import { TextWidgetComponent, CheckboxWidgetComponent } from '../widgets/index';
import { FormFieldComponent } from './form-field.component';
import { setupTestBed } from '../../../testing/setup-test-bed';
import { NoopAnimationsModule } from '@angular/platform-browser/animations';
import { FormBaseModule } from '../../form-base.module';
import { TranslationService } from '../../../services/translation.service';
import { TranslationMock } from '../../../mock/translation.service.mock';
import { TranslateStore } from '@ngx-translate/core';
import { formWithOneVisibleAndOneInvisibleFieldMock, formWithOneVisibleAndOneInvisibleTabMock } from '../mock/form-renderer.component.mock';
import { CoreTestingModule } from '../../../testing';
describe('FormFieldComponent', () => {
@@ -38,12 +35,8 @@ describe('FormFieldComponent', () => {
setupTestBed({
imports: [
NoopAnimationsModule,
CoreTestingModule,
FormBaseModule
],
providers: [
{ provide: TranslationService, useClass: TranslationMock },
TranslateStore
]
});

View File

@@ -16,13 +16,11 @@
*/
import { async, ComponentFixture, TestBed } from '@angular/core/testing';
import { TranslationService, TranslationMock } from '../../index';
import { of } from 'rxjs';
import { FormService } from '../services/form.service';
import { FormListComponent } from './form-list.component';
import { setupTestBed } from '../../testing/setup-test-bed';
import { CoreModule } from '../../core.module';
import { NoopAnimationsModule } from '@angular/platform-browser/animations';
import { CoreTestingModule } from '../../testing/core.testing.module';
describe('TaskAttachmentList', () => {
@@ -33,11 +31,7 @@ describe('TaskAttachmentList', () => {
setupTestBed({
imports: [
NoopAnimationsModule,
CoreModule.forRoot()
],
providers: [
{ provide: TranslationService, useClass: TranslationMock }
CoreTestingModule
]
});

View File

@@ -17,7 +17,6 @@
import { TestBed, ComponentFixture } from '@angular/core/testing';
import { setupTestBed } from '../../testing/setup-test-bed';
import { NoopAnimationsModule } from '@angular/platform-browser/animations';
import { FormRendererComponent } from './form-renderer.component';
import { FormBaseModule } from '../form-base.module';
import { formDisplayValueVisibility,
@@ -32,10 +31,8 @@ import { formDisplayValueVisibility,
textWidgetVisibility,
numberWidgetVisibilityForm,
radioWidgetVisibiltyForm } from './mock/form-renderer.component.mock';
import { TranslationService } from 'core/services';
import { TranslationMock } from 'core/mock';
import { TranslateStore } from '@ngx-translate/core';
import { FormService } from '../services/form.service';
import { CoreTestingModule } from '../../testing';
function typeIntoInput(targetInput: HTMLInputElement, message: string ) {
expect(targetInput).not.toBeNull('Expected input to set to be valid and not null');
@@ -80,12 +77,8 @@ describe('Form Renderer Component', () => {
setupTestBed({
imports: [
NoopAnimationsModule,
CoreTestingModule,
FormBaseModule
],
providers: [
{ provide: TranslationService, useClass: TranslationMock },
TranslateStore
]
});

View File

@@ -19,12 +19,9 @@ import { ComponentFixture, TestBed } from '@angular/core/testing';
import { FormFieldModel } from './../core/form-field.model';
import { AmountWidgetComponent, ADF_AMOUNT_SETTINGS } from './amount.widget';
import { setupTestBed } from '../../../../testing/setup-test-bed';
import { NoopAnimationsModule } from '@angular/platform-browser/animations';
import { FormBaseModule } from '../../../form-base.module';
import { TranslateStore } from '@ngx-translate/core';
import { TranslationService } from '../../../../services/translation.service';
import { TranslationMock } from '../../../../mock/translation.service.mock';
import { FormModel } from '../core';
import { CoreTestingModule } from '../../../../testing/core.testing.module';
describe('AmountWidgetComponent', () => {
@@ -33,12 +30,8 @@ describe('AmountWidgetComponent', () => {
setupTestBed({
imports: [
NoopAnimationsModule,
CoreTestingModule,
FormBaseModule
],
providers: [
{ provide: TranslationService, useClass: TranslationMock },
TranslateStore
]
});
@@ -92,12 +85,8 @@ describe('AmountWidgetComponent - rendering', () => {
setupTestBed({
imports: [
NoopAnimationsModule,
CoreTestingModule,
FormBaseModule
],
providers: [
{ provide: TranslationService, useClass: TranslationMock },
TranslateStore
]
});
@@ -162,12 +151,10 @@ describe('AmountWidgetComponent settings', () => {
setupTestBed({
imports: [
NoopAnimationsModule,
CoreTestingModule,
FormBaseModule
],
providers: [
{ provide: TranslationService, useClass: TranslationMock },
TranslateStore,
{
provide: ADF_AMOUNT_SETTINGS,
useValue: {

View File

@@ -22,10 +22,10 @@ import { FormModel } from '../core/form.model';
import { CheckboxWidgetComponent } from './checkbox.widget';
import { setupTestBed } from '../../../../testing/setup-test-bed';
import { FormBaseModule } from 'core/form/form-base.module';
import { NoopAnimationsModule } from '@angular/platform-browser/animations';
import { TranslateService, TranslateStore, TranslateLoader } from '@ngx-translate/core';
import { TranslateLoaderService } from 'core/services';
import { MatCheckboxModule } from '@angular/material';
import { CoreTestingModule } from '../../../../testing';
describe('CheckboxWidgetComponent', () => {
@@ -35,7 +35,7 @@ describe('CheckboxWidgetComponent', () => {
setupTestBed({
imports: [
NoopAnimationsModule,
CoreTestingModule,
FormBaseModule,
MatCheckboxModule
],

View File

@@ -24,8 +24,7 @@ import { FormModel } from './../core/form.model';
import { ContainerWidgetComponent } from './container.widget';
import { ContainerWidgetComponentModel } from './container.widget.model';
import { setupTestBed } from '../../../../testing/setup-test-bed';
import { CoreModule } from '../../../../core.module';
import { NoopAnimationsModule } from '@angular/platform-browser/animations';
import { CoreTestingModule } from '../../../../testing';
describe('ContainerWidgetComponent', () => {
@@ -34,8 +33,7 @@ describe('ContainerWidgetComponent', () => {
setupTestBed({
imports: [
NoopAnimationsModule,
CoreModule.forRoot()
CoreTestingModule
]
});

View File

@@ -18,16 +18,14 @@
import { SimpleChange } from '@angular/core';
import { async, ComponentFixture, TestBed } from '@angular/core/testing';
import { By } from '@angular/platform-browser';
import { TranslationService, ContentService } from '../../../../services';
import { ContentService } from '../../../../services';
import { of } from 'rxjs';
import { ProcessContentService } from '../../../services/process-content.service';
import { ContentLinkModel } from '../index';
import { ContentWidgetComponent } from './content.widget';
import { setupTestBed } from '../../../../testing/setup-test-bed';
import { CoreModule } from '../../../../core.module';
import { NoopAnimationsModule } from '@angular/platform-browser/animations';
import { TranslationMock } from '../../../../mock/translation.service.mock';
import { CoreTestingModule } from '../../../../testing/core.testing.module';
declare let jasmine: any;
@@ -65,11 +63,7 @@ describe('ContentWidgetComponent', () => {
setupTestBed({
imports: [
NoopAnimationsModule,
CoreModule.forRoot()
],
providers: [
{ provide: TranslationService, useClass: TranslationMock }
CoreTestingModule
]
});

View File

@@ -21,8 +21,7 @@ import { FormFieldModel } from './../core/form-field.model';
import { FormModel } from './../core/form.model';
import { DateTimeWidgetComponent } from './date-time.widget';
import { setupTestBed } from '../../../../testing/setup-test-bed';
import { CoreModule } from '../../../../core.module';
import { NoopAnimationsModule } from '@angular/platform-browser/animations';
import { CoreTestingModule } from '../../../../testing/core.testing.module';
describe('DateTimeWidgetComponent', () => {
@@ -32,8 +31,7 @@ describe('DateTimeWidgetComponent', () => {
setupTestBed({
imports: [
NoopAnimationsModule,
CoreModule.forRoot()
CoreTestingModule
]
});

View File

@@ -21,8 +21,7 @@ import { FormFieldModel } from './../core/form-field.model';
import { FormModel } from './../core/form.model';
import { DateWidgetComponent } from './date.widget';
import { setupTestBed } from '../../../../testing/setup-test-bed';
import { CoreModule } from '../../../../core.module';
import { NoopAnimationsModule } from '@angular/platform-browser/animations';
import { CoreTestingModule } from '../../../../testing/core.testing.module';
describe('DateWidgetComponent', () => {
@@ -32,8 +31,7 @@ describe('DateWidgetComponent', () => {
setupTestBed({
imports: [
NoopAnimationsModule,
CoreModule.forRoot()
CoreTestingModule
]
});

View File

@@ -26,8 +26,7 @@ import { FormModel } from './../core/form.model';
import { FormFieldTypes } from '../core/form-field-types';
import { DropdownWidgetComponent } from './dropdown.widget';
import { setupTestBed } from '../../../../testing/setup-test-bed';
import { CoreModule } from '../../../../core.module';
import { NoopAnimationsModule } from '@angular/platform-browser/animations';
import { CoreTestingModule } from '../../../../testing/core.testing.module';
describe('DropdownWidgetComponent', () => {
@@ -50,8 +49,7 @@ describe('DropdownWidgetComponent', () => {
setupTestBed({
imports: [
NoopAnimationsModule,
CoreModule.forRoot()
CoreTestingModule
]
});

View File

@@ -24,8 +24,7 @@ import { DynamicTableRow } from './dynamic-table-row.model';
import { DynamicTableWidgetComponent } from './dynamic-table.widget';
import { DynamicTableModel } from './dynamic-table.widget.model';
import { setupTestBed } from '../../../../testing/setup-test-bed';
import { CoreModule } from '../../../../core.module';
import { NoopAnimationsModule } from '@angular/platform-browser/animations';
import { CoreTestingModule } from '../../../../testing/core.testing.module';
const fakeFormField = {
id: 'fake-dynamic-table',
@@ -79,8 +78,7 @@ describe('DynamicTableWidgetComponent', () => {
setupTestBed({
imports: [
NoopAnimationsModule,
CoreModule.forRoot()
CoreTestingModule
]
});

View File

@@ -22,10 +22,9 @@ import { DynamicTableRow } from './../../dynamic-table-row.model';
import { DynamicTableModel } from './../../dynamic-table.widget.model';
import { DateEditorComponent } from './date.editor';
import { setupTestBed } from '../../../../../../testing/setup-test-bed';
import { CoreModule } from '../../../../../../core.module';
import { NoopAnimationsModule } from '@angular/platform-browser/animations';
import { By } from '@angular/platform-browser';
import { MatDatepickerInputEvent } from '@angular/material';
import { CoreTestingModule } from '../../../../../../testing';
describe('DateEditorComponent', () => {
let component: DateEditorComponent;
@@ -36,8 +35,7 @@ describe('DateEditorComponent', () => {
setupTestBed({
imports: [
NoopAnimationsModule,
CoreModule.forRoot()
CoreTestingModule
]
});

View File

@@ -23,8 +23,7 @@ import { DynamicTableRow } from './../../dynamic-table-row.model';
import { DynamicTableModel } from './../../dynamic-table.widget.model';
import { DateTimeEditorComponent } from './datetime.editor';
import { setupTestBed } from '../../../../../../testing/setup-test-bed';
import { CoreModule } from '../../../../../../core.module';
import { NoopAnimationsModule } from '@angular/platform-browser/animations';
import { CoreTestingModule } from '../../../../../../testing/core.testing.module';
describe('DateTimeEditorComponent', () => {
let component: DateTimeEditorComponent;
@@ -35,8 +34,7 @@ describe('DateTimeEditorComponent', () => {
setupTestBed({
imports: [
NoopAnimationsModule,
CoreModule.forRoot()
CoreTestingModule
]
});

View File

@@ -26,8 +26,7 @@ import { DynamicTableRow } from './../../dynamic-table-row.model';
import { DynamicTableModel } from './../../dynamic-table.widget.model';
import { DropdownEditorComponent } from './dropdown.editor';
import { setupTestBed } from '../../../../../../testing/setup-test-bed';
import { CoreModule } from '../../../../../../core.module';
import { NoopAnimationsModule } from '@angular/platform-browser/animations';
import { CoreTestingModule } from '../../../../../../testing/core.testing.module';
describe('DropdownEditorComponent', () => {
@@ -40,8 +39,7 @@ describe('DropdownEditorComponent', () => {
setupTestBed({
imports: [
NoopAnimationsModule,
CoreModule.forRoot()
CoreTestingModule
]
});

View File

@@ -18,13 +18,10 @@ import { ComponentFixture, TestBed } from '@angular/core/testing';
import { FormFieldTypes } from '../core/form-field-types';
import { FormFieldModel } from './../core/form-field.model';
import { FormModel } from './../core/form.model';
import { TranslateModule, TranslateStore, TranslateService } from '@ngx-translate/core';
import { WidgetComponent } from './../widget.component';
import { TranslationService } from '../../../../services';
import { HyperlinkWidgetComponent } from './hyperlink.widget';
import { setupTestBed } from '../../../../testing/setup-test-bed';
import { TranslationMock } from '../../../../mock/translation.service.mock';
import { HttpClientModule } from '@angular/common/http';
import { CoreTestingModule } from '../../../../testing';
describe('HyperlinkWidgetComponent', () => {
@@ -34,16 +31,7 @@ describe('HyperlinkWidgetComponent', () => {
setupTestBed({
imports: [
TranslateModule.forChild(),
HttpClientModule
],
declarations: [
HyperlinkWidgetComponent
],
providers: [
TranslateStore,
TranslateService,
{ provide: TranslationService, useClass: TranslationMock }
CoreTestingModule
]
});

View File

@@ -25,9 +25,8 @@ import { FormFieldModel } from '../core/form-field.model';
import { FormModel } from '../core/form.model';
import { PeopleWidgetComponent } from './people.widget';
import { setupTestBed } from '../../../../testing/setup-test-bed';
import { CoreModule } from '../../../../core.module';
import { NoopAnimationsModule } from '@angular/platform-browser/animations';
import { TranslateService } from '@ngx-translate/core';
import { CoreTestingModule } from '../../../../testing/core.testing.module';
describe('PeopleWidgetComponent', () => {
@@ -39,8 +38,7 @@ describe('PeopleWidgetComponent', () => {
setupTestBed({
imports: [
NoopAnimationsModule,
CoreModule.forRoot()
CoreTestingModule
]
});

View File

@@ -25,15 +25,9 @@ import { FormFieldModel } from './../core/form-field.model';
import { FormModel } from './../core/form.model';
import { RadioButtonsWidgetComponent } from './radio-buttons.widget';
import { setupTestBed } from '../../../../testing/setup-test-bed';
import { NoopAnimationsModule } from '@angular/platform-browser/animations';
import { TranslateModule, TranslateStore, TranslateService } from '@ngx-translate/core';
import { MatIconModule, MatRadioModule } from '@angular/material';
import { FormsModule } from '@angular/forms';
import { HttpClientModule } from '@angular/common/http';
import { ErrorWidgetComponent } from '../error/error.component';
import { TranslationService } from '../../../../services';
import { TranslationMock } from '../../../../mock/translation.service.mock';
import { DisplayTextWidgetComponent } from '../display-text/display-text.widget';
import { CoreTestingModule } from '../../../../testing';
describe('RadioButtonsWidgetComponent', () => {
@@ -42,22 +36,10 @@ describe('RadioButtonsWidgetComponent', () => {
setupTestBed({
imports: [
NoopAnimationsModule,
TranslateModule.forChild(),
CoreTestingModule,
MatRadioModule,
FormsModule,
MatIconModule,
HttpClientModule
],
declarations: [
RadioButtonsWidgetComponent,
ErrorWidgetComponent,
DisplayTextWidgetComponent
],
providers: [
TranslateStore,
TranslateService,
{ provide: TranslationService, useClass: TranslationMock }
MatIconModule
]
});

View File

@@ -16,15 +16,13 @@
*/
import { tick, fakeAsync, async, ComponentFixture, TestBed, flush } from '@angular/core/testing';
import { fakeFormJson, TranslationMock } from '../../../../mock';
import { fakeFormJson } from '../../../../mock';
import { FormFieldModel } from '../core/form-field.model';
import { FormModel } from '../core/form.model';
import { TabModel } from '../core/tab.model';
import { TabsWidgetComponent } from './tabs.widget';
import { setupTestBed } from '../../../../testing/setup-test-bed';
import { CoreModule } from '../../../../core.module';
import { NoopAnimationsModule } from '@angular/platform-browser/animations';
import { TranslationService } from '../../../../services/translation.service';
import { CoreTestingModule } from '../../../../testing/core.testing.module';
describe('TabsWidgetComponent', () => {
@@ -32,11 +30,7 @@ describe('TabsWidgetComponent', () => {
setupTestBed({
imports: [
NoopAnimationsModule,
CoreModule.forRoot()
],
providers: [
{ provide: TranslationService, useClass: TranslationMock }
CoreTestingModule
]
});

View File

@@ -21,15 +21,9 @@ import { FormFieldModel } from '../core/form-field.model';
import { FormModel } from '../core/form.model';
import { TextWidgetComponent } from './text.widget';
import { setupTestBed } from '../../../../testing/setup-test-bed';
import { NoopAnimationsModule } from '@angular/platform-browser/animations';
import { TranslationMock } from '../../../../mock/translation.service.mock';
import { TranslationService } from '../../../../services';
import { FormsModule } from '@angular/forms';
import { TranslateModule, TranslateStore, TranslateService } from '@ngx-translate/core';
import { MatInputModule, MatIconModule } from '@angular/material';
import { InputMaskDirective } from './text-mask.component';
import { ErrorWidgetComponent } from '../error/error.component';
import { HttpClientModule } from '@angular/common/http';
import { CoreTestingModule } from '../../../../testing';
const enterValueInTextField = (element: HTMLInputElement, value: string) => {
element.value = value;
@@ -45,22 +39,10 @@ describe('TextWidgetComponent', () => {
setupTestBed({
imports: [
NoopAnimationsModule,
TranslateModule.forChild(),
CoreTestingModule,
MatInputModule,
FormsModule,
MatIconModule,
HttpClientModule
],
declarations: [
TextWidgetComponent,
InputMaskDirective,
ErrorWidgetComponent
],
providers: [
TranslateStore,
TranslateService,
{ provide: TranslationService, useClass: TranslationMock }
MatIconModule
]
});

View File

@@ -26,9 +26,8 @@ import { FormFieldModel } from '../core/form-field.model';
import { FormModel } from '../core/form.model';
import { TypeaheadWidgetComponent } from './typeahead.widget';
import { setupTestBed } from '../../../../testing/setup-test-bed';
import { CoreModule } from '../../../../core.module';
import { NoopAnimationsModule } from '@angular/platform-browser/animations';
import { TranslateService } from '@ngx-translate/core';
import { CoreTestingModule } from '../../../../testing/core.testing.module';
describe('TypeaheadWidgetComponent', () => {
@@ -38,8 +37,7 @@ describe('TypeaheadWidgetComponent', () => {
setupTestBed({
imports: [
NoopAnimationsModule,
CoreModule.forRoot()
CoreTestingModule
]
});

View File

@@ -26,8 +26,7 @@ import { FormModel } from '../core/form.model';
import { FormFieldModel } from './../core/form-field.model';
import { UploadWidgetComponent } from './upload.widget';
import { setupTestBed } from '../../../../testing/setup-test-bed';
import { CoreModule } from '../../../../core.module';
import { NoopAnimationsModule } from '@angular/platform-browser/animations';
import { CoreTestingModule } from '../../../../testing/core.testing.module';
const fakePngAnswer = {
'id': 1155,
@@ -82,8 +81,7 @@ describe('UploadWidgetComponent', () => {
setupTestBed({
imports: [
NoopAnimationsModule,
CoreModule.forRoot()
CoreTestingModule
]
});

View File

@@ -20,8 +20,7 @@ import { FormFieldModel } from './core/form-field.model';
import { FormModel } from './core/form.model';
import { WidgetComponent } from './widget.component';
import { setupTestBed } from '../../../testing/setup-test-bed';
import { CoreModule } from '../../../core.module';
import { NoopAnimationsModule } from '@angular/platform-browser/animations';
import { CoreTestingModule } from '../../../testing';
describe('WidgetComponent', () => {
@@ -31,8 +30,7 @@ describe('WidgetComponent', () => {
setupTestBed({
imports: [
NoopAnimationsModule,
CoreModule.forRoot()
CoreTestingModule
]
});